14 Dec
2007
14 Dec
'07
2:07 p.m.
Dan Smith wrote:
I didn't notice this before, but shouldn't we initialize prop_list to NULL, make sure free_rasd_prop_list() can handle NULL, and then put the free call below the out: target? There is another place in the function that looks like it jumps to out after prop_list could have been initialized. Further, it would be better to have it below out, so that additions like this one don't have to add or utilize an err: target.
Heidi, I know this isn't really a part of your patch, but I think it's worth looking at while we're here.
Jay, can you comment?
Thanks!
This seems like a reasonable request to me. -- Kaitlin Rupert IBM Linux Technology Center karupert@us.ibm.com