Re: [Libvirt-cim] [PATCH] [TEST] #3 Make sure network pool is created with a random IP

16 Mar 2009


      ...
...
@@ -210,10 +211,25 @@
         subnet = '192.168.122.'
         self.add_sub_node(network, 'bridge', name=self.vbr, stp='on',
                                              forwardDelay='0')
-        ip = self.add_sub_node(network, 'ip', address=subnet+'1',
+        ip_base = random.randint(1, 100)
+        addr = subnet+'%d' % ip_base
+        addr = subnet+'1'
You are reassigning addr variable which removes the purpose of assigning 
new random ip.
Oops!  I had made some changes to do some testing, and I forgot to 
revert my changes before sending.  =(  I'll clean this up and send again.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin@linux.vnet.ibm.com

    