Re: [Libvirt-cim] [PATCH 3 of 4] Add support for ref checking to VSMigrationCapabilities

> + } > > inst = get_typed_instance(broker, > CLASSNAME(ref), > As the connection is established at this point in time and through all the other code we use pfx_from_conn(conn) in that case, it might be good to also use this here instead of CLASSNAME(ref). But that's more a convenience thing.

> static CMPIStatus return_vsmc(const CMPIObjectPath *ref, > const CMPIResult *results, > - bool name_only) > + bool name_only, > + bool is_get_inst) > { > CMPIInstance *inst; > This is causing the reproducible seg fault on my system. Please initialize inst = NULL. In the case of a Xen request on a KVM only system this uninitialized inst is disorienting the check for inst ==NULL and afterwards seg faulting the return instance functions - as inst is only containing garbage.