+ }
inst = get_typed_instance(broker, CLASSNAME(ref),
As the connection is established at this point in time and through all the other code we use pfx_from_conn(conn) in that case, it might be good to also use this here instead of CLASSNAME(ref). But that's more a convenience thing.
Good point. =)
static CMPIStatus return_vsmc(const CMPIObjectPath *ref, const CMPIResult *results, - bool name_only) + bool name_only, + bool is_get_inst) { CMPIInstance *inst;
This is causing the reproducible seg fault on my system. Please initialize inst = NULL. In the case of a Xen request on a KVM only system this uninitialized inst is disorienting the check for inst ==NULL and afterwards seg faulting the return instance functions - as inst is only containing garbage.
Thanks for tracking this down! I'll send a new patch to fix this and the other issues you mentioned. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com