Re: [Libvirt-cim] [PATCH] Fix up style issues in device_parsing.c

5 Jan 2008


      ...
if (!ddev->type)

...
if (!ddev->device)

...
if (!ddev->driver)

...
if (ddev->source) {

...
if (!ndev->mac)
                 goto err;
+
         if (!ndev->bridge) {
Since we have "if (edev->path != NULL)" below, should we change these as 
well?
...
edev->path = get_node_content(node);
+        if (edev->path != NULL)
+                goto err;

...
if (!nsv)

...
-                if (!list) {
...
+        if (!list) {
...
if (!ret_list) {
And these too?  Although, I can't say as I mind either way. =)


-- 
Kaitlin Rupert
IBM Linux Technology Center
karupert@us.ibm.com