Kaitlin Rupert wrote:
Dan Smith wrote:
Changes to the third patch only. Sorry the first round didn't have a commit log :)
The consolidation of get_* functions into the get_devices() is nice. Makes the patch a bit tough to read, but the resulting device_parsing.c file is much easier to read. +1 I do not have that many experiences with the device-parsing stuff, but I agree, that the code is good to read. Testing is a bit difficult, as I get the following message when doing an ein on VSSD: misc_util.c(70): Connecting to libvirt with uri `qemu:///system' device_parsing.c(818): Unknown domain type -1
Seems like KVM is not supported at the moment. But the instance for VSSD is returned by ein and gi. So a +1 with the excuse for not testing it correct. -- Regards Heidi Eckhart Software Engineer IBM Linux Technology Center - Open Hypervisor