Re: [Libvirt-cim] [PATCH 1 of 5] DevicePool: adopt get_ interface common look and feel

HE> +CMPIStatus get_pool_by_name(const CMPIBroker *broker, HE> + const CMPIObjectPath *reference, HE> + const char *id, HE> + CMPIInstance **_inst) HE> +{ HE> + CMPIStatus s = {CMPI_RC_OK, NULL}; HE> + virConnectPtr conn = NULL; You add a conn here... HE> out: HE> inst_list_free(&list); HE> - return inst; HE> + return s; HE> } ...but don't close it here. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms(a)us.ibm.com