3 Mar
2008
3 Mar
'08
5:31 p.m.
JG> if (s.rc != CMPI_RC_OK) { JG> virDomainFree(list[i]); JG> continue; JG> } JG> should achieve the same functionality but in what I would call a much JG> cleaner way. Everyone, feel free to chime in here one way or the JG> other. That's a valid point, although I would rather have one cleanup path to avoid leaks in the future. Why not just have the conditional be (s.rc == CMPI_RC_OK) and do the add there? Anyway, it's minor so I've applied this patch set. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com