Re: [Libvirt-cim] [PATCH 4 of 4] Add URI support to VSMigrationService

KR> + if (transport == CIM_MIGRATE_URI_TLS_STRICT) KR> + rc = asprintf(&uri, "%s://%s/system/?no_verify=1", tport, dest); KR> + else KR> + rc = asprintf(&uri, "%s://%s/system/", tport, dest); KR> + KR> + if (rc == -1) KR> uri = NULL; KR> + KR> + free(tport); This seems a tad ugly, since it's just a special case for one of the transport types. Can we change the function to just construct a whole URI for us, and pass in the class and the destination host? KR> @@ -147,7 +186,7 @@ static CMPIStatus vs_migratable(const CM KR> uint32_t retcode = 1; KR> CMPIBoolean isMigratable = 0; KR> - uri = dest_uri(CLASSNAME(ref), destination); KR> + uri = dest_uri(CLASSNAME(ref), destination, CIM_MIGRATE_URI_SSH); Is this hardcoding the check function to SSH? Otherwise I'm really happy with this set, thanks! -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms(a)us.ibm.com