Re: [Libvirt-cim] [PATCH 03 of 12] Make ElementAllocatedFromPool use connect_by_classname()

Dan Smith wrote:

{ @@ -156,8 +156,10 @@ static int devs_from_pool(uint16_t type, virDomainPtr *doms = NULL; int count; int i; - - conn = lv_connect(_BROKER, &s); + const char *ns = NAMESPACE(ref); + const char *cn = CLASSNAME(ref); + + conn = connect_by_classname(_BROKER, cn, &s); if (conn == NULL) return 0;

This is terribly nit-picky.. but why use variables for ns and cn? They only get used once in this function, right? I suppose it does look cleaner though. -- Kaitlin Rupert IBM Linux Technology Center karupert@us.ibm.com