Re: [Libvirt-cim] [PATCH] Enumeration on VirtualSystemManagementService class is returning dups
Jay Gagnon wrote:
Heidi Eckhart wrote:
> # HG changeset patch
> # User Heidi Eckhart <heidieck(a)linux.vnet.ibm.com>
> # Date 1195735052 -3600
> # Node ID fb84303afda80d4d180e9951b114f2769a5d6baa
> # Parent 710a381591c1a67e5a79ad3b04aaa8bc7adbb108
> Enumeration on VirtualSystemManagementService class is returning dups
>
> On systems where only one hypervisor is existing, the provider
> returned instance for all known subclasses (Xen, KVM).
> Signed-off-by: Heidi Eckhart <heidieck(a)linux.vnet.ibm.com>
>
>
>
>
This looks good, although the same little issue with virConnectClose()
applies here as well. +1
Sorry, reading that back I don't think it came out right. The idea was
supposed to be that I'm fine with what the new changes do, and assuming
the virConnectClose() bit gets cleaned up, I'm +1 on it. That cleanup
will hardly be a total rework of the patch, so I think it's safe to say
we can apply the cleaned up one once it hits the list.
--
-Jay