+def get_vssd_rasd(ip, virt, addr): + class_vssd = get_vssd_class(virt) + vssd = class_vssd(test_dom, virt) + + vssd, rasd = default_vssd_rasd_str( + dom_name=test_dom, virt=virt)
The above line can be wrapped in a single 80 column line. We do not require default_vssd_rasd_str().
Yes, I meant to put a comment here that get_vssd_class() should be replaced by a function that returns a mof. Currently, get_vssd_class() returns an object that is prefixed by XenKvmLib.vsms.<>, which doesn't work properly when passed to the DefineSystem() call. default_vssd_rasd_str() strips this piece away when it calls .mof() on the class. I'll include a patch to fix this when I resend.
+ + rasds = get_default_rasds(ip, virt) + + for i in range(0, len(rasds)):
just range(len(rasds)) will work.
Good call =) -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com