Re: [Libvirt-cim] [PATCH] [TEST] Fix RAFP.02 failuer for KVM, using existing networkpool instead of creating a new one
Deepti B Kalakeri wrote:
Also, for the part of the tc below:
for rasd_cn, id_info in cn_id_list.iteritems():
status = get_rasdinst_verify_pool_from_RAFP(server, virt, vsxml,
rasd_cn, id_info)
if status != PASS:
return status
Please include the following for status != PASS:
cleanup_restore(server, virt)
destroy_netpool(server, virt, test_network)
This won't be needed if the create_netpool_conf() function is removed.
vsxml.undefine(server)
get_rasdinst_verify_pool_from_RAFP() handles the undefine() already.
But I think the undefine() calls should be removed from the
get_rasdinst_verify_pool_from_RAFP() call and instead handled as you say
Deepti - by something like the following:
status != PASS:
cleanup_restore(server, virt)
vsxml.undefine(server)
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com