Re: [Libvirt-cim] [PATCH] [TEST] Making use of the lib fn conf_file(), cleanup_restore() and create_diskpool_file()
Kaitlin Rupert wrote:
> diff -r 0123ff5809dc -r 70e13e2a2abf
> suites/libvirt-cim/cimtest/ElementAllocatedFromPool/04_forward_errs.py
> exp_list = [
> - {'desc' : "No such instance (SystemName)", 'rc' :
> pywbem.CIM_ERR_NOT_FOUND}, \
> - {'desc' : "No DeviceID specified", 'rc' :
pywbem.CIM_ERR_FAILED}, \
> - {'desc' : "No such instance", 'rc' :
pywbem.CIM_ERR_NOT_FOUND}, \
> - {'desc' : "One or more parameter values passed to the method were
> invalid", \
> - 'rc' : pywbem.CIM_ERR_INVALID_PARAMETER}, \
> - {'desc' : "No such instance (CreationClassName)", 'rc' :
> pywbem.CIM_ERR_NOT_FOUND }, \
> - {'desc' : "No such instance (SystemCreationClassName)",
'rc' : \
> - pywbem.CIM_ERR_NOT_FOUND }, + {'desc' : "No such instance
> (SystemName)", 'rc' : pywbem.CIM_ERR_NOT_FOUND}, + {'desc' :
"No
> DeviceID specified", 'rc' : pywbem.CIM_ERR_FAILED}, + {'desc' :
"No
> such instance", 'rc' : pywbem.CIM_ERR_NOT_FOUND}, + {'desc' :
> "CIM_ERR_INVALID_PARAMETER", + 'rc' :
> pywbem.CIM_ERR_INVALID_PARAMETER}, + {'desc' : "No such instance
> (CreationClassName)",
> + 'rc' : pywbem.CIM_ERR_NOT_FOUND }, + {'desc' : "No such
instance
> (SystemCreationClassName)", + 'rc' : pywbem.CIM_ERR_NOT_FOUND }, ]
These changes cause this to fail on F9 with a release rpm. Would be
good to branch this test so that it passes on both the release rpm and
on current sources.
The Error messages that is being returned when an
InvalidCreationClassname is passed is different for pegasus and sfcb.
On *F9 with sfcb and latest KVM provider* the 04_forward_errs.py tc
passes with the error message *"One or more parameter values passed to
the method were invalid",
*while on *F9 or RHEL **with pegasus with the latest source* the
04_forward_errs.py tc passes with the error message*
"*CIM_ERR_INVALID_PARAMETER".
I believe these error messages are from the CIMOM and not from the
providers.
Any suggestion how do we fix this ?
>
> - return try_assoc(conn, exp_ret, test_dom_invalid, test_keys, \
> - test_vals, log_msg)
> + return try_assoc(conn, exp_ret, test_dom_invalid, test_keys,
> test_vals, + log_msg)
>