Re: [Libvirt-cim] [PATCH 3/4] libxkutil: Provide easy access to the libvirt capabilities
On 08/15/2013 10:48 AM, Viktor Mihajlovski wrote:
From: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com>
Introspecting the libvirt capabilities and creating an internal capabilities
data structure. Methods are provided for retrieving default values regarding
architecture, machine and emulator for easy of use in the provider code.
Further, xml_parse_test was extendend to display hypervisor capabilities
and defaults.
Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com>
Signed-off-by: Viktor Mihajlovski <mihajlov(a)linux.vnet.ibm.com>
---
libxkutil/Makefile.am | 2 +
libxkutil/capability_parsing.c | 462 ++++++++++++++++++++++++++++++++++++++++
libxkutil/capability_parsing.h | 93 ++++++++
libxkutil/xml_parse_test.c | 134 +++++++++++-
4 files changed, 688 insertions(+), 3 deletions(-)
create mode 100644 libxkutil/capability_parsing.c
create mode 100644 libxkutil/capability_parsing.h
Seems there's some duplication in a couple of places, but the
capabilities checking seems to me to be the better way to go about
things. I remember reviewing something recently regarding checking for
"kvm" - perhaps in device_parsing.c (a quick cscope search on "kvm")
In any case, this looks good and has passed both the cimtest and
coverity tests
ACK,
John