Dan Smith wrote:
HE> +CMPIStatus get_profile(const CMPIBroker *broker, HE> + const CMPIObjectPath *reference, HE> + const char **properties, HE> + const char* interop_namespace, HE> + const char* pfx, HE> + struct reg_prof *profile, HE> + CMPIInstance **_inst)
This is a really long function signature. You seem to call it with a constant for "interop_namespace". Is there any reason to keep it variable, instead of just assuming the constant inside the function?
As this is only a preparation for the case that "who ever" would force us to also work with Pegasus' root/PG_InterOp namespace ... what would definitely mean, that we had to update the provider anyway ... I'm also fine with removing this currently not-used-future-outlook parameter.
HE> CMPIStatus s = {CMPI_RC_OK, NULL}; HE> CMPIInstance *instance = NULL; HE> - HE> +
You add whitespace here.
Oops ... will fix it -- Regards Heidi Eckhart Software Engineer IBM Linux Technology Center - Open Hypervisor