Re: [Libvirt-cim] [PATCH 1 of 3] Add function to parse InstanceIDs

KR> +bool parse_instanceid(const CMPIObjectPath *ref, KR> + char **pfx, KR> + char **name) KR> +{ KR> + int ret; KR> + char *id = NULL; KR> + KR> + id = cu_get_str_path(ref, "InstanceID"); KR> + if (id == NULL) KR> + return false; KR> + KR> + ret = parse_id(id, pfx, name); KR> + if (!ret) KR> + return false; KR> + KR> + return true; KR> +} You leak "id" here :) -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms(a)us.ibm.com