Re: [Libvirt-cim] [PATCH 1 of 3] Add VirtualSystemSnapshotService

HE> It would be good to also add the domain and save_path information HE> to the Job instance, e.g. as value of the property "Name". Okay, I'll stuff it in there somewhere. HE> Somehow I think that success and error scenarios are merged by HE> this function. Even if a snapshot request failed, the JobState has HE> COMPLETE, which is in general correct. But the client can only HE> interpret the Status property then, if the snapshot was created or HE> not. The CIM_Job mof tells to use ErrorCode and HE> ErrorDescription. I think this is a good way to communicate a HE> snapshot failure. Okay, good point. Having the job status be "complete" for a failed job bugs me, but I'll set the error information. Thanks! -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms(a)us.ibm.com