Dan Smith wrote:
JG> Regardless, any time a file with no newline at the end has one JG> added, all nitpicking charges will be dropped. Removing the JG> ending newline will not be overlooked, however, because things JG> will be cleaner if all files always have newline at the end.
Thanks for the explanation. =)
Agreed. Actually, it is probably best if we try to notice when new patches don't have a newline to reduce the potential for this.
I don't know about less-sophisticated editors, but in emacs, you can add this to your .emacs to ensure all files have a final newline:
(setq require-final-newline t)
I thought the default was to either force or ask, but maybe some people don't have this set in their environment.
I'm using vim, and I'm not sure what the default action for this is. I'll look into it. -- Kaitlin Rupert IBM Linux Technology Center karupert@us.ibm.com