
KR> Patch looks good, but wouldn't you also want to do this check for KR> the sys_to_pool side of things as well? I'm not sure what you mean, this change *was* to sys_to_pool() :) KR> Or, basically, for any of the API calls that take a properties KR> argument? That brings up a good point, being that we might fail the test improperly if they specified (and we start honoring) the properties filter, so maybe we need to allow for passing a list of properties that are *excluded* from the list of properties checked. Since this is only comparing key properties, is it valid to use the property filter to exclude key properties? I could see the policy being either way really. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com