Re: [Libvirt-cim] [PATCH V3 01/11] remove script for bridge network

Yes, in lower version I think this xml section should also be removed. > > Are we saying that libvirt-cim 0.6.2 will use libvirt 0.9.10 and higher? > > Regards > Sharad Mishra > Open Virtualization > Linux Technology Center > IBM > > > > From: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com&gt; > To: veillard(a)redhat.com, > Cc: Sharad Mishra/Beaverton/IBM@IBMUS, libvirt-cim(a)redhat.com, > Wenchao Xia <xiawenc(a)linux.vnet.ibm.com&gt; > Date: 12/18/12 02:20 AM > Subject: [PATCH V3 01/11] remove script for bridge network > > > > libvirt0.9.10 will report error if bridge network was defined > with script. This is the fix for it, otherwise VM start would fail. > > v2: > rebased. > > Signed-off-by: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com&gt; > --- > libxkutil/xmlgen.c | 9 +-------- > 1 files changed, 1 insertions(+), 8 deletions(-) > > diff --git a/libxkutil/xmlgen.c b/libxkutil/xmlgen.c > index 2dcd0d2..31619d8 100644 > --- a/libxkutil/xmlgen.c > +++ b/libxkutil/xmlgen.c > @@ -269,18 +269,11 @@ static const char *set_net_source(xmlNodePtr nic, > return NULL; > } > > - > +/* libvirt 0.9.10 report error if script is set with brdige */ > static const char *bridge_net_to_xml(xmlNodePtr nic, struct net_device > *dev) > { > - const char *script = "vif-bridge"; > - xmlNodePtr tmp; > const char *msg = NULL; > > - tmp = xmlNewChild(nic, NULL, BAD_CAST "script", NULL); > - if (tmp == NULL) > - return XML_ERROR; > - xmlNewProp(tmp, BAD_CAST "path", BAD_CAST script); > - > msg = set_net_source(nic, dev, "bridge"); > > return msg; > -- > 1.7.1 > > -- Best Regards Wenchao Xia _______________________________________________ Libvirt-cim mailing list Libvirt-cim(a)redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim