JG> + cpuinfo = fopen("/proc/cpuinfo", "r");
This should come from virNodeInfo. Okay. Only question before I do that is do we have virNodeInfo in all
Dan Smith wrote: the versions of libvirt we support? The only reason I had to write this myself at all is that the libvirt function that determines the maximum number of vcpus came in too late for us.
Also, it would be good to go ahead and split out the "how many vcpus is the max for xen?" behavior into a separate function, because it's possible that other platforms will be able to overcommit vcpus. This might be a good place to start making it clear that the behavior is platform-dependent. I think it's okay to always take the Xen default for the time being, but while you're reworking this, you might as well split it out too.
So for now proc_max will basically just call xen_proc_max but in the future we might need to check the ref and add another function? If that's what you meant, that's fine. -- -Jay