Re: [Libvirt-cim] [PATCH] [TEST] Adding new tc to cover offline migration

Kaitlin Rupert wrote: >> + >> +@do_main(sup_types) >> +def main(): >> + options = main.options >> + virt = options.virt >> + s_sysname = gethostbyaddr(options.ip)[0] >> + t_sysname = gethostbyaddr(options.t_url)[0] + if options.virt >> == 'KVM' and (t_sysname == s_sysname or \ >> + t_sysname in s_sysname): >> + logger.info("Libvirt does not support local migratoin for KVM") >> + return SKIP > > This should be a function.. since you'll need to cal it in the live > migration case as well. > > Since this patch looks good otherwise, I've applied this as is. Can > you follow up with a patch to break this bit out into a function? > Yup I will do that. Also, I was not able to track the for which revision the actual changes to the KVM migration was included as the RSS feed was not working today. Can you lemme know the same.