17 Oct
2008
17 Oct
'08
9:15 p.m.
+ + rasds = get_default_rasds(ip, virt) + + for i in range(0, len(rasds)):
I think we had discussed this to be "for i in range(len(rasds))" :) For now we can leave this as it is.
Yes, sorry about that. You did mention it in your other review, but I forgot.
+ if rasds[i]['PoolID'].find('DiskPool') >= 0:
This can be "if 'DiskPool' in rasds[i]['PoolID']" as an alternative. But the above what you have also serves our purpose. +1 for me for the changes.
Your way is cleaner. I'll apply this set and then follow up with a patch to fix these items. Thanks! -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com