Re: [Libvirt-cim] [PATCH 3 of 3] EC: Validation of client given object path missing
Dan Smith wrote:
KR> Or possibly a better approach would be to modify
KR> connect_by_classname() so that it sets an error.
I'm pretty sure that connect_by_classname() used to set an error in
the CMPIStatus if it was going to return NULL.
Yes, it did. But for consistency
with CIM this was removed. The reason
is that a request against KVM on a Xen system can not return with an
error, as this breaks the CIM model and operations. This happens if the
client does e.g. an ein on CIM_ComputerSystem. We know that this one
request gets split up into requests against Xen_ComputerSystem and
KVM_ComputerSystem by the CIMOM. The CIMOM would then only return the
error code of the KVM request and revoke the instances returned by the
Xen request. This behavior would be wrong.
I probably broke that
when I fixed up (yes, ironic) the connect_by_classname() stuff a
little while ago.
Good catch!
--
Regards
Heidi Eckhart
Software Engineer
IBM Linux Technology Center - Open Hypervisor