On 09/05/2013 10:25 AM, Viktor Mihajlovski wrote:
cimtest currently doesn't work too well on s390 systems, the two main areas of failure are the attempt to define systems with IDE hard drivers and VGA graphics, both not supported on this host type.
Changing from IDE to virtio disks fixed a lot of the test FAILs with no adverse impacts to the x86 runs on our systems at least. It would be nice if somebody could verify this.
Further, we do not add the graphics RASD to the default guest definition if the hypervisor host is an s390 system. In principle, we could have removed the graphics RASD altogether, because libvirt-cim will define a default graphics device for x86 but since it is only a small change, it seems safer to do it this way.
Thilo Boehm (1): cimtest: Use vda instead of hda for disk RASDs
Viktor Mihajlovski (1): cimtest: Don't generate graphics for s390
.../cimtest/ElementAllocatedFromPool/01_forward.py | 2 +- .../cimtest/ElementAllocatedFromPool/02_reverse.py | 2 +- .../ElementAllocatedFromPool/03_reverse_errs.py | 2 +- .../ElementAllocatedFromPool/04_forward_errs.py | 2 +- .../cimtest/HostedAccessPoint/01_forward.py | 2 +- .../cimtest/HostedAccessPoint/02_reverse.py | 2 +- .../02_guest_add_mod_rem_rasd_ind.py | 2 +- .../cimtest/ServiceAccessBySAP/01_forward.py | 2 +- .../cimtest/ServiceAccessBySAP/02_reverse.py | 2 +- .../cimtest/SettingsDefine/01_forward.py | 2 +- .../cimtest/SettingsDefine/02_reverse.py | 2 +- .../cimtest/SettingsDefine/03_sds_fwd_errs.py | 2 +- .../cimtest/SettingsDefine/04_sds_rev_errs.py | 2 +- .../libvirt-cim/cimtest/SystemDevice/01_forward.py | 2 +- .../libvirt-cim/cimtest/SystemDevice/03_fwderrs.py | 2 +- suites/libvirt-cim/cimtest/VSSD/04_vssd_to_rasd.py | 2 +- .../13_refconfig_additional_devs.py | 2 +- .../14_define_sys_disk.py | 2 +- .../30_dynamic_disk_mod.py | 2 +- .../02_reverse.py | 2 +- .../03_vssdc_fwd_errs.py | 2 +- suites/libvirt-cim/lib/XenKvmLib/const.py | 2 +- suites/libvirt-cim/lib/XenKvmLib/vsms.py | 2 +- suites/libvirt-cim/lib/XenKvmLib/vxml.py | 5 +++-- suites/libvirt-cim/lib/XenKvmLib/xm_virt_util.py | 7 +++++++ 25 files changed, 33 insertions(+), 25 deletions(-)
This is now pushed. John