Re: [Libvirt-cim] [PATCH 1 of 3] VSSD: validate client given object path
Kaitlin Rupert wrote:
Heidi Eckhart wrote:
> + }
> + + if (!instance_from_dom(dom, inst)) {
Probably not worth a resend, but since instance_from_dom() returns an
int, this should be if (!instance_from_dom(dom, inst) != 1) {
sure ... I will
resend again :) ... sorry, was too fast with my resend
#2 and will create a #3 (oops)
> + + s = cu_validate_ref(broker, reference, *_inst);
If we encounter an error here, do we need to set a status message?
The correct status is set by cu_validate_ref() and directly returned to
the client. So this is not necessary here.
--
Regards
Heidi Eckhart
Software Engineer
IBM Linux Technology Center - Open Hypervisor