On 09/11/2013 10:45 AM, Viktor Mihajlovski wrote:
Motivation: the current libvirt-cim support for consoles is very limited in that it doesn't allow to specify the target and source types supported by libvirt. Having full support of the libvirt console feature is however mandatory for architectures like s390.
The current implementation using a Graphics_RASD to represent consoles cannot easily be extended without breaking the existing implementation (or without being entirely unusable).
Therefore a new RASD class is added to represent consoles in the model. Since there's no SVPC resource type for a console we use the combination of ResourceType = 1 (Other) and OtherResourceType = "console" for the new RASD instances.
In order to be backward compatible, the only console type supported by older libvirt-cim versions (target type 'pty') will still be returned as Graphics_RASD. In the long run, this should be deprecated.
V2 Changes: - Squashed old patches 2 and 5 and moved that one to position 4 - Fix double frees - Fix NULL pointer accesses - Improve error handling - Improve error messages - Some cosmetic changes
Thilo Boehm (5): schema: New SVPC types for chardev/consoles libxkutil: Console Support RASD: Schema and Provider Support for Console RASDs VSMS: Support for domains with console devices VSMS: add default console
Viktor Mihajlovski (2): VSMS: Set resource types for default devices Device: CIM_LogicalDevice for consoles
libxkutil/device_parsing.c | 314 ++++++++++++++++++- libxkutil/device_parsing.h | 43 ++- libxkutil/xmlgen.c | 191 ++++++++++- schema/ResourceAllocationSettingData.mof | 246 ++++++++++++++- schema/ResourceAllocationSettingData.registration | 5 +- src/Virt_Device.c | 33 ++ src/Virt_RASD.c | 149 ++++++++- src/Virt_VirtualSystemManagementService.c | 348 +++++++++++++++++++-- src/svpc_types.h | 102 +++++- 9 files changed, 1392 insertions(+), 39 deletions(-)
Series ACK and pushed with minor adjustment to 6/7 to check for NULL return on realloc() John