Re: [Libvirt-cim] [PATCH 1 of 2] Make domain_online() re-lookup domain to make sure we're getting fresh info

JG> I definitely could be wrong here, but I thought that JG> virDomainGetInfo got live info regardless of the age of the JG> virDomainPtr, as long as it still referenced the right domain. I JG> seem to remember running into that when I was writing the JG> ComputerSystemModifiedIndication code, and that was the reason I JG> had to get XML description and store it, instead of just pulling JG> from two different virDomainPtrs and comparing. Yeah, I thought so too, and it does, to some extent. However, I think the problem I was running into was when the domain goes from online to offline state, the DomInfo returned from the DomPtr isn't correct anymore. So what would happen was I would never see the SHUTDOWN state, it would just start returning NO_STATE after the domain went away. This solves that problem. Given that people expect the behavior from this function that you describe, I think making sure we do what we need to do for that is good :) -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms(a)us.ibm.com