Re: [Libvirt-cim] [PATCH] [TEST] Fixing 02_reverse.py of RAPF
Deepti B. Kalakeri wrote:
# HG changeset patch
# User Deepti B. Kalakeri <deeptik(a)linux.vnet.ibm.com>
# Date 1212413727 25200
# Node ID d478234fefe940f0ef738bbb83e6a3ab32736bec
# Parent 4a5a44d7b857df543af24d59380cb8fdbbb753a4
[TEST] Fixing 02_reverse.py of RAPF.
Added the following extra steps:
1) Defining a domain.
2) creating diskpool, netpool.
Without the steps 1 and 2 the tc used to simply pass.
The tc will fail on KVM with old libvirt-cim rpm as expected and will pass with the
latest source.
I failed to notice this during the last review, but this will fail on
Xen because the Xen XML is creating a guest with a ethernet interface.
An ethernet type interface won't be bound to any kind of network pool.
This doesn't happen with XenFV because the XenFV guest is created with a
bridge guest. Since DefineSystem() creates guests Xen/XenFV/KVM guests
with network interface types, the XML for Xen and XenFV should be
changed as well.
Also, when you send an updated patch, don't forget to put the revision
number in the first line of the commit log. Also, be sure to list the
changes between the previous revision and the new revision.
Thanks!
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com