- CIM - libvirt List Archives

[PATCH] [TEST] Fix RASDIndication 01 test to prevent possible test hang
by Kaitlin Rupert 19 Nov '09

19 Nov '09

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1258411652 28800 # Node ID 4747be9dd1dedd9acc45ebbff7793724f76ad604 # Parent 95cc631fc4581c9705ae93088688e1d3af28c55a [TEST] Fix RASDIndication 01 test to prevent possible test hang Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r 95cc631fc458 -r 4747be9dd1de suites/libvirt-cim/cimtest/RASDIndications/01_guest_states_rasd_ind.py --- a/suites/libvirt-cim/cimtest/RASDIndications/01_guest_states_rasd_ind.py Wed Nov 18 13:39:37 2009 -0800 +++ b/suites/libvirt-cim/cimtest/RASDIndications/01_guest_states_rasd_ind.py Mon Nov 16 14:47:32 2009 -0800 @@ -135,6 +135,9 @@ raise Exception("Unable to generate indication") status = poll_for_ind(pid, ind_name) + if status != PASS: + raise Exception("Poll for indication Failed") + except Exception, details: kill(pid, SIGKILL) raise Exception(details)

2 1

[PATCH] [TEST] Fixing VSMS/19*py tc for libvirt version >= 0.7.2
by Deepti B. Kalakeri 19 Nov '09

19 Nov '09

# HG changeset patch # User Deepti B. Kalakeri<deeptik(a)linux.vnet.ibm.com> # Date 1258631463 28800 # Node ID 6110e2d3e024b320313d582e4a1517cca3116068 # Parent c7907449b007aece4418f03272d8754b5fd41ac2 [TEST] Fixing VSMS/19*py tc for libvirt version >= 0.7.2 Tested with KVM and current sources on F12. Signed-off-by: Deepti B. Kalakeri <deeptik(a)linux.vnet.ibm.com> diff -r c7907449b007 -r 6110e2d3e024 suites/libvirt-cim/cimtest/VirtualSystemManagementService/19_definenetwork_ers.py --- a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/19_definenetwork_ers.py Mon Nov 09 13:24:52 2009 -0800 +++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/19_definenetwork_ers.py Thu Nov 19 03:51:03 2009 -0800 @@ -92,6 +92,8 @@ if libvirt_version >= "0.7.0": expected_values['empty']['network'] = inv_empty_network expected_values['invalid']['network'] = inv_empty_network + expected_values['invalid']['bridge'] = " Failed to add tap "\ + "interface to bridge" tc_scen = {

1 0

[PATCH] [TEST] Fix LXC guest created by testcase, so it's able to start
by Richard Maciel 19 Nov '09

19 Nov '09

# HG changeset patch # User Richard Maciel <richardm(a)br.ibm.com> # Date 1258572276 7200 # Node ID f834593694d2f3eefc3b0285ac62032ddc68edd0 # Parent 85410b3c6511eb880ff23f7dd18a7d83cbad26d3 [TEST] Fix LXC guest created by testcase, so it's able to start The source dir property of the guest created by the LXC cimtest was set to a inexistent path. That prevented the guest from starting. Signed-off-by: Richard Maciel <rmaciel(a)linux.vnet.ibm.com> diff -r 85410b3c6511 -r f834593694d2 suites/libvirt-cim/lib/XenKvmLib/const.py --- a/suites/libvirt-cim/lib/XenKvmLib/const.py Mon Nov 09 13:24:52 2009 -0800 +++ b/suites/libvirt-cim/lib/XenKvmLib/const.py Wed Nov 18 17:24:36 2009 -0200 @@ -106,7 +106,7 @@ LXC_init_path = os.path.join(_image_dir, 'cimtest_lxc_init') LXC_default_tty = '/dev/ptmx' LXC_default_mp = '/tmp' -LXC_default_source = '/tmp/lxc_files' +LXC_default_source = '/var/lib/libvirt/images/lxc_files' LXC_default_mac = '11:22:33:aa:bb:cc' LXC_netns_support = False

1 0

[PATCH] [TEST] #2 Fix CS 34 to SKIP if virt type is KVM and providers are old
by Kaitlin Rupert 19 Nov '09

19 Nov '09

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1257801892 28800 # Node ID 2f8394bb8f38f72069871e1ce07214f1abc6b2cc # Parent 55c3c3f3bc77c9946f61997de87547e99c21e38a [TEST] #2 Fix CS 34 to SKIP if virt type is KVM and providers are old... When they are older than revision 945. The cimtest image doesn't support reboot; older versions of libvirt-cim attempted to reboot guests on a disable call (instead of powering them down immediately). This fix does a virsh destroy on the guest (for older provider sets only). Updates: -Copy and paste error. Remove extraneous line. Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r 55c3c3f3bc77 -r 2f8394bb8f38 suites/libvirt-cim/cimtest/ComputerSystem/34_start_disable.py --- a/suites/libvirt-cim/cimtest/ComputerSystem/34_start_disable.py Tue Nov 03 10:37:35 2009 -0800 +++ b/suites/libvirt-cim/cimtest/ComputerSystem/34_start_disable.py Mon Nov 09 13:24:52 2009 -0800 @@ -37,7 +37,7 @@ from CimTest.Globals import logger from XenKvmLib.const import do_main, CIM_ENABLE, CIM_DISABLE, \ get_provider_version -from CimTest.ReturnCodes import PASS, FAIL +from CimTest.ReturnCodes import PASS, FAIL, SKIP from XenKvmLib.vxml import get_class sup_types = ['Xen', 'XenFV', 'KVM', 'LXC'] @@ -54,6 +54,15 @@ virt = options.virt try: + rev, changeset = get_provider_version(virt, server) + if rev >= disable_change_rev: + exp_state = CIM_DISABLE + else: + if options.virt == "KVM": + logger.info("cimtest's KVM guest imagedoesn't support reboot") + return SKIP + exp_state = CIM_ENABLE + cxml = get_class(virt)(default_dom) ret = cxml.cim_define(server) if not ret: @@ -67,12 +76,6 @@ if status != PASS: raise Exception("Unable disable dom '%s'" % default_dom) - rev, changeset = get_provider_version(virt, server) - if rev >= disable_change_rev: - exp_state = CIM_DISABLE - else: - exp_state = CIM_ENABLE - status = cxml.check_guest_state(server, exp_state) if status != PASS: raise Exception("%s not in expected state %d" % \

2 1

Test Run Summary (Nov 18 2009): KVM on Red Hat Enterprise Linux Server release 5.4 Beta (Tikanga) with Pegasus
by Sharad Mishra 18 Nov '09

18 Nov '09

================================================= Test Run Summary (Nov 18 2009): KVM on Red Hat Enterprise Linux Server release 5.4 Beta (Tikanga) with Pegasus ================================================= Distro: Red Hat Enterprise Linux Server release 5.4 Beta (Tikanga) Kernel: 2.6.18-158.el5 libvirt: 0.6.3 Hypervisor: QEMU 0.9.1 CIMOM: Pegasus 2.9.0 Libvirt-cim revision: 997 Libvirt-cim changeset: b9ee6fd16113 Cimtest revision: 794 Cimtest changeset: c7561bf61126 Total test execution: Unknown ================================================= FAIL : 2 XFAIL : 4 SKIP : 10 PASS : 159 ----------------- Total : 175 ================================================= FAIL Test Summary: ResourcePoolConfigurationService - 04_CreateChildResourcePool.py: FAIL ResourcePoolConfigurationService - 07_DeleteResourcePool.py: FAIL ================================================= XFAIL Test Summary: ComputerSystem - 32_start_reboot.py: XFAIL ComputerSystem - 33_suspend_reboot.py: XFAIL VirtualSystemManagementService - 16_removeresource.py: XFAIL VirtualSystemManagementService - 22_addmulti_brg_interface.py: XFAIL ================================================= SKIP Test Summary: ComputerSystem - 02_nosystems.py: SKIP ComputerSystemMigrationJobIndication - 01_csmig_ind_for_offline_mig.py: SKIP LogicalDisk - 02_nodevs.py: SKIP VSSD - 02_bootldr.py: SKIP VirtualSystemMigrationService - 01_migratable_host.py: SKIP VirtualSystemMigrationService - 02_host_migrate_type.py: SKIP VirtualSystemMigrationService - 05_migratable_host_errs.py: SKIP VirtualSystemMigrationService - 06_remote_live_migration.py: SKIP VirtualSystemMigrationService - 07_remote_offline_migration.py: SKIP VirtualSystemMigrationService - 08_remote_restart_resume_migration.py: SKIP ================================================= Full report: -------------------------------------------------------------------- AllocationCapabilities - 01_enum.py: PASS -------------------------------------------------------------------- AllocationCapabilities - 02_alloccap_gi_errs.py: PASS -------------------------------------------------------------------- ComputerSystem - 01_enum.py: PASS -------------------------------------------------------------------- ComputerSystem - 02_nosystems.py: SKIP ERROR - System has defined domains; unable to run -------------------------------------------------------------------- ComputerSystem - 03_defineVS.py: PASS -------------------------------------------------------------------- ComputerSystem - 04_defineStartVS.py: PASS -------------------------------------------------------------------- ComputerSystem - 05_activate_defined_start.py: PASS -------------------------------------------------------------------- ComputerSystem - 06_paused_active_suspend.py: PASS -------------------------------------------------------------------- ComputerSystem - 22_define_suspend.py: PASS -------------------------------------------------------------------- ComputerSystem - 23_pause_pause.py: PASS -------------------------------------------------------------------- ComputerSystem - 27_define_pause_errs.py: PASS -------------------------------------------------------------------- ComputerSystem - 32_start_reboot.py: XFAIL ERROR - Got CIM error CIM_ERR_FAILED: Unable to reboot domain: this function is not supported by the hypervisor: virDomainReboot with return code 1 ERROR - Exception: Unable reboot dom 'cs_test_domain' self.url, is http://localhost self.url, is http://localhost self.url, is http://localhost self.url, is http://localhost InvokeMethod(RequestStateChange): CIM_ERR_FAILED: Unable to reboot domain: this function is not supported by the hypervisor: virDomainReboot Bug:<00005> -------------------------------------------------------------------- ComputerSystem - 33_suspend_reboot.py: XFAIL ERROR - Got CIM error CIM_ERR_NOT_SUPPORTED: State not supported with return code 7 ERROR - Exception: Unable Suspend dom 'test_domain' self.url, is http://localhost self.url, is http://localhost self.url, is http://localhost self.url, is http://localhost InvokeMethod(RequestStateChange): CIM_ERR_NOT_SUPPORTED: State not supported Bug:<00012> -------------------------------------------------------------------- ComputerSystem - 34_start_disable.py: PASS -------------------------------------------------------------------- ComputerSystem - 35_start_reset.py: PASS -------------------------------------------------------------------- ComputerSystem - 40_RSC_start.py: PASS -------------------------------------------------------------------- ComputerSystem - 41_cs_to_settingdefinestate.py: PASS -------------------------------------------------------------------- ComputerSystem - 42_cs_gi_errs.py: PASS -------------------------------------------------------------------- ComputerSystemIndication - 01_created_indication.py: PASS -------------------------------------------------------------------- ComputerSystemMigrationJobIndication - 01_csmig_ind_for_offline_mig.py: SKIP -------------------------------------------------------------------- ElementAllocatedFromPool - 01_forward.py: PASS -------------------------------------------------------------------- ElementAllocatedFromPool - 02_reverse.py: PASS -------------------------------------------------------------------- ElementAllocatedFromPool - 03_reverse_errs.py: PASS -------------------------------------------------------------------- ElementAllocatedFromPool - 04_forward_errs.py: PASS -------------------------------------------------------------------- ElementCapabilities - 01_forward.py: PASS -------------------------------------------------------------------- ElementCapabilities - 02_reverse.py: PASS -------------------------------------------------------------------- ElementCapabilities - 03_forward_errs.py: PASS -------------------------------------------------------------------- ElementCapabilities - 04_reverse_errs.py: PASS -------------------------------------------------------------------- ElementCapabilities - 05_hostsystem_cap.py: PASS -------------------------------------------------------------------- ElementConforms - 01_forward.py: PASS -------------------------------------------------------------------- ElementConforms - 02_reverse.py: PASS -------------------------------------------------------------------- ElementConforms - 03_ectp_fwd_errs.py: PASS -------------------------------------------------------------------- ElementConforms - 04_ectp_rev_errs.py: PASS -------------------------------------------------------------------- ElementSettingData - 01_forward.py: PASS -------------------------------------------------------------------- ElementSettingData - 03_esd_assoc_with_rasd_errs.py: PASS -------------------------------------------------------------------- EnabledLogicalElementCapabilities - 01_enum.py: PASS -------------------------------------------------------------------- EnabledLogicalElementCapabilities - 02_elecap_gi_errs.py: PASS -------------------------------------------------------------------- HostSystem - 01_enum.py: PASS -------------------------------------------------------------------- HostSystem - 02_hostsystem_to_rasd.py: PASS -------------------------------------------------------------------- HostSystem - 03_hs_to_settdefcap.py: PASS -------------------------------------------------------------------- HostSystem - 04_hs_to_EAPF.py: PASS -------------------------------------------------------------------- HostSystem - 05_hs_gi_errs.py: PASS -------------------------------------------------------------------- HostSystem - 06_hs_to_vsms.py: PASS -------------------------------------------------------------------- HostedAccessPoint - 01_forward.py: PASS -------------------------------------------------------------------- HostedAccessPoint - 02_reverse.py: PASS -------------------------------------------------------------------- HostedDependency - 01_forward.py: PASS -------------------------------------------------------------------- HostedDependency - 02_reverse.py: PASS -------------------------------------------------------------------- HostedDependency - 03_enabledstate.py: PASS -------------------------------------------------------------------- HostedDependency - 04_reverse_errs.py: PASS -------------------------------------------------------------------- HostedResourcePool - 01_forward.py: PASS -------------------------------------------------------------------- HostedResourcePool - 02_reverse.py: PASS -------------------------------------------------------------------- HostedResourcePool - 03_forward_errs.py: PASS -------------------------------------------------------------------- HostedResourcePool - 04_reverse_errs.py: PASS -------------------------------------------------------------------- HostedService - 01_forward.py: PASS -------------------------------------------------------------------- HostedService - 02_reverse.py: PASS -------------------------------------------------------------------- HostedService - 03_forward_errs.py: PASS -------------------------------------------------------------------- HostedService - 04_reverse_errs.py: PASS -------------------------------------------------------------------- KVMRedirectionSAP - 01_enum_KVMredSAP.py: PASS -------------------------------------------------------------------- LogicalDisk - 01_disk.py: PASS -------------------------------------------------------------------- LogicalDisk - 02_nodevs.py: SKIP ERROR - System has defined domains; unable to run self.url, is http://localhost self.url, is http://localhost -------------------------------------------------------------------- LogicalDisk - 03_ld_gi_errs.py: PASS -------------------------------------------------------------------- Memory - 01_memory.py: PASS -------------------------------------------------------------------- Memory - 02_defgetmem.py: PASS -------------------------------------------------------------------- Memory - 03_mem_gi_errs.py: PASS -------------------------------------------------------------------- NetworkPort - 01_netport.py: PASS -------------------------------------------------------------------- NetworkPort - 02_np_gi_errors.py: PASS -------------------------------------------------------------------- NetworkPort - 03_user_netport.py: PASS -------------------------------------------------------------------- Processor - 01_processor.py: PASS -------------------------------------------------------------------- Processor - 02_definesys_get_procs.py: PASS -------------------------------------------------------------------- Processor - 03_proc_gi_errs.py: PASS -------------------------------------------------------------------- Profile - 01_enum.py: PASS -------------------------------------------------------------------- Profile - 02_profile_to_elec.py: PASS -------------------------------------------------------------------- Profile - 03_rprofile_gi_errs.py: PASS -------------------------------------------------------------------- RASD - 01_verify_rasd_fields.py: PASS -------------------------------------------------------------------- RASD - 02_enum.py: PASS -------------------------------------------------------------------- RASD - 03_rasd_errs.py: PASS -------------------------------------------------------------------- RASD - 04_disk_rasd_size.py: PASS -------------------------------------------------------------------- RASD - 05_disk_rasd_emu_type.py: PASS -------------------------------------------------------------------- RASD - 06_parent_net_pool.py: PASS -------------------------------------------------------------------- RASD - 07_parent_disk_pool.py: PASS -------------------------------------------------------------------- RASDIndications - 01_guest_states_rasd_ind.py: PASS -------------------------------------------------------------------- RASDIndications - 02_guest_add_mod_rem_rasd_ind.py: PASS -------------------------------------------------------------------- RedirectionService - 01_enum_crs.py: PASS -------------------------------------------------------------------- RedirectionService - 02_enum_crscap.py: PASS -------------------------------------------------------------------- RedirectionService - 03_RedirectionSAP_errs.py: PASS -------------------------------------------------------------------- ReferencedProfile - 01_verify_refprof.py: PASS -------------------------------------------------------------------- ReferencedProfile - 02_refprofile_errs.py: PASS -------------------------------------------------------------------- ResourceAllocationFromPool - 01_forward.py: PASS -------------------------------------------------------------------- ResourceAllocationFromPool - 02_reverse.py: PASS -------------------------------------------------------------------- ResourceAllocationFromPool - 03_forward_errs.py: PASS -------------------------------------------------------------------- ResourceAllocationFromPool - 04_reverse_errs.py: PASS -------------------------------------------------------------------- ResourceAllocationFromPool - 05_RAPF_err.py: PASS -------------------------------------------------------------------- ResourcePool - 01_enum.py: PASS -------------------------------------------------------------------- ResourcePool - 02_rp_gi_errors.py: PASS -------------------------------------------------------------------- ResourcePoolConfigurationCapabilities - 01_enum.py: PASS -------------------------------------------------------------------- ResourcePoolConfigurationCapabilities - 02_rpcc_gi_errs.py: PASS -------------------------------------------------------------------- ResourcePoolConfigurationService - 01_enum.py: PASS -------------------------------------------------------------------- ResourcePoolConfigurationService - 02_rcps_gi_errors.py: PASS -------------------------------------------------------------------- ResourcePoolConfigurationService - 03_CreateResourcePool.py: PASS -------------------------------------------------------------------- ResourcePoolConfigurationService - 04_CreateChildResourcePool.py: FAIL ERROR - Exception in create_pool() ERROR - Exception details: (1, u'CIM_ERR_FAILED: Pool with that name already exists') ERROR - Error in networkpool creation self.url, is http://localhost self.url, is http://localhost self.url, is http://localhost self.url, is http://localhost InvokeMethod(CreateChildResourcePool): CIM_ERR_FAILED: Pool with that name already exists -------------------------------------------------------------------- ResourcePoolConfigurationService - 05_AddResourcesToResourcePool.py: PASS -------------------------------------------------------------------- ResourcePoolConfigurationService - 06_RemoveResourcesFromResourcePool.py: PASS -------------------------------------------------------------------- ResourcePoolConfigurationService - 07_DeleteResourcePool.py: FAIL ERROR - Exception in create_pool() ERROR - Exception details: (1, u'CIM_ERR_FAILED: Pool with that name already exists') ERROR - Error in networkpool creation self.url, is http://localhost self.url, is http://localhost self.url, is http://localhost self.url, is http://localhost self.url, is http://localhost InvokeMethod(CreateChildResourcePool): CIM_ERR_FAILED: Pool with that name already exists -------------------------------------------------------------------- ResourcePoolConfigurationService - 08_CreateDiskResourcePool.py: PASS -------------------------------------------------------------------- ResourcePoolConfigurationService - 09_DeleteDiskPool.py: PASS -------------------------------------------------------------------- ResourcePoolConfigurationService - 10_create_storagevolume.py: PASS -------------------------------------------------------------------- ResourcePoolConfigurationService - 11_create_dir_storagevolume_errs.py: PASS -------------------------------------------------------------------- ResourcePoolConfigurationService - 12_create_netfs_storagevolume_errs.py: PASS -------------------------------------------------------------------- ResourcePoolConfigurationService - 13_delete_storagevolume.py: PASS -------------------------------------------------------------------- ResourcePoolConfigurationService - 14_delete_storagevolume_errs.py: PASS -------------------------------------------------------------------- ServiceAccessBySAP - 01_forward.py: PASS -------------------------------------------------------------------- ServiceAccessBySAP - 02_reverse.py: PASS -------------------------------------------------------------------- ServiceAffectsElement - 01_forward.py: PASS -------------------------------------------------------------------- ServiceAffectsElement - 02_reverse.py: PASS -------------------------------------------------------------------- SettingsDefine - 01_forward.py: PASS -------------------------------------------------------------------- SettingsDefine - 02_reverse.py: PASS -------------------------------------------------------------------- SettingsDefine - 03_sds_fwd_errs.py: PASS -------------------------------------------------------------------- SettingsDefine - 04_sds_rev_errs.py: PASS -------------------------------------------------------------------- SettingsDefineCapabilities - 01_forward.py: PASS -------------------------------------------------------------------- SettingsDefineCapabilities - 03_forward_errs.py: PASS -------------------------------------------------------------------- SettingsDefineCapabilities - 04_forward_vsmsdata.py: PASS -------------------------------------------------------------------- SettingsDefineCapabilities - 05_reverse_vsmcap.py: PASS -------------------------------------------------------------------- SystemDevice - 01_forward.py: PASS -------------------------------------------------------------------- SystemDevice - 02_reverse.py: PASS -------------------------------------------------------------------- SystemDevice - 03_fwderrs.py: PASS -------------------------------------------------------------------- VSSD - 01_enum.py: PASS -------------------------------------------------------------------- VSSD - 02_bootldr.py: SKIP -------------------------------------------------------------------- VSSD - 03_vssd_gi_errs.py: PASS -------------------------------------------------------------------- VSSD - 04_vssd_to_rasd.py: PASS -------------------------------------------------------------------- VSSD - 05_set_uuid.py: PASS -------------------------------------------------------------------- VSSD - 06_duplicate_uuid.py: PASS -------------------------------------------------------------------- VirtualSystemManagementCapabilities - 01_enum.py: PASS -------------------------------------------------------------------- VirtualSystemManagementCapabilities - 02_vsmcap_gi_errs.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 01_definesystem_name.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 02_destroysystem.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 03_definesystem_ess.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 04_definesystem_ers.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 05_destroysystem_neg.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 06_addresource.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 07_addresource_neg.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 08_modifyresource.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 09_procrasd_persist.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 10_hv_version.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 11_define_memrasdunits.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 12_referenced_config.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 13_refconfig_additional_devs.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 14_define_sys_disk.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 15_mod_system_settings.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 16_removeresource.py: XFAIL ERROR - 0 RASD insts for domain/mouse:ps2 self.url, is http://localhost self.url, is http://localhost self.url, is http://localhost self.url, is http://localhost self.url, is http://localhost self.url, is http://localhost CIM_ERR_NOT_FOUND: No such instance (no device domain/mouse:ps2) Bug:<00014> -------------------------------------------------------------------- VirtualSystemManagementService - 17_removeresource_neg.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 18_define_sys_bridge.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 19_definenetwork_ers.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 20_verify_vnc_password.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 21_createVS_verifyMAC.py: PASS -------------------------------------------------------------------- VirtualSystemManagementService - 22_addmulti_brg_interface.py: XFAIL ERROR - Error invoking AddRS: add_net_res ERROR - (1, u"CIM_ERR_FAILED: Unable to change (0) device: this function is not supported by the hypervisor: device type 'interface' cannot be attached") ERROR - Failed to destroy Virtual Network 'my_network1' self.url, is http://localhost self.url, is http://localhost self.url, is http://localhost self.url, is http://localhost InvokeMethod(AddResourceSettings): CIM_ERR_FAILED: Unable to change (0) device: this function is not supported by the hypervisor: device type 'interface' cannot be attached Bug:<00015> -------------------------------------------------------------------- VirtualSystemManagementService - 23_verify_duplicate_mac_err.py: PASS -------------------------------------------------------------------- VirtualSystemMigrationCapabilities - 01_enum.py: PASS -------------------------------------------------------------------- VirtualSystemMigrationCapabilities - 02_vsmc_gi_errs.py: PASS -------------------------------------------------------------------- VirtualSystemMigrationService - 01_migratable_host.py: SKIP -------------------------------------------------------------------- VirtualSystemMigrationService - 02_host_migrate_type.py: SKIP -------------------------------------------------------------------- VirtualSystemMigrationService - 05_migratable_host_errs.py: SKIP -------------------------------------------------------------------- VirtualSystemMigrationService - 06_remote_live_migration.py: SKIP -------------------------------------------------------------------- VirtualSystemMigrationService - 07_remote_offline_migration.py: SKIP -------------------------------------------------------------------- VirtualSystemMigrationService - 08_remote_restart_resume_migration.py: SKIP -------------------------------------------------------------------- VirtualSystemMigrationSettingData - 01_enum.py: PASS -------------------------------------------------------------------- VirtualSystemMigrationSettingData - 02_vsmsd_gi_errs.py: PASS -------------------------------------------------------------------- VirtualSystemSettingDataComponent - 01_forward.py: PASS -------------------------------------------------------------------- VirtualSystemSettingDataComponent - 02_reverse.py: PASS -------------------------------------------------------------------- VirtualSystemSettingDataComponent - 03_vssdc_fwd_errs.py: PASS -------------------------------------------------------------------- VirtualSystemSettingDataComponent - 04_vssdc_rev_errs.py: PASS -------------------------------------------------------------------- VirtualSystemSnapshotService - 01_enum.py: PASS -------------------------------------------------------------------- VirtualSystemSnapshotService - 02_vs_sservice_gi_errs.py: PASS -------------------------------------------------------------------- VirtualSystemSnapshotService - 03_create_snapshot.py: PASS -------------------------------------------------------------------- VirtualSystemSnapshotServiceCapabilities - 01_enum.py: PASS -------------------------------------------------------------------- VirtualSystemSnapshotServiceCapabilities - 02_vs_sservicecap_gi_errs.py: PASS --------------------------------------------------------------------

1 0

[PATCH] [TEST] Fix VSMS 15 to work with KVM guests and old providers
by Kaitlin Rupert 18 Nov '09

18 Nov '09

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1257801892 28800 # Node ID 9b3156cd8d1a72573531f23cd3e0907d71685c34 # Parent 72072bf8e9b0511d69dc308f2174dea3cb797a6c [TEST] Fix VSMS 15 to work with KVM guests and old providers The cimtest image doesn't support reboot; older versions of libvirt-cim attempted to reboot guests on a disable call (instead of powering them down immediately). This fix does a virsh destroy on the guest (for older provider sets only). Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r 72072bf8e9b0 -r 9b3156cd8d1a suites/libvirt-cim/cimtest/VirtualSystemManagementService/15_mod_system_settings.py --- a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/15_mod_system_settings.py Mon Nov 09 13:24:52 2009 -0800 +++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/15_mod_system_settings.py Mon Nov 09 13:24:52 2009 -0800 @@ -31,7 +31,8 @@ from XenKvmLib.enumclass import GetInstance from XenKvmLib.common_util import poll_for_state_change from XenKvmLib.const import get_provider_version -from XenKvmLib.xm_virt_util import domain_list, active_domain_list +from XenKvmLib.xm_virt_util import domain_list, active_domain_list, \ + destroy_domain sup_types = ['Xen', 'KVM', 'XenFV', 'LXC'] default_dom = 'rstest_domain' @@ -42,6 +43,7 @@ f9_bug = "00010" libvirt_f9_revision=613 libvirt_modify_setting_changes = 694 +disable_change_rev = 945 def get_vssd(ip, virt, get_cim_inst): cn = get_typed_class(virt, "VirtualSystemSettingData") @@ -63,6 +65,26 @@ return PASS, inst +def power_down_guest(ip, virt, dom): + rev, changeset = get_provider_version(virt, ip) + + if rev < disable_change_rev and virt == "KVM": + rc = destroy_domain(ip, dom, virt) + if rc != 0: + return FAIL + else: + status = cxml.cim_disable(ip) + if status != PASS: + logger.error("Failed to disable %s", dom) + return FAIL + + status, cs = poll_for_state_change(ip, virt, dom, CIM_DISABLE) + if status != PASS: + logger.error("Failed to destroy %s", dom) + return FAIL + + return PASS + @do_main(sup_types) def main(): options = main.options @@ -103,14 +125,9 @@ raise Exception("Failed to modify dom: %s" % default_dom) if case == "start": - status = cxml.cim_disable(options.ip) + status = power_down_guest(options.ip, options.virt, default_dom) if status != PASS: - raise Exception("Failed to disable %s" % default_dom) - - status, cs = poll_for_state_change(options.ip, options.virt, - default_dom, CIM_DISABLE) - if status != PASS: - raise Exception("Failed to destroy %s" % default_dom) + raise Exception("Unable to disable %s" % default_dom) status, inst = get_vssd(options.ip, options.virt, False) if status != PASS: diff -r 72072bf8e9b0 -r 9b3156cd8d1a suites/libvirt-cim/lib/XenKvmLib/xm_virt_util.py --- a/suites/libvirt-cim/lib/XenKvmLib/xm_virt_util.py Mon Nov 09 13:24:52 2009 -0800 +++ b/suites/libvirt-cim/lib/XenKvmLib/xm_virt_util.py Mon Nov 09 13:24:52 2009 -0800 @@ -92,6 +92,17 @@ return int(mfm) +def destroy_domain(server, dom, virt="Xen"): + """Function to destroy given domain""" + if virt == "XenFV": + virt = "Xen" + + cmd = "virsh -c %s destroy %s" % (virt2uri(virt), dom) + ret, out = utils.run_remote(server, cmd) + print cmd, ret, out + + return ret + def domain_list(server, virt="Xen"): """Function to list all domains""" if virt == "XenFV":

2 1

[PATCH] [TEST] Fix VSMS 23 to SKIP for old provider sets
by Kaitlin Rupert 18 Nov '09

18 Nov '09

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1257802470 28800 # Node ID 2489a1776bb628edb70b4586eb6548a4e47a022b # Parent 9b3156cd8d1a72573531f23cd3e0907d71685c34 [TEST] Fix VSMS 23 to SKIP for old provider sets The duplicate MAC change was added in revision 929 - this test should skip if the provider set is older than this. Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r 9b3156cd8d1a -r 2489a1776bb6 suites/libvirt-cim/cimtest/VirtualSystemManagementService/23_verify_duplicate_mac_err.py --- a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/23_verify_duplicate_mac_err.py Mon Nov 09 13:24:52 2009 -0800 +++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/23_verify_duplicate_mac_err.py Mon Nov 09 13:34:30 2009 -0800 @@ -29,11 +29,12 @@ from XenKvmLib.vsms import get_vsms_class, get_nasd_class from XenKvmLib.vxml import get_class from CimTest.Globals import logger -from CimTest.ReturnCodes import FAIL, PASS +from CimTest.ReturnCodes import FAIL, PASS, SKIP from XenKvmLib.const import default_network_name, do_main from XenKvmLib.common_util import create_netpool_conf, destroy_netpool from XenKvmLib.classes import get_typed_class from XenKvmLib.enumclass import GetInstance, EnumNames +from XenKvmLib.const import get_provider_version sup_types = ['Xen', 'KVM', 'XenFV'] default_dom = 'net_domain1' @@ -44,6 +45,7 @@ exp_rc = CIM_ERR_FAILED exp_desc = "Conflicting MAC Addresses" +dup_mac_rev = 929 def cleanup_env(ip, virt, npool_name, cxml): cxml.cim_destroy(ip) @@ -72,6 +74,11 @@ def main(): options = main.options + rev, changeset = get_provider_version(options.virt, options.ip) + if rev < dup_mac_rev: + logger.error("Test only valid with provider version > %d", dup_mac_rev) + return SKIP + status, net_name = create_netpool_conf(options.ip, options.virt, use_existing=False, net_name=npool_name)

2 1

[PATCH] Use strdup() to copy memory so list of strings can be free in Virt_DevicePool
by Kaitlin Rupert 18 Nov '09

18 Nov '09

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1257998067 28800 # Node ID 33a6a50f64e08df1585a249d96d89e4e03d663e4 # Parent a804ea345a48f2dd57a7e78b8fbd595f9397906b Use strdup() to copy memory so list of strings can be free in Virt_DevicePool This were missed in revision 1008. In Virt_RASD, declare base a const char, as we aren't allocating memory here. Revert changes from revision 1008 - this is a regression. Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r a804ea345a48 -r 33a6a50f64e0 src/Virt_DevicePool.c --- a/src/Virt_DevicePool.c Fri Nov 06 14:03:41 2009 -0800 +++ b/src/Virt_DevicePool.c Wed Nov 11 19:54:27 2009 -0800 @@ -130,11 +130,13 @@ names = calloc(count, sizeof(char *)); if (names == NULL) { CU_DEBUG("Failed to alloc space for %i pool names", count); + count = 0; goto out; } if (virConnectListStoragePools(conn, names, count) == -1) { CU_DEBUG("Failed to get storage pools"); + count = 0; goto out; } @@ -145,7 +147,7 @@ } for (i = 0; i < count; i++) { - pools[i].tag = names[i]; + pools[i].tag = strdup(names[i]); pools[i].primordial = false; } @@ -936,7 +938,7 @@ goto out; } - netnames[nets - 1] = "0"; + netnames[nets - 1] = strdup("0"); for (i = 0; i < nets; i++) { _netpool_for_network(list, diff -r a804ea345a48 -r 33a6a50f64e0 src/Virt_RASD.c --- a/src/Virt_RASD.c Fri Nov 06 14:03:41 2009 -0800 +++ b/src/Virt_RASD.c Wed Nov 11 19:54:27 2009 -0800 @@ -377,7 +377,7 @@ CMPIStatus s; CMPIInstance *inst; uint16_t type; - char *base; + const char *base; char *id; const char *keys[] = {"InstanceID", NULL}; @@ -407,8 +407,6 @@ CLASSNAME(ref), base, NAMESPACE(ref)); - free(base); - if (inst == NULL) return inst;

3 2

[PATCH] Fix memory leaks in RASD, RAFP, and DevicePool
by Kaitlin Rupert 12 Nov '09

12 Nov '09

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1257545021 28800 # Node ID 280a12d7c513129ebf86ac271aac5474161d3aae # Parent 910c18bbb6264c90294375e94882e600f3dd8237 Fix memory leaks in RASD, RAFP, and DevicePool Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r 910c18bbb626 -r 280a12d7c513 src/Virt_DevicePool.c --- a/src/Virt_DevicePool.c Thu Nov 05 14:20:54 2009 -0800 +++ b/src/Virt_DevicePool.c Fri Nov 06 14:03:41 2009 -0800 @@ -102,11 +102,14 @@ return 0; *pool = malloc(sizeof(**pool)); - if (*pool == NULL) - return 0; + if (*pool == NULL) { + ret = 0; + goto out; + } ret = get_pool_from_xml(xml, *pool, CIM_RES_TYPE_DISK); + out: free(xml); return ret; @@ -130,30 +133,31 @@ goto out; } + if (virConnectListStoragePools(conn, names, count) == -1) { + CU_DEBUG("Failed to get storage pools"); + goto out; + } + pools = calloc(count, sizeof(*pools)); if (pools == NULL) { CU_DEBUG("Failed to alloc space for %i pool structs", count); goto out; } - if (virConnectListStoragePools(conn, names, count) == -1) { - CU_DEBUG("Failed to get storage pools"); - free(pools); - goto out; - } - for (i = 0; i < count; i++) { pools[i].tag = names[i]; pools[i].primordial = false; } out: + for (i = 0; i < count; i++) + free(names[i]); + free(names); + get_disk_parent(&pools, &count); *_pools = pools; - free(names); - return count; } @@ -464,6 +468,8 @@ free(_bridge); } + for (i = 0; i < num; i++) + free(networks[i]); free(networks); return network; @@ -870,12 +876,12 @@ } set_params(inst, CIM_RES_TYPE_NET, id, NULL, cap, false); - free(id); free(cap); - free(bridge); inst_list_add(list, inst); out: + free(bridge); + free(id); virNetworkFree(network); return s; @@ -890,7 +896,7 @@ CMPIStatus s = {CMPI_RC_OK, NULL}; char **netnames = NULL; int i; - int nets; + int nets = 0; if (id != NULL) { return _netpool_for_network(list, @@ -942,6 +948,8 @@ } out: + for (i = 0; i < nets; i++) + free(netnames[i]); free(netnames); return s; @@ -1350,8 +1358,6 @@ break; } - inst_list_free(&list); - if (inst == NULL) { cu_statusf(broker, s, CMPI_RC_ERR_FAILED, @@ -1362,6 +1368,7 @@ } out: + inst_list_free(&list); return inst; } diff -r 910c18bbb626 -r 280a12d7c513 src/Virt_RASD.c --- a/src/Virt_RASD.c Thu Nov 05 14:20:54 2009 -0800 +++ b/src/Virt_RASD.c Fri Nov 06 14:03:41 2009 -0800 @@ -407,6 +407,8 @@ CLASSNAME(ref), base, NAMESPACE(ref)); + free(base); + if (inst == NULL) return inst; @@ -523,6 +525,8 @@ else *_inst = inst; + cleanup_virt_device(dev); + out: virConnectClose(conn); free(host); @@ -696,6 +700,10 @@ cu_statusf(broker, &s, CMPI_RC_ERR_FAILED, "Failed to get domain name"); + + for (i = 0; i < count; i++) + cleanup_virt_device(&devs[i]); + goto out; } diff -r 910c18bbb626 -r 280a12d7c513 src/Virt_ResourceAllocationFromPool.c --- a/src/Virt_ResourceAllocationFromPool.c Thu Nov 05 14:20:54 2009 -0800 +++ b/src/Virt_ResourceAllocationFromPool.c Fri Nov 06 14:03:41 2009 -0800 @@ -120,6 +120,8 @@ inst_list_add(dest, inst); } + free(poolid); + return dest->cur; }

2 1

[PATCH] Add GraphicsPool mof to Makefile.am so it gets registered with CIMOM
by Kaitlin Rupert 12 Nov '09

12 Nov '09

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1257547293 28800 # Node ID 289823a45e86aac53df978c6e27716e8f31c3418 # Parent 9bda715b0f068911c69a5632e147c68666fcb7d0 Add GraphicsPool mof to Makefile.am so it gets registered with CIMOM Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r 9bda715b0f06 -r 289823a45e86 Makefile.am --- a/Makefile.am Fri Nov 06 11:44:00 2009 -0800 +++ b/Makefile.am Fri Nov 06 14:41:33 2009 -0800 @@ -52,6 +52,7 @@ schema/KVMRedirectionSAP.mof \ schema/DisplayController.mof \ schema/PointingDevice.mof \ + schema/GraphicsPool.mof \ schema/InputPool.mof \ schema/HostedAccessPoint.mof \ schema/ServiceAccessBySAP.mof \

2 1