- CIM - libvirt List Archives

[PATCH 0/3] Add Controller Device Support
by Xu Wang 13 Mar '14

13 Mar '14

Add Xen/KVM/LXC_ControllerResourceAllocationSettingData classes for controller device operation. So far there are two variables (type and model) could be operated by calling API. Xu Wang (3): libxutil: Controller Support RASD: Schema and Provider Support for Controller RASDs VSMS: Support for domains with controller devices libxkutil/device_parsing.c | 62 ++++++++++++++++++++- libxkutil/device_parsing.h | 9 +++ libxkutil/xmlgen.c | 28 +++++++++ schema/ResourceAllocationSettingData.mof | 27 +++++++++ schema/ResourceAllocationSettingData.registration | 3 + src/Virt_RASD.c | 24 ++++++++ src/Virt_VirtualSystemManagementService.c | 44 +++++++++++++++ src/svpc_types.h | 4 +- 8 files changed, 199 insertions(+), 2 deletions(-)

3 21

[PATCH] Use of root/interop instead of root/PG_InterOp
by John Ferlan 27 Feb '14

27 Feb '14

As of tog-pegasus 2.12.1-5 we can no longer use "root/PG_InterOp" namespace for the CIM provider instead the use of "root/interop" is the preferred mechanism. This patch will adjust where libvirt-cim installs its classes to use the "root/interop" namespace. For more context, see: http://www.redhat.com/archives/libvirt-cim/2013-November/msg00083.html and http://www.redhat.com/archives/libvirt-cim/2013-November/msg00008.html This patch will be required for RHEL7 which fails to install with the base 0.6.3 release. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Makefile.am | 29 ++++++++++++++++++++++++----- libvirt-cim.spec.in | 27 ++++++++++++++++++++++----- provider-register.sh | 18 +++++++++++++++++- 3 files changed, 63 insertions(+), 11 deletions(-) diff --git a/Makefile.am b/Makefile.am index 9e8e96b..69b65cf 100644 --- a/Makefile.am +++ b/Makefile.am @@ -78,6 +78,9 @@ INTEROP_MOFS = \ $(top_srcdir)/schema/ReferencedProfile.mof \ $(top_srcdir)/schema/AllocationCapabilities.mof +# The PGINTEROP_MOFS are used by tog-pegasus up through version 2.12.1 +# If support for versions prior to 2.12.1 is removed, then these defs +# can go away PGINTEROP_MOFS = \ $(top_srcdir)/schema/RegisteredProfile.mof \ $(top_srcdir)/schema/ElementConformsToProfile.mof \ @@ -157,6 +160,9 @@ INTEROP_REGS = \ $(top_srcdir)/schema/ElementConformsToProfile.registration \ $(top_srcdir)/schema/ReferencedProfile.registration +# The PGINTEROP_REGS are used by tog-pegasus up through version 2.12.1 +# If support for versions prior to 2.12.1 is removed, then these defs +# can go away PGINTEROP_REGS = \ $(top_srcdir)/schema/RegisteredProfile.registration \ $(top_srcdir)/schema/ElementConformsToProfile.registration \ @@ -181,7 +187,8 @@ EXTRA_DIST = schema $(MOFS) $(REGS) $(INTEROP_MOFS) $(INTEROP_REGS) \ .changeset .revision \ examples/diskpool.conf -# If Pegasus isn't the CIMOM target, then remove the PG_InterOp namespace from the appropriate files +# If Pegasus isn't the CIMOM target, then remove the PG_InterOp namespace +# from the appropriate files install-data-local: $(mkinstalldirs) "$(DESTDIR)$(pkgdatadir)" $(install_sh_DATA) -t "$(DESTDIR)$(pkgdatadir)" $(MOFS) @@ -189,11 +196,12 @@ install-data-local: $(install_sh_DATA) -t "$(DESTDIR)$(pkgdatadir)" $(INTEROP_MOFS) $(install_sh_DATA) -t "$(DESTDIR)$(pkgdatadir)" $(INTEROP_REGS) if [[ @CIMSERVER@ != pegasus ]]; then \ - sed -i '/^# --/,/^# --!/d' $(subst $(top_srcdir)/schema,$(DESTDIR)$(pkgdatadir), $(PGINTEROP_REGS)); \ + sed -i '/^# --/,/^# --!/d' $(subst $(top_srcdir)/schema,$(DESTDIR)$(pkgdatadir), $(PGINTEROP_REGS)); \ + sed -i '/^# --/,/^# --!/d' $(subst $(top_srcdir)/schema,$(DESTDIR)$(pkgdatadir), $(PGINTEROP_MOFS)); \ fi uninstall-local: - @list='$(MOFS) $(REGS) $(INTEROP_MOFS) $(INTEROP_REGS)'; \ + @list='$(MOFS) $(REGS) $(INTEROP_MOFS) $(INTEROP_REGS) $(PGINTEROP_REGS) $(PGINTEROP_MOFS)'; \ for p in $$list; do \ f=`echo "$$p" | sed 's|^.*/||;'`; \ echo " rm -f '$(DESTDIR)$(pkgdatadir)/$$f'"; \ @@ -209,8 +217,19 @@ postinstall: $(SHELL) provider-register.sh -v -t @CIMSERVER@ -n @CIM_VIRT_NS@ -r $(subst $(top_srcdir)/schema,$(pkgdatadir), $(REGS)) -m $(subst $(top_srcdir)/schema,$(pkgdatadir), $(MOFS)) $(SHELL) provider-register.sh -v -t @CIMSERVER@ -n root/interop -r $(subst $(top_srcdir)/schema,$(pkgdatadir), $(INTEROP_REGS)) -m $(subst $(top_srcdir)/schema,$(pkgdatadir), $(INTEROP_MOFS)) $(SHELL) provider-register.sh -v -t @CIMSERVER@ -n root/cimv2 -r $(subst $(top_srcdir)/schema,$(pkgdatadir), $(CIMV2_REGS)) -m $(subst $(top_srcdir)/schema,$(pkgdatadir), $(CIMV2_MOFS)) + # + # We need to check the version - if we're not yet at 2.12.1, then + # we'll register at root/PG_InterOp; otherwise, using just the above + # registration should be sufficient. The actual cutoff root/PG_InterOp + # not being valid was 2.12.1-5; however, --version doesn't give us that + # level of detail. The Pegasus docs imply that usage of root/interop was + # valid as of 2.12.0. + # if [[ @CIMSERVER@ = pegasus ]]; then \ - $(SHELL) provider-register.sh -v -t @CIMSERVER@ -n root/PG_InterOp -r $(subst $(top_srcdir)/schema,$(pkgdatadir), $(PGINTEROP_REGS)) -m $(subst $(top_srcdir)/schema,$(pkgdatadir), $(PGINTEROP_MOFS)); \ + CIMVER=`@CIMSERVER@ --version | awk -F. '{printf("%02d%02d%02d\n", $1,$2,$3); }'` \ + if [[ $CIMVER -lt 021201 ]]; then \ + $(SHELL) provider-register.sh -v -t @CIMSERVER@ -n root/PG_InterOp -r $(subst $(top_srcdir)/schema,$(pkgdatadir), $(PGINTEROP_REGS)) -m $(subst $(top_srcdir)/schema,$(pkgdatadir), $(PGINTEROP_MOFS)); \ + fi \ fi virsh -v | grep -q '^0.3' && cp examples/diskpool.conf $(DISK_POOL_CONFIG) || true mkdir -p $(INFO_STORE) @@ -220,7 +239,7 @@ preuninstall: $(SHELL) provider-register.sh -v -d -t @CIMSERVER@ -n root/interop -r $(subst $(top_srcdir)/schema,$(pkgdatadir), $(INTEROP_REGS)) -m $(subst $(top_srcdir)/schema,$(pkgdatadir), $(INTEROP_MOFS)) $(SHELL) provider-register.sh -v -d -t @CIMSERVER@ -n root/cimv2 -r $(subst $(top_srcdir)/schema,$(pkgdatadir), $(CIMV2_REGS)) -m $(subst $(top_srcdir)/schema,$(pkgdatadir), $(CIMV2_MOFS)) if [[ @CIMSERVER@ = pegasus ]]; then \ - $(SHELL) provider-register.sh -v -d -t @CIMSERVER@ -n root/PG_InterOp -r $(subst $(top_srcdir)/schema,$(pkgdatadir), $(PGINTEROP_REGS)) -m $(subst $(top_srcdir)/schema,$(pkgdatadir), $(PGINTEROP_MOFS)); \ + $(SHELL) provider-register.sh -v -d -t @CIMSERVER@ -n root/PG_InterOp -r $(subst $(top_srcdir)/schema,$(pkgdatadir), $(PGINTEROP_REGS)) -m $(subst $(top_srcdir)/schema,$(pkgdatadir), $(PGINTEROP_MOFS)); \ fi rpm: clean diff --git a/libvirt-cim.spec.in b/libvirt-cim.spec.in index 24ef280..01ee329 100644 --- a/libvirt-cim.spec.in +++ b/libvirt-cim.spec.in @@ -200,6 +200,10 @@ rm -fr $RPM_BUILD_ROOT %{_datadir}/%{name}/ReferencedProfile.mof \\\ %{_datadir}/%{name}/AllocationCapabilities.mof +# NOTE: As of Pegasus 2.12.1-5, using root/PG_InterOp will no longer be +# valid. All mofs can just compile into root/interop. However, we +# need to keep these here for 'historical purposes'. +# %define PGINTEROP_REG %{_datadir}/%{name}/RegisteredProfile.registration \\\ %{_datadir}/%{name}/ElementConformsToProfile.registration \\\ %{_datadir}/%{name}/ReferencedProfile.registration @@ -268,12 +272,12 @@ fi %if 0%{?fedora} >= 17 || 0%{?rhel} >= 7 if [ "`systemctl is-active tog-pegasus.service 2> /dev/null`" = "active" ] then - systemctl restart tog-pegasus.service + systemctl restart tog-pegasus.service > /dev/null 2>&1 fi if [ "`systemctl is-active sblim-sfcb.service 2> /dev/null`" = "active" ] then - systemctl restart sblim-sfcb.service + systemctl restart sblim-sfcb.service > /dev/null 2>&1 fi %else /etc/init.d/tog-pegasus condrestart @@ -287,9 +291,22 @@ then %{_datadir}/%{name}/provider-register.sh -t pegasus \ -n root/interop \ -r %{INTEROP_REG} -m %{INTEROP_MOF} -v >/dev/null 2>&1 || true - %{_datadir}/%{name}/provider-register.sh -t pegasus \ - -n root/PG_InterOp \ - -r %{PGINTEROP_REG} -m %{PGINTEROP_MOF} -v >/dev/null 2>&1 || true + # + # We need to check the version - if we're not yet at 2.12.1, then + # we'll register at root/PG_InterOp; otherwise, using just the above + # registration should be sufficient. The actual cutoff root/PG_InterOp + # not being valid was 2.12.1-5; however, --version doesn't give us that + # level of detail. The Pegasus docs imply that usage of root/interop was + # valid as of 2.12.0. + # + CIMVER=`/usr/sbin/cimserver --version | \ + awk -F. '{printf("%02d%02d%02d\n", $1,$2,$3); }'` + if [ $CIMVER -lt 021201 ] + then + %{_datadir}/%{name}/provider-register.sh -t pegasus \ + -n root/PG_InterOp \ + -r %{PGINTEROP_REG} -m %{PGINTEROP_MOF} -v >/dev/null 2>&1 || true + fi %{_datadir}/%{name}/provider-register.sh -t pegasus \ -n root/cimv2\ -r %{CIMV2_REG} -m %{CIMV2_MOF} -v >/dev/null 2>&1 || true diff --git a/provider-register.sh b/provider-register.sh index abe8e95..f66fe54 100755 --- a/provider-register.sh +++ b/provider-register.sh @@ -274,7 +274,23 @@ pegasus_install() chatter Registering providers with $state cimserver '('$version')' chatter Installing mofs into namespace $namespace from path $mofpath $CIMMOF -uc -I $mofpath -n $namespace $mymofs && - $CIMMOF -uc -n root/PG_Interop $_REGFILENAME + # + # If compare_version returns false here (e.g. $version is less than + # "2.12.1", then we will compile into root/PG_InterOp; otherwise, + # compile into root/interop. As of 2.12.1-5 using the PG_InterOp + # will fail. Since we cannot get that level of detail out of the + # --version output, "assume" that 2.12.1 -> 2.12.1-4 will be able + # to use the new namespace. The Pegasus docs imply as of 2.12.0 using + # root/interop was preferred. + # + if compare_version "$version" "2.12.1" + then + chatter Installing $_REGFILENAME into root/PG_InterOp + $CIMMOF -uc -n root/PG_Interop $_REGFILENAME + else + chatter Installing $_REGFILENAME into root/interop + $CIMMOF -uc -n root/interop $_REGFILENAME + fi else echo "Failed to build pegasus registration MOF." >&2 return 1 -- 1.8.4.2

3 3

[PATCH 0/6] Coverity cleanups
by John Ferlan 18 Feb '14

18 Feb '14

A recent Coverity version update discovered some existing issues (and some benign cases). This patch set cleans them all up. John Ferlan (6): VSMS: Coverity cleanups libxkutil:pool_parsing: Coverity cleanups libxkutil:device_parsing: Coverity cleanups libxkutil/xml_parse_test: Coverity cleanup RAFP: Coverity cleanup EAFP: Coverity cleanup libxkutil/device_parsing.c | 41 +++++++++++++++++-------------- libxkutil/pool_parsing.c | 39 +++++++++++++++-------------- libxkutil/xml_parse_test.c | 1 + src/Virt_ElementAllocatedFromPool.c | 6 ++++- src/Virt_ResourceAllocationFromPool.c | 7 ++++-- src/Virt_SettingsDefineCapabilities.c | 2 +- src/Virt_VirtualSystemManagementService.c | 11 ++++++--- 7 files changed, 63 insertions(+), 44 deletions(-) -- 1.8.4.2

3 18

About provProcs value problem for sblim-sfcb cim server
by Jincheng Miao 14 Feb '14

14 Feb '14

Hi all, I met a problem for sblim-sfcb cim server. In the configuration file, the default value of 'provProcs' is 32. While running cimtest, there are many failed cases with error "Provider not found or not loadable", eg: HostedAccessPoint - 01_forward.py: FAIL ERROR - No kvmrsap instance returned Provider not found or not loadable -------------------------------------------------------------------- HostedAccessPoint - 02_reverse.py: FAIL ERROR - No kvmrsap instance returned Provider not found or not loadable -------------------------------------------------------------------- After I change the value of 'provProcs' to 64, these cases pass. The provProcs is 'Max number of provider processes', and http://doc.opensuse.org/products/draft/SLES/SLES-admin_sd_draft/cha.wbem.ht… said 'if a new incoming request requires loading a new provider, then one of the existing providers will first be automatically unloaded' So I am wondering that why does sblim-sfcb not automatically unload the existing providers, and load the specified provider for case 'HostedAccessPoint - 01_forward.py'. Is it a real problem?

2 1

How LIBVIRT-CIM actually works
by Bouabid Mohamed Amine 31 Jan '14

31 Jan '14

Hello, I am a CIM developer and i am interested in LIBVIRT-CIM as a foundation for a futur work, so i have some questions about its design: How the VMs' life cycle methods are mapped with libvirt API? i mean the methods of the class CIM_VirtualSystemManagementService (DefineSystem, DestroySystem, ModifyResourceSettings, ModifySystemSettings, RemoveResourceSettings) What is the relation between the command wirsh and its XML description with the classes CIM_VirtualSystemSettingData, CIM_ResourceAllocationSettingData ? Is the libvirt-cim provider invoking the virsh command ? Thanks in advance Amine Bouabid

3 2

libvirt-cim compil errors
by Bouabid Mohamed Amine 30 Jan '14

30 Jan '14

Hello, I have compile errors when installing libvirt-cim from sources on UBUNTU 13.10 (amd-64 platform) I am using openpegasus as cimom, and i installed libcmpiutil successfully Bellow are the errors i get after make command (i followed instructions on the website http://wiki.libvirt.org/page/Libvirt-cim_setup) ..... make[2]: Entering directory `/usr/local/src/libvirt-cim/libvirt-cim-0.6.3/src' CC Virt_VirtualSystemManagementService.lo Virt_VirtualSystemManagementService.c: In function '_update_resources_for': Virt_VirtualSystemManagementService.c:2936:17: warning: implicit declaration of function 'cu_merge_instances' [-Wimplicit-function-declaration] s = cu_merge_instances(rasd, orig_inst); ^ Virt_VirtualSystemManagementService.c:2936:19: error: incompatible types when assigning to type 'CMPIStatus' from type 'int' s = cu_merge_instances(rasd, orig_inst); ^ make[2]: *** [Virt_VirtualSystemManagementService.lo] Error 1 make[2]: Leaving directory `/usr/local/src/libvirt-cim/libvirt-cim-0.6.3/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/usr/local/src/libvirt-cim/libvirt-cim-0.6.3' make: *** [all] Error 2 ... PS: the following commands do not working: $ hg clone http://libvirt.org/hg/libcmpiutil/ $ hg clone http://libvirt.org/hg/libvirt-cim/ the server says : abort: HTTP Error 404: Not Found Best Regards Amine Bouabid

4 10

[PATCH] spec: Fix docs/*.html packaging issue
by John Ferlan 22 Jan '14

22 Jan '14

Using a more recent rpmbuild on f20, I found that the 'make rpm' was failing: Installed (but unpackaged) file(s) found: /usr/share/doc/libvirt-cim-0.6.3/html/architecture.html /usr/share/doc/libvirt-cim-0.6.3/html/downloads.html /usr/share/doc/libvirt-cim-0.6.3/html/index.html /usr/share/doc/libvirt-cim-0.6.3/html/intro.html /usr/share/doc/libvirt-cim-0.6.3/html/libvirt-cim.html /usr/share/doc/libvirt-cim-0.6.3/html/news.html /usr/share/doc/libvirt-cim-0.6.3/html/patches.html /usr/share/doc/libvirt-cim-0.6.3/html/platforms.html /usr/share/doc/libvirt-cim-0.6.3/html/schema.html make: *** [rpm] Error 1 After a bit of research - I found the following page that describes a workaround to add "%define _unpackaged_files_terminate_build 0" to the spec file: http://www.oldrpm.org/hintskinks/unpackaged/ However, figuring that wasn't a great solution - I found a libvirt change that provided a way to work around what was being seen, see: http://www.redhat.com/archives/libvir-list/2013-November/msg00441.html It seems as though having that %doc doc/*.html is not proper any more. With this change I can once again build RPM packages Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- libvirt-cim.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-cim.spec.in b/libvirt-cim.spec.in index c96451b..24ef280 100644 --- a/libvirt-cim.spec.in +++ b/libvirt-cim.spec.in @@ -60,6 +60,7 @@ rm -f $RPM_BUILD_ROOT%{_libdir}/libxkutil.so mkdir -p $RPM_BUILD_ROOT/etc/ld.so.conf.d echo %{_libdir}/cmpi > $RPM_BUILD_ROOT/etc/ld.so.conf.d/libvirt-cim.%{_arch}.conf mkdir -p $RPM_BUILD_ROOT@INFO_STORE@ +mv $RPM_BUILD_ROOT%{_datadir}/doc/libvirt-cim-%{version} libvirt-cim-docs %clean rm -fr $RPM_BUILD_ROOT @@ -347,9 +348,8 @@ fi %defattr(-, root, root) %{_sysconfdir}/libvirt/cim -%doc README COPYING doc/CodingStyle doc/SubmittingPatches +%doc README COPYING doc/CodingStyle doc/SubmittingPatches libvirt-cim-docs/* %doc base_schema/README.DMTF -%doc doc/*.html %{_libdir}/lib*.so* %{_libdir}/cmpi/lib*.so* %{_datadir}/libvirt-cim -- 1.8.4.2

2 2

[PATCH] VSMS: fv_vssd_to_domain() resolve Coverity error
by John Ferlan 22 Jan '14

22 Jan '14

Coverity discovered that the free(domain->os_info.fv.arch) and then usage later on during get_default_machine() and get_default_emulator() calls could result in using free()'d memory. If the 'cu_get_str_prop() failed or capsinfo == NULL, then the fv.arch wouldn't necessarily be strdup()'d. Passing a NULL os_info.fv_arch into the get*() API's is fine since they'll call findDomainInfo() which can handle a NULL arch value. Also added an initialization of val just to be safe. I don't think it's necessary though. --- NOTE: I found this during a Coverity run applying the endianness patches. For some reason Coverity "woke up" and saw this even though it hasn't found this issue in a couple months of runs since the changes to this module were made. See commit id '117dabb9'. src/Virt_VirtualSystemManagementService.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Virt_VirtualSystemManagementService.c b/src/Virt_VirtualSystemManagementService.c index d51f230..9f8b5b9 100644 --- a/src/Virt_VirtualSystemManagementService.c +++ b/src/Virt_VirtualSystemManagementService.c @@ -464,7 +464,7 @@ static int fv_vssd_to_domain(CMPIInstance *inst, { int ret = 1; int retr; - const char *val; + const char *val = NULL; const char *domtype = NULL; const char *ostype = "hvm"; struct capabilities *capsinfo = NULL; @@ -494,6 +494,7 @@ static int fv_vssd_to_domain(CMPIInstance *inst, } free(domain->os_info.fv.arch); + domain->os_info.fv.arch = NULL; retr = cu_get_str_prop(inst, "Arch", &val); if (retr != CMPI_RC_OK) { if (capsinfo != NULL) { /* set default */ -- 1.8.3.1

2 2

Any updates/news regarding tog-pegasus and libvirt-cim
by John Ferlan 21 Jan '14

21 Jan '14

Back in November I discovered that tog-pegasus 2.12.1-8 the libvirt-cim usage of root/PG_InterOp would no longer work properly. For more context, see: http://www.redhat.com/archives/libvirt-cim/2013-November/msg00008.html and followups. Based on that I created an RFC/patch: http://www.redhat.com/archives/libvirt-cim/2013-November/msg00083.html I'm curious to know if there's any more progress/thoughts on this issue. If it's easier I can resend the patch, but figured since I've finally been able to devote some cycles to libvirt-cim - I'd ping again. NB: I recently updated to f20 which has 2.12.1-11 and it's broken there. Although it seems I don't need change the schema (e.g. FilterList fixes). Tks, John

1 0

[PATCH] PanicCheckABIStability: Need to check for existence
by John Ferlan 20 Dec '13

20 Dec '13

Commit id '4313fead' added a call to virDomainPanicCheckABIStability() which did not check whether the panic device existed before making a call to virDomainDeviceInfoCheckABIStability() which ended up segfaulting: Thread 1 (Thread 0x7f5332837700 (LWP 10964)): (src=<optimized out>, dst=<optimized out>) at conf/domain_conf.c:13007 (dst=<optimized out>, src=<optimized out>) at conf/domain_conf.c:13712 (src=<optimized out>, dst=<optimized out>) at conf/domain_conf.c:14056 (domain=domain@entry=0x7f53000057c0, vm=vm@entry=0x7f53000036d0, defptr=defptr@entry=0x7f5332836978, snap=snap@entry=0x7f5332836970, update_current=update_current@entry=0x7f5332836962, flags=flags@entry=1) at conf/snapshot_conf.c:1230 (domain=0x7f53000057c0, xmlDesc=<optimized out>, flags=1) at qemu/qemu_driver.c:12719 (domain=domain@entry=0x7f53000057c0, xmlDesc=0x7f53000081d0 "<domainsnapshot>\n <name>snap2</name>\n <description>new-desc</description>\n <state>running</state>\n <parent>\n <name>snap1</name>\n </parent>\n <creationTime>1387487268</creationTime>\n <memory s"..., flags=1) at libvirt.c:19695 ... (gdb) up 3 (gdb) print *other->def->dom $2 = {virtType = 2, id = -1, .. ... rng = 0x0, panic = 0x0, namespaceData = 0x0,... ... (gdb) print *def->dom $3 = {virtType = 2, id = -1, ... ... rng = 0x0, panic = 0x0, namespaceData = 0x0,... ... (gdb) Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- NOTE: Optionally the call could be changed to: "if (src->panic && !virDomainPanicCheckABIStability(...)" I went with what I did following the RNGDefCheckABIStability. src/conf/domain_conf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0079234..c86af9a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13709,6 +13709,9 @@ static bool virDomainPanicCheckABIStability(virDomainPanicDefPtr src, virDomainPanicDefPtr dst) { + if (!src && !dst) + return true; + return virDomainDeviceInfoCheckABIStability(&src->info, &dst->info); } -- 1.8.3.1

1 1