- CIM - libvirt List Archives

[PATCH] HRP accepts invalid references
by Kaitlin Rupert 02 Jan '08

02 Jan '08

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1198880883 28800 # Node ID e84ead6a0242ecb1cf63e871da8603d38233ff41 # Parent 3ea63b2076c1d02b7c3c48910809b9fb11ee290f HRP accepts invalid references. Add a get_host_cs() call to pool_to_sys() handler. The get_host_cs() call will verify whether the reference passed in is valid. This patch is dependant on the "#2 EAFP and RAFP support invalid references" patchset. Failing query: wbemcli gi 'http://localhost/root/virt:Xen_MemoryPool.InstanceID="wrong"' Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r 3ea63b2076c1 -r e84ead6a0242 src/Virt_HostedResourcePool.c --- a/src/Virt_HostedResourcePool.c Fri Dec 21 10:58:37 2007 -0800 +++ b/src/Virt_HostedResourcePool.c Fri Dec 28 14:28:03 2007 -0800 @@ -43,8 +43,13 @@ static CMPIStatus pool_to_sys(const CMPI { CMPIInstance *host; CMPIStatus s = {CMPI_RC_OK, NULL}; + CMPIInstance *inst; if (!match_hypervisor_prefix(ref, info)) + return s; + + s = get_pool_inst(_BROKER, ref, &inst); + if ((s.rc != CMPI_RC_OK) || (inst == NULL)) return s; s = get_host_cs(_BROKER, ref, &host);

2 2

HostedResourcePool association provider return expected result with wrong key name or value
by Guo Lian Yun 28 Dec '07

28 Dec '07

Hi, I encounter a problem of HostedResourcePool association provider, which can still return expected result with wrong key value, even wrong key name. wbemcli ain -ac Xen_HostedResourcePool http://root:password@localhost/root/virt:Xen_MemoryPool.InstanceID="wrong" localhost:5988/root/virt:Xen_HostSystem.CreationClassName="Xen_HostSystem",Name="zeit" wbemcli ain -ac Xen_HostedResourcePool http://root:password@localhost/root/virt:Xen_MemoryPool.wrong="wrong" localhost:5988/root/virt:Xen_HostSystem.CreationClassName="Xen_HostSystem",Name="zeit" That is mean, with a non existing instance, e.g. a wrong InstanceID name or value as above, it can return results also. Please can you have a look into this? Thanks! Best, Regards Daisy Guo Lian Yun E-mail: yunguol(a)cn.ibm.com IBM China Development Lab, Shanghai, China TEL: (86)-21-61008057

2 1

Xen_ResourceAllocationFromPool association provider return expected result with non existing instance of MemResourceAllocationSettingData and ProcResourceAllocationSettingData
by Guo Lian Yun 28 Dec '07

28 Dec '07

Hi, >From below test result, we can get MemResourceAllocationSettingData info, there is only one instance of MemResourceAllocationSettingData. wbemcli ain -ac Xen_ResourceAllocationFromPool http://root:password@localhost/root/virt:Xen_MemoryPool.InstanceID="MemoryPool/0" localhost:5988/root/virt:MemResourceAllocationSettingData.InstanceID="Domain-0/mem" However, with a non existing instance of MemResourceAllocationSettingData, the reverse test can return correct results also. wbemcli ain -ac Xen_ResourceAllocationFromPool http://root:password@localhost/root/virt:Xen_MemResourceAllocationSettingDa…" wrong" localhost:5988/root/virt:Xen_MemoryPool.InstanceID="MemoryPool/0" Meanwhile, the problem exist in Xen_ProcResourceAllocationSettingData instance. I think maybe this is provider's fault, please who can have a look at this? Thanks!! Best, Regards Daisy Guo Lian Yun E-mail: yunguol(a)cn.ibm.com IBM China Development Lab, Shanghai, China TEL: (86)-21-61008057

1 0

[PATCH 0 of 3] EAFP and RAFP support invalid instances.
by Kaitlin Rupert 21 Dec '07

21 Dec '07

This fix makes it so that EAFP and RAFP do not return instances if an invalid ref is given. These patches are dependant on the "Clean up RAFP and EAFP pool_to_* handlers." patchset.

2 10

report Xen_HostSystem parsing error in F8 while make postinstall
by Guo Lian Yun 21 Dec '07

21 Dec '07

Hi, When I running make postinstall, it reports parsing error : Parsing error: parse error: Error adding class Xen_HostSystem to the repository: CIM_ERR_INVALID_SUPERCLASS: Operation cannot be carried out since the specified superclass does not exist: "CIM_ComputerSystem" Actually, CIM_ComputerSystem exist in the repository (/var/lib/Pegasus/repository/root#virt/classes), and Xen_HostSystem has been added to the repository. Of course, I have installed schema cimv216Experimental successfully. This is using xen-3.1.0-13.fc8 and libvirt-0.3.3-2.fc8. However, there is no error in RHEL 5.1 by making postinstall. Who know why? Thanks! Best, Regards Daisy Guo Lian Yun E-mail: yunguol(a)cn.ibm.com IBM China Development Lab, Shanghai, China TEL: (86)-21-61008057

3 2

[PATCH 00 of 29] #2 - Enable libvirt-cim providers for OpenWbem
by Heidi Eckhart 21 Dec '07

21 Dec '07

updated schema and provider registration scripts added "Provider" qualifier to each provider's mof fixed provider and module naming Diff to #1: - patch 1: registration for interop namespace must be root/interop instead of /root/interop for OpenWbem - patch 7: forgot to rename provider in src file - patch 17: fixed hg header - patch 19: forgot to rename provider of MethodMI

2 30

[PATCH 00 of 29] Enable libvirt-cim providers for OpenWbem
by Heidi Eckhart 20 Dec '07

20 Dec '07

updated schema and provider registration scripts added "Provider" qualifier to each provider's mof fixed provider and module naming

4 35

[PATCH 0 of 2] Clean up RAFP and EAFP pool_to_* handlers.
by Kaitlin Rupert 20 Dec '07

20 Dec '07

Both of these handlers use a long if-else statement to determine the resource type. This can be replaced by device_type_from_poolid(). Also replaced a printf() in EAFP with a CU_DEBUG() statement.

2 3

[PATCH 0 of 2] [RFC] Prepare provider registration and provider name for OpenWbem
by Heidi Eckhart 19 Dec '07

19 Dec '07

To enable the libvirt-cim providers for registration and work with OpenWbem it is necessary to update the mof files with an additional "Provider" qualifier and slightly change the provider name. patch 1: updated the mof files with the additional "Provider" qualifier. The syntax is "<provider interface>:<module name>". For our providers this means "cmpi:<filename>", e.g. "cmpi:Virt_HostSystem" patch 2: the registration for OpenWbem requires an entry point <modulename>_Create_InstanceMI, which means that the filename and the providername have to become the same. This is necessary to let STD_InstanceMIStub correctly create the right CMPI entry points. I have tested this setup with sfcb, Pegasus and OpenWbem and it worked for all. If no one encounteres issues with this slighly changed provider naming, I will create patches for all providers. If someone has a hard requirement to name the provider different compared to the file, please raise your hand ;). I look forward an interesting discussion.

3 7

[PATCH] Remove error message of trailing backslash in src/Makefile.am
by Heidi Eckhart 19 Dec '07

19 Dec '07

# HG changeset patch # User Heidi Eckhart <heidieck(a)linux.vnet.ibm.com> # Date 1198059368 -3600 # Node ID 133cbb1df893f2d031cba3534c88936bce69da78 # Parent 615554f6eca4cd21e5715a3af73a616637e54f96 Remove error message of trailing backslash in src/Makefile.am Running libtool ... Running aclocal ... Running autoheader ... Running automake ... src/Makefile.am:17: whitespace following trailing backslash Running autoconf ... You may now run ./configure Signed-off-by: Heidi Eckhart <heidieck(a)linux.vnet.ibm.com> diff -r 615554f6eca4 -r 133cbb1df893 src/Makefile.am --- a/src/Makefile.am Fri Dec 14 16:13:18 2007 -0800 +++ b/src/Makefile.am Wed Dec 19 11:16:08 2007 +0100 @@ -14,7 +14,7 @@ noinst_HEADERS = profiles.h svpc_types.h Virt_SettingsDefineCapabilities.h \ Virt_VirtualSystemManagementCapabilities.h \ Virt_VirtualSystemManagementService.h \ - Virt_VSSD.h \ + Virt_VSSD.h \ Virt_VSMigrationCapabilities.h \ Virt_VSMigrationService.h

2 1