- CIM - libvirt List Archives

test message, pls ignore
by Wayne Xia 07 Dec '11

07 Dec '11

-- Best Regards Wayne Xia mail:xiawenc@linux.vnet.ibm.com tel:86-010-82450803

1 0

Release of libvirt-cim-0.5.15
by Chip Vincent 03 Dec '11

03 Dec '11

I'm happy announce the release of libvirt-cim-0.5.15. The new release is available at: ftp://libvirt.org/libvirt-cim/libvirt-cim-0.5.15.tar.gz libvirt-cim-0.5.15: * Fix include path (Eduardo Lima (Etrunko)) * xmlgen: Avoid double-free (Eduardo Lima (Etrunko)) * Fix possible use of uninitialized variables (Eduardo Lima (Etrunko)) * Fix misuse of signed variables (Eduardo Lima (Etrunko)) * Avoid NULL dereferences in various providers (Eduardo Lima (Etrunko)) * ACL: Plug leaks (Eduardo Lima (Etrunko)) * device_parsing: Avoid NULL dereferences (Eduardo Lima (Etrunko)) * pool_parsing: Avoid NULL dereferences (Eduardo Lima (Etrunko)) * acl_parsing: Avoid NULL dereference (Eduardo Lima (Etrunko)) * Avoid connection to libvirt if previous attempt fails (Eduardo Lima (Etrunko)) * Fix qos bug in primordial Network/0 pool (Gareth S. Bestor) * Rename .hgignore -> .gitignore (Chip Vincent) * Update autoconfiscate.sh to use git (Chip Vincent) * Add network qos (bandwidth) support for KVM guests (Gareth Bestor) * /dev/null should not be passed as source dev for cdrom device. (Sharad Mishra) * Add support for libvirt CPU cgroup for active KVM guests (Gareth S. Bestor) * FilterEntry: Set HdrProtocolID8021 property (Eduardo Lima (Etrunko)) * FilterEntry: Fix behavior of convert_ip_rule_to_instance (Eduardo Lima (Etrunko)) * FilterEntry: Support for mask in CIDR notation (Eduardo Lima (Etrunko)) * FilterEntry: Should be using srcipaddr instead of srcmacaddr (Eduardo Lima (Etrunko)) * acl_parsing: Share code for icmp and icmp rule types (Eduardo Lima (Etrunko)) * Pool names with space do not get parsed properly. (Sharad Mishra) * VirtualSystemManagementService: Avoid extra connection to libvirt (Eduardo Lima (Etrunko)) * (#2) Fix the problem that libvirt-cim can't find cdrom device that do not have disk (Wayne Xia) * device_parsing: Small code cleanup (Eduardo Lima (Etrunko)) * device_parsing: Use default values for vnc graphics device (Eduardo Lima (Etrunko)) * ACL: Add KVM_FilterEntry class (Eduardo Lima (Etrunko)) * Fix MOF download location - URL permanently changed (Chip Vincent) * Redirect stdout & stderr when run as out-of-process provider (Chip Vincent) * (#2) Return migration job status in CIM_ConcreteJob.ErrorCode (Sharad Mishra) * ACL: Add 'Action' property to KVM_{IPHeaders,Hdr8021}Filter (Eduardo Lima (Etrunko)) * (#2) Workaround to fix race condition around libvirt init. (Sharad Mishra) * VirtualSystemManagementService: Fix yet another possible leak (Eduardo Lima (Etrunko)) * VirtualSystemManagementService: Fixing potential null dereferences (Eduardo Lima (Etrunko)) * device_parsing: Fixing potential leaks (Eduardo Lima (Etrunko)) * Patches for Virt_SettingsDefineCapabilities: incorrect Default Value... (Gareth S. Bestor) * (#5) add sdl frame buffer support. (Wayne Xia) * (#5) made the graphic structure as union (Wayne Xia) * acl_parsing: Fixing potential leaks (Eduardo Lima (Etrunko)) * Check to see if stream is non-null before closing. (Sharad Mishra) * Retrun object paths for newly created filter associations. (Chip Vincent) * New entry "poolid" was not getting DUPed. (Sharad Mishra) * Fix connection leak introduced in patch 1119. (Sharad Mishra) -- Chip Vincent Open Virtualization IBM Linux Technology Center cvincent(a)linux.vnet.ibm.com

1 0

[TEST] Unable to run cimtest on qemu kvm setup
by Deepak Shetty 02 Dec '11

02 Dec '11

dpkshetty@deepak-ThinkPad-T60p :~/work/cimtest/cimtest$ sudo CIM_NS=root/virt CIM_USER=root CIM_PASS=****** ./runtests libvirt-cim -i localhost -c -d -v KVM -g ComputerSys tem -t 04_defineStartVS.py Starting test suite: libvirt-cim Traceback (most recent call last): File "main.py", line 42, in <module> from XenKvmLib.common_util import create_netpool_conf, destroy_netpool, \ File "./lib/XenKvmLib/common_util.py", line 31, in <module> from XenKvmLib.test_xml import * File "./lib/XenKvmLib/test_xml.py", line 32, in <module> from xml import xpath ImportError: cannot import name xpath I have all the pre-req installed as mentioned on the http://wiki.libvirt.org/page/Cimtest_setup <http://wiki.libvirt.org/page/Cimtest_setup> wiki. there is no pyxml eq. on ubuntu ( I am on ubuntu host) but i do have these... dpkshetty@deepak-ThinkPad-T60p:~/work/cimtest/cimtest$ dpkg -l | grep python | grep xml ii python-libxml2 2.7.8.dfsg-2 Python bindings for the GNOME XML library ii python-lxml 2.3-0.1 pythonic binding for the libxml2 and libxslt libraries dpkshetty@deepak-ThinkPad-T60p:~/work/cimtest/cimtest$ dpkshetty@deepak-ThinkPad-T60p:~/work/cimtest/cimtest$ dpkg -l | grep python2 ii libpython2.7 2.7.1-5ubuntu2 Shared Python runtime library (version 2.7) ii python2.6 2.6.6-6ubuntu7 An interactive high-level object-oriented language (version 2.6) ii python2.6-minimal 2.6.6-6ubuntu7 A minimal subset of the Python language (version 2.6) ii python2.7 2.7.1-5ubuntu2 An interactive high-level object-oriented language (version 2.7) ii python2.7-dev 2.7.1-5ubuntu2 Header files and a static library for Python (v2.7) ii python2.7-minimal 2.7.1-5ubuntu2 A minimal subset of the Python language (version 2.7) dpkshetty@deepak-ThinkPad-T60p:~/work/cimtest/cimtest$ dpkshetty@deepak-ThinkPad-T60p:~/work/cimtest/cimtest$ dpkg -l | grep wbem ii python-pywbem 0.7.0-4 Python WBEM Client and Provider Interface dpkshetty@deepak-ThinkPad-T60p:~/work/cimtest/cimtest$ Can someone help or tell me what am I missing ? My aim is to invole the create/define system flow via libvirt-cim. thanx, deepak

3 3

[TEST] cimtest make broken....
by Deepak Shetty 02 Dec '11

02 Dec '11

I was following the cimtest wiki @ http://wiki.libvirt.org/page/Cimtest_setup <http://wiki.libvirt.org/page/Cimtest_setup> and it seems to be broken.. ~/work/cimtest/cimtest/suites/ libvirt-cim/images$ make mkdir -p xm-test (cd xm-test && wget http://xm-test.xensource.com/ramdisks/initrd-1.1-i386.img <http://xm-test.xensource.com/ramdisks/initrd-1.1-i386.img>) --2011-11-30 10:18:48-- http://xm-test.xensource.com/ramdisks/initrd-1.1-i386.img <http://xm-test.xensource.com/ramdisks/initrd-1.1-i386.img> Resolving xm-test.xensource.com... failed: Name or service not known. wget: unable to resolve host address `xm-test.xensource.com <http://xm-test.xensource.com>' make: *** [xm-test/initrd-1.1-i386.img] Error 4 I am connected to the internet, but that xm-test URL just does not ping. dpkshetty@deepak-ThinkPad-T60p:~/work/cimtest/cimtest/suites/libvirt-cim/images$ ping xm-test.xensource.com <http://xm-test.xensource.com> ping: unknown host xm-test.xensource.com <http://xm-test.xensource.com> dpkshetty@deepak-ThinkPad-T60p:~/work/cimtest/cimtest/suites/libvirt-cim/images$ ping www.yahoo.com <http://www.yahoo.com> PING any-fp3-real.wa1.b.yahoo.com <http://any-fp3-real.wa1.b.yahoo.com> (98.139.180.149) 56(84) bytes of data. 64 bytes from ir1.fp.vip.bf1.yahoo.com <http://ir1.fp.vip.bf1.yahoo.com> (98.139.180.149): icmp_req=1 ttl=52 time=430 ms 64 bytes from ir1.fp.vip.bf1.yahoo.com <http://ir1.fp.vip.bf1.yahoo.com> (98.139.180.149): icmp_req=2 ttl=52 time=318 ms 64 bytes from ir1.fp.vip.bf1.yahoo.com <http://ir1.fp.vip.bf1.yahoo.com> (98.139.180.149): icmp_req=3 ttl=52 time=323 ms

1 0

[PATCH] [TEST] Fix VSMS 09_procrasd_persist and 11_define_memrasdunits
by Eduardo Lima (Etrunko) 18 Nov '11

18 Nov '11

From: Eduardo Lima (Etrunko) <eblima(a)br.ibm.com> Both tests were failing due to reusing an instance of the class for defining domains in a loop. The error message was the following: ERROR - Got CIM error CIM_ERR_FAILED: ResourceSettings Error: VirtualDevice property must be unique for each DiskResourceAllocationSettingData in a single guest with return code 1 A recent change in XenKvmLib/vxml.py necessary for the new test 32_modify_cdrom_media.py triggered this bug. To avoid this error we simply create a new instance of that class in each iteration of the loop. Signed-off-by: Eduardo Lima (Etrunko) <eblima(a)br.ibm.com> --- .../09_procrasd_persist.py | 3 ++- .../11_define_memrasdunits.py | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/09_procrasd_persist.py b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/09_procrasd_persist.py index 91415dd..a53c5ac 100644 --- a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/09_procrasd_persist.py +++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/09_procrasd_persist.py @@ -119,11 +119,12 @@ def main(): virt = options.virt server = options.ip - cxml = get_class(virt)(test_dom) + cxml = None prasd_cn = get_typed_class(virt, "ProcResourceAllocationSettingData") dom_define = dom_start = False try: for count in range(3): + cxml = get_class(virt)(test_dom) status = setup_guest(server, virt, cxml, prasd_cn) if status != PASS: return status diff --git a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/11_define_memrasdunits.py b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/11_define_memrasdunits.py index 8c032c2..3f54ff4 100644 --- a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/11_define_memrasdunits.py +++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/11_define_memrasdunits.py @@ -113,8 +113,7 @@ def check_value(options): def main(): options = main.options - cxml = get_class(options.virt)(default_dom) - + cxml = None status = FAIL guest_is_undefined = None @@ -123,6 +122,7 @@ def main(): value = mem_bytes >> shift + cxml = get_class(options.virt)(default_dom) status = try_define(options, units, value, cxml) if status != PASS: break -- 1.7.4.4

3 2

[PATCH] Fix include path
by Eduardo Lima (Etrunko) 15 Nov '11

15 Nov '11

From: Eduardo Lima (Etrunko) <eblima(a)br.ibm.com> $(top_builddir) is intended to be used for install paths, while $(top_srcdir) whenever trying to reference source code path. Signed-off-by: Eduardo Lima (Etrunko) <eblima(a)br.ibm.com> --- src/Makefile.am | 2 +- src/Virt_VSMigrationService.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 53e3c65..e4e8aa1 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -29,7 +29,7 @@ noinst_HEADERS = profiles.h svpc_types.h \ XKUADD = $(top_builddir)/libxkutil/libxkutil.la -CFLAGS += -I$(top_builddir)/libxkutil $(CFLAGS_STRICT) +CFLAGS += -I$(top_srcdir)/libxkutil $(CFLAGS_STRICT) AM_LDFLAGS = $(XKUADD) \ -version-info @VERSION_INFO@ diff --git a/src/Virt_VSMigrationService.c b/src/Virt_VSMigrationService.c index be9bb7c..4f48a68 100644 --- a/src/Virt_VSMigrationService.c +++ b/src/Virt_VSMigrationService.c @@ -48,7 +48,7 @@ #include "Virt_ComputerSystem.h" #include "Virt_VSMigrationSettingData.h" #include "svpc_types.h" -#include "libxkutil/infostore.h" +#include "infostore.h" #include "config.h" -- 1.7.4.4

2 1

Various fixes revealed by Coverity scan report
by Eduardo Lima (Etrunko) 15 Nov '11

15 Nov '11

Hi all, The cool RedHat folks were kind enough to share a recent report generated by Coverity which exposes a lot of potential errors on libvirt-cim code. https://bugzilla.redhat.com/show_bug.cgi?id=728245#c8 https://bugzilla.redhat.com/attachment.cgi?id=530435 I went through each one of them and fixed all of them that I considered it actually make sense to fix. There are a few false positives that were ignored. The result is this series of patches following. Finally, I have ran the cimtests with all these applied and they work as expected. Best regards, -- Eduardo de Barros Lima Software Engineer, Open Virtualization Linux Technology Center - IBM/Brazil eblima(a)br.ibm.com

3 19

Error doing make install for libvirt-cim
by Deepak Shetty 04 Nov '11

04 Nov '11

Hi, I am getting the following error while doing ' make install' for libvirt-cim. Can someone pls help provide some pointers on what could be wrong here ? .... .... test -z "/home/dpkshetty/usr/lib/cmpi" || /bin/mkdir -p "/home/dpkshetty/usr/lib/cmpi" /bin/bash ../libtool --mode=install /usr/bin/install -c libVirt_ComputerSystem.la libVirt_Device.la libVirt_RASD.la libVirt_HostSystem.la libVirt_VSSD.la libVirt_EnabledLogicalElementCapabilities.la libVirt_DevicePool.la libVirt_RegisteredProfile.la libVirt_VSMigrationCapabilities.la libVirt_VSMigrationSettingData.la libVirt_VirtualSystemSnapshotServiceCapabilities.la libVirt_SystemDevice.la libVirt_ComputerSystemIndication.la libVirt_ResourceAllocationSettingDataIndication.la libVirt_SwitchService.la libVirt_ComputerSystemMigrationIndication.la libVirt_VirtualSystemManagementCapabilities.la libVirt_AllocationCapabilities.la libVirt_ReferencedProfile.la libVirt_VirtualSystemSnapshotService.la libVirt_VirtualSystemManagementService.la libVirt_ResourcePoolConfigurationService.la libVirt_ResourcePoolConfigurationCapabilities.la libVirt_VSMigrationService.la libVirt_ConsoleRedirectionService.la libVirt_ConsoleRedirectionServiceCapabilities.la libVirt_KVMRedirectionSAP.la libVirt_SettingsDefineCapabilities.la libVirt_HostedDependency.la libVirt_ElementConformsToProfile.la libVirt_HostedResourcePool.la libVirt_ElementCapabilities.la libVirt_VSSDComponent.la libVirt_SettingsDefineState.la libVirt_ResourceAllocationFromPool.la libVirt_ElementAllocatedFromPool.la libVirt_HostedService.la libVirt_ElementSettingData.la libVirt_ConcreteComponent.la libVirt_ServiceAffectsElement.la libVirt_HostedAccessPoint.la libVirt_ServiceAccessBySAP.la libVirt_SAPAvailableForElement.la libVirt_FilterList.la libVirt_FilterEntry.la libVirt_EntriesInFilterList.la libVirt_NestedFilterList.la libVirt_HostedFilterList.la libVirt_AppliedFilterList.la '/home/dpkshetty/usr/lib/cmpi' *libtool: install: warning: relinking `libVirt_ComputerSystem.la'* libtool: install: (cd /home/dpkshetty/work/libvirt-cim/libvirt-cim/src; /bin/bash /home/dpkshetty/work/libvirt-cim/libvirt-cim/libtool --silent --tag CC --mode=relink gcc -g -O2 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Wall -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wformat=2 -Wformat-security -Wformat-nonliteral -Wno-format-y2k -Wcast-align -Wno-unused-value -DLIBVIRT_CIM_CS=\"2714b9a5e842\" -DLIBVIRT_CIM_RV=\"1151\" -I../libxkutil ../libxkutil/libxkutil.la -version-info 5:14:5 -L/home/dpkshetty/usr/lib -lvirt -ldl -L/home/dpkshetty/usr/lib -lcmpiutil -L/usr/lib/i386-linux-gnu -luuid -o libVirt_ComputerSystem.la -rpath /home/dpkshetty/usr/lib/cmpi Virt_ComputerSystem.lo -lVirt_VirtualSystemSnapshotService ) */usr/bin/ld: cannot find -lVirt_VirtualSystemSnapshotService* collect2: ld returned 1 exit status libtool: install: error: relink `libVirt_ComputerSystem.la' with the above command before installing it make[2]: *** [install-providerLTLIBRARIES] Error 1 make[2]: Leaving directory `/home/dpkshetty/work/libvirt-cim/libvirt-cim/src' make[1]: *** [install-am] Error 2 make[1]: Leaving directory `/home/dpkshetty/work/libvirt-cim/libvirt-cim/src' make: *** [install-recursive] Error 1

4 10

cimtest errors
by Chip Vincent 04 Nov '11

04 Nov '11

FYI - It's getting close to creating a new release and I'd like to get libvirt-cim and cimtest in sync. With the latest upstream libvirt-cim and cimtest, I'm seeing the follow unexpected[1] errors in cimtest: VirtualSystemManagementService - 09_procrasd_persist.py: FAIL ERROR - Got CIM error CIM_ERR_FAILED: ResourceSettings Error: VirtualDevice property must be unique for each DiskResourceAllocationSettingData in a single guest with return code 1 ERROR - Unable to define procrasd_persist_dom InvokeMethod(DefineSystem): CIM_ERR_FAILED: ResourceSettings Error: VirtualDevice property must be unique for each DiskResourceAllocationSettingData in a single guest -------------------------------------------------------------------- VirtualSystemManagementService - 11_define_memrasdunits.py: FAIL ERROR - Got CIM error CIM_ERR_FAILED: ResourceSettings Error: VirtualDevice property must be unique for each DiskResourceAllocationSettingData in a single guest with return code 1 ERROR - DefineSystem with (KiloBytes) units failed InvokeMethod(DefineSystem): CIM_ERR_FAILED: ResourceSettings Error: VirtualDevice property must be unique for each DiskResourceAllocationSettingData in a single guest -------------------------------------------------------------------- VirtualSystemSnapshotService - 03_create_snapshot.py: FAIL ERROR - Exception: CreateSnapshot failed to return a CIM job inst ERROR - Failed to remove snapshot file for snapshot_vm A very quick peek at the code shows this message occurs when one tries to add a disk device with the same names as one that already exists. This is a no-no in cim. I'll dig into the root cause tomorrow and provide an update. [1] - I see several other typical errors that are either known issues or side-effects of a non-pristine system. Sadly, cimtest considers the default RHEL 6.1+ config not pristine and falsely fails due to some pre-configured pools. I plan to address this soon. -- Chip Vincent Open Virtualization IBM Linux Technology Center cvincent(a)linux.vnet.ibm.com

4 7

[PATCH] Avoid connection to libvirt if previous attempt fails
by Eduardo Lima (Etrunko) 02 Nov '11

02 Nov '11

From: Eduardo Lima (Etrunko) <eblima(a)br.ibm.com> This is a workaround to avoid libvirt flooding error messages in syslog. This happens often if a client submits queries for CIM_ superclasses, which then will translate to a query for each registered class. In our case KVM_, LXC_ and XEN_. Ideally, there should be a way to ask libvirt if a given URI or hypervisor is enabled/supported. A patch for that feature is on the works, and as soon as it is integrated to libvirt tree this feature will be updated. Signed-off-by: Eduardo Lima (Etrunko) <eblima(a)br.ibm.com> --- libxkutil/misc_util.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 48 insertions(+), 0 deletions(-) diff --git a/libxkutil/misc_util.c b/libxkutil/misc_util.c index c2cc204..61893c3 100644 --- a/libxkutil/misc_util.c +++ b/libxkutil/misc_util.c @@ -24,6 +24,7 @@ #include <stdio.h> #include <string.h> +#include <strings.h> #include <stdlib.h> #include <stdbool.h> #include <stdarg.h> @@ -53,6 +54,46 @@ static int libvirt_initialized = 0; #define URI_ENV "HYPURI" +struct _hypervisor_status_t { + const char *name; + bool enabled; +}; + +typedef struct _hypervisor_status_t hypervisor_status_t; + +static hypervisor_status_t hypervisor_list[] = { + { "xen", true }, + { "kvm", true }, + { "lxc", true }, + { NULL }, +}; + +static bool get_hypervisor_enabled(const char *hypervisor) +{ + hypervisor_status_t *h; + + for (h = &hypervisor_list[0]; h != NULL; h++) { + if (strncasecmp(hypervisor, h->name, strlen(h->name)) == 0) { + return h->enabled; + } + } + + return false; +} + +static void set_hypervisor_disabled(const char *hypervisor) +{ + hypervisor_status_t *h; + + for (h = &hypervisor_list[0]; h != NULL; h++) { + if (strncasecmp(hypervisor, h->name, strlen(h->name)) == 0) { + CU_DEBUG("Setting '%s' hypervisor as DISABLED", h->name); + h->enabled = false; + return; + } + } +} + static const char *cn_to_uri(const char *classname) { if (STARTS_WITH(classname, "Xen")) @@ -117,6 +158,9 @@ virConnectPtr connect_by_classname(const CMPIBroker *broker, return NULL; } + if (!get_hypervisor_enabled(classname)) + return NULL; + CU_DEBUG("Connecting to libvirt with uri `%s'", uri); pthread_mutex_lock(&libvirt_mutex); @@ -129,6 +173,10 @@ virConnectPtr connect_by_classname(const CMPIBroker *broker, pthread_mutex_unlock(&libvirt_mutex); if (!conn) { + virErrorPtr error = virGetLastError(); + if (error->code == VIR_ERR_NO_CONNECT) + set_hypervisor_disabled(classname); + CU_DEBUG("Unable to connect to `%s'", uri); return NULL; } -- 1.7.4.4

3 2