- CIM - libvirt List Archives

Fwd: Re: [PATCH 4/4] DevicePool, reimplement get_diskpool_config with libvirt
by Wenchao Xia 26 Oct '12

26 Oct '12

> On Mon, Oct 22, 2012 at 5:38 AM, Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> wrote: >> Oringinal implement have risk, this patch should fix it >> >> Signed-off-by: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> >> --- >> src/Virt_DevicePool.c | 47 +++++++++++++++++++++++++++++++++++------------ >> 1 files changed, 35 insertions(+), 12 deletions(-) >> >> diff --git a/src/Virt_DevicePool.c b/src/Virt_DevicePool.c >> index 79dc108..0cb9124 100644 >> --- a/src/Virt_DevicePool.c >> +++ b/src/Virt_DevicePool.c >> @@ -117,52 +117,75 @@ int get_disk_pool(virStoragePoolPtr poolptr, struct virt_pool **pool) >> return ret; >> } >> >> +/* This function returns the real number of pools, no negative value should be >> + returned, if error happens it returns zero. */ >> static int get_diskpool_config(virConnectPtr conn, >> struct tmp_disk_pool **_pools) >> { >> - int count = 0; >> + int count = 0, realcount = 0; >> int i; >> char ** names = NULL; >> struct tmp_disk_pool *pools = NULL; >> + int have_err = 0; >> >> count = virConnectNumOfStoragePools(conn); >> - if (count <= 0) >> + if (count <= 0) { >> + have_err = 1; >> goto out; >> + } >> >> names = calloc(count, sizeof(char *)); >> if (names == NULL) { >> CU_DEBUG("Failed to alloc space for %i pool names", count); >> count = 0; >> + have_err = 1; >> goto out; >> } >> >> - if (virConnectListStoragePools(conn, names, count) == -1) { >> + realcount = virConnectListStoragePools(conn, names, count); >> + if (realcount == -1) { >> CU_DEBUG("Failed to get storage pools"); >> - count = 0; >> + realcount = 0; >> + have_err = 1; >> + goto out; >> + } >> + if (realcount == 0) { >> + CU_DEBUG("zero pools got, but prelist is %d.", count); >> goto out; >> } >> >> - pools = calloc(count, sizeof(*pools)); >> + pools = calloc(realcount, sizeof(*pools)); >> if (pools == NULL) { >> - CU_DEBUG("Failed to alloc space for %i pool structs", count); >> + CU_DEBUG("Failed to alloc space for %i pool structs", realcount); >> + realcount = 0; >> + have_err = 1; >> goto out; >> } >> >> - for (i = 0; i < count; i++) { >> + i = 0; >> + while (i < realcount) { >> pools[i].tag = strdup(names[i]); >> pools[i].primordial = false; >> + i++; >> } > > Any specific reason for changing the for() loop for a while() one?? > >> >> out: >> - for (i = 0; i < count; i++) >> - free(names[i]); >> - free(names); >> + if (count > 0) { >> + i = 0; >> + while (i < count) { >> + free(names[i]); >> + i++; >> + } >> + free(names); >> + } > > Same here. > > Best regards, > Good to see you again, there is one for() before which may take one execution if count == 0,where it should not. For safe and code style unifying I switch it all to while. I am tring to fix some bugs after libvirt CSI patch applied, which make cimtest report strange error, A bit brute, could u help share some findings for those strange errors? (2 profile test case failing strangely, if CSI test case is executed with CSI patched libvirt-cim). -- Best Regards Wenchao Xia

2 2

[PATCH 1/4] CSI, fix debug print crash
by Wenchao Xia 24 Oct '12

24 Oct '12

Signed-off-by: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> --- src/Virt_ComputerSystemIndication.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Virt_ComputerSystemIndication.c b/src/Virt_ComputerSystemIndication.c index 2d0a94e..b1b9fa0 100644 --- a/src/Virt_ComputerSystemIndication.c +++ b/src/Virt_ComputerSystemIndication.c @@ -503,7 +503,7 @@ static void csi_domain_event_cb(virConnectPtr conn, CMPIStatus s = {CMPI_RC_OK, NULL}; if (lifecycle_enabled == false || thread->active_filters <= 0) { - CU_DEBUG("%s indications deactivated, return"); + CU_DEBUG("%s indications deactivated, return", prefix); return; } -- 1.7.1

3 7

Test result for libvirt-cim-0.6.1-4.el6 with cimtest suite
by Yanbing Du 16 Oct '12

16 Oct '12

Hi Jiri, We just tested the libvirt-cim-0.6.1-4.el6 with cimtest suite, and pasted the summary as following, please check the full report in the attachment. BTW, the result is same with libvirt-cim-0.6.1-3.el6 we last tested. ================================================= Test Run Summary (Oct 16 2012): KVM on Red Hat Enterprise Linux Server release 6.3 (Santiago) with Pegasus ================================================= Distro: Red Hat Enterprise Linux Server release 6.3 (Santiago) Kernel: 2.6.32-323.el6.x86_64 libvirt: 0.10.2 Hypervisor: QEMU 0.12.1 CIMOM: Pegasus 2.11.0 Libvirt-cim revision: 1192 Libvirt-cim changeset: 0c468a8 Cimtest revision: Cimtest changeset: 93f0e6e Total test execution: Unknown ================================================= FAIL : 30 XFAIL : 2 SKIP : 14 PASS : 146 ----------------- Total : 192 ================================================= FAIL Test Summary: ElementAllocatedFromPool - 01_forward.py: FAIL ElementAllocatedFromPool - 02_reverse.py: FAIL ElementConforms - 01_forward.py: FAIL ElementConforms - 04_ectp_rev_errs.py: FAIL HostedResourcePool - 01_forward.py: FAIL HostSystem - 04_hs_to_EAPF.py: FAIL Profile - 02_profile_to_elec.py: FAIL Profile - 04_verify_libvirt_cim_slp_profiles.py: FAIL RASDIndications - 01_guest_states_rasd_ind.py: FAIL RASDIndications - 02_guest_add_mod_rem_rasd_ind.py: FAIL ResourceAllocationFromPool - 01_forward.py: FAIL ResourceAllocationFromPool - 02_reverse.py: FAIL SettingsDefineCapabilities - 01_forward.py: FAIL VirtualSystemManagementService - 06_addresource.py: FAIL VirtualSystemManagementService - 08_modifyresource.py: FAIL VirtualSystemManagementService - 09_procrasd_persist.py: FAIL VirtualSystemManagementService - 11_define_memrasdunits.py: FAIL VirtualSystemManagementService - 12_referenced_config.py: FAIL VirtualSystemManagementService - 13_refconfig_additional_devs.py: FAIL VirtualSystemManagementService - 14_define_sys_disk.py: FAIL VirtualSystemManagementService - 18_define_sys_bridge.py: FAIL VirtualSystemManagementService - 19_definenetwork_ers.py: FAIL VirtualSystemManagementService - 22_addmulti_brg_interface.py: FAIL VirtualSystemManagementService - 25_definesystem_floppy.py: FAIL VirtualSystemManagementService - 26_definesystem_nic_dev.py: FAIL VirtualSystemManagementService - 27_definesystem_macvtap_dev.py: FAIL VirtualSystemManagementService - 28_definesystem_with_vsi_profile.py: FAIL VirtualSystemManagementService - 29_cdrom_media_change.py: FAIL VirtualSystemSnapshotService - 03_create_snapshot.py: FAIL VSSD - 06_duplicate_uuid.py: FAIL ================================================= XFAIL Test Summary: SwitchService - 01_enum.py: XFAIL VirtualSystemManagementService - 30_dynamic_disk_mod.py: XFAIL ================================================= SKIP Test Summary: ComputerSystemMigrationJobIndication - 01_csmig_ind_for_offline_mig.py: SKIP ResourcePoolConfigurationService - 08_CreateDiskResourcePool.py: SKIP ResourcePoolConfigurationService - 10_create_storagevolume.py: SKIP ResourcePoolConfigurationService - 11_create_dir_storagevolume_errs.py: SKIP ResourcePoolConfigurationService - 13_delete_storagevolume.py: SKIP ResourcePoolConfigurationService - 14_delete_storagevolume_errs.py: SKIP ResourcePoolConfigurationService - 15_DiskPoolAutostart.py: SKIP VirtualSystemMigrationService - 01_migratable_host.py: SKIP VirtualSystemMigrationService - 02_host_migrate_type.py: SKIP VirtualSystemMigrationService - 05_migratable_host_errs.py: SKIP VirtualSystemMigrationService - 06_remote_live_migration.py: SKIP VirtualSystemMigrationService - 07_remote_offline_migration.py: SKIP VirtualSystemMigrationService - 08_remote_restart_resume_migration.py: SKIP VSSD - 02_bootldr.py: SKIP ================================================= Thanks & Best Regards Yanbing Du

1 0

[PATCH] do not deregister virt classes in yum upgrade
by Wenchao Xia 21 Sep '12

21 Sep '12

Now yum upgrade will deregister the virt classes, make libvirt-cim not workable. This patch fixed it from now on. Signed-off-by: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> --- libvirt-cim.spec.in | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/libvirt-cim.spec.in b/libvirt-cim.spec.in index d78eee7..3def978 100644 --- a/libvirt-cim.spec.in +++ b/libvirt-cim.spec.in @@ -104,18 +104,22 @@ rm -fr $RPM_BUILD_ROOT -r %{CIMV2_REG} -m %{CIMV2_MOF} -v >/dev/null 2>&1 || true %preun -%{_datadir}/%{name}/provider-register.sh -d -t pegasus \ +#Deregister only in uninstall, do nothing in upgrade. +if [ "$1" = "0" ]; then + echo "Deleting registered classes in libvirt-cim..." + %{_datadir}/%{name}/provider-register.sh -d -t pegasus \ -n @CIM_VIRT_NS@ \ -r %{REGISTRATION} -m %{SCHEMA} >/dev/null 2>&1 || true -%{_datadir}/%{name}/provider-register.sh -d -t pegasus \ + %{_datadir}/%{name}/provider-register.sh -d -t pegasus \ -n root/interop \ -r %{INTEROP_REG} -m %{INTEROP_MOF} >/dev/null 2>&1 || true -%{_datadir}/%{name}/provider-register.sh -d -t pegasus \ + %{_datadir}/%{name}/provider-register.sh -d -t pegasus \ -n root/PG_InterOp \ -r %{PGINTEROP_REG} -m %{PGINTEROP_MOF} >/dev/null 2>&1 || true -%{_datadir}/%{name}/provider-register.sh -d -t pegasus \ + %{_datadir}/%{name}/provider-register.sh -d -t pegasus \ -n root/cimv2 \ -r %{CIMV2_REG} -m %{CIMV2_MOF} >/dev/null 2>&1 || true +fi %postun -p /sbin/ldconfig -- 1.7.1

1 0

[PATCH V2] provide a hack to borrow non-root ssh keys in migration
by Wenchao Xia 19 Sep '12

19 Sep '12

This patch allow libvirt-cim to use non-root's ssh key, not using root's key to avoid exposing root's ssh login. Because libvirt-cim runs in root mode so it is hard to satisfy some server security rules especially about root's ssh key exposing. This is a walk around to improve it. This patch added three additonal paremeters in vs migration and migratable method, they are DestinationHostParams, SSH_Key_Src, SSH_Key_Dest. DestinationHostParams is the addtional string which would be appended after the uri if it was set, so with this parameter user could add additional parameter in libvirt remote uri, such as "?keyfile=/tmp/tempkey.rsa". Because libvirt woulkd ignore the private key file parameter, if the key's directory was not owned by the user, and libvirt-cim runs as root, so SSH_Key_Src and SSH_Key_Dest were provided to allow a copying of keyfile to a directory that owned by root, at runtime. if SSH_Key_Src and SSH_Key_Dest were set, libvirt-cim would run shell command "cp -f [SSH_Key_Src] [SSH_Key_Dest]". Typically cim client with authority to do a migration, could specify these three additonal parameters with ssh migration method set, as DestinationHostParams="?keyfile=/root/temp_migration_key.rsa" SSH_Key_Src="/home/VController/.ssh/id_rsa" SSH_Key_Dest="/root/temp_migration_key.rsa" then, the migration would complete with VController's key pairs, instead of root's, avoided turning on root's ssh logins. Test was done when SELinux was shutdown. V2: Better documentation. Signed-off-by: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> --- src/Virt_VSMigrationService.c | 96 +++++++++++++++++++++++++++++++++++++++-- 1 files changed, 92 insertions(+), 4 deletions(-) diff --git a/src/Virt_VSMigrationService.c b/src/Virt_VSMigrationService.c index 76e3d25..55442ee 100644 --- a/src/Virt_VSMigrationService.c +++ b/src/Virt_VSMigrationService.c @@ -150,6 +150,7 @@ static CMPIStatus get_migration_uri(CMPIInstance *msd, static char *dest_uri(const char *cn, const char *dest, + const char *dest_params, uint16_t transport) { const char *prefix; @@ -157,6 +158,7 @@ static char *dest_uri(const char *cn, const char *param = ""; char *uri = NULL; int rc; + int param_labeled = 0; if (STARTS_WITH(cn, "Xen")) prefix = "xen"; @@ -197,16 +199,75 @@ static char *dest_uri(const char *cn, goto out; } - if (!STREQC(param, "")) + if (!STREQC(param, "")) { rc = asprintf(&uri, "%s/%s", uri, param); + param_labeled = 1; + } - if (rc == -1) + if (rc == -1) { uri = NULL; + goto out; + } + if (dest_params) { + if (param_labeled == 0) { + rc = asprintf(&uri, "%s?%s", uri, dest_params); + } else { + rc = asprintf(&uri, "%s%s", uri, dest_params); + } + if (rc == -1) { + uri = NULL; + goto out; + } + } out: return uri; } +/* libvirt need private key specified must be placed in a directory owned by + root, because libvirt-cim now runs as root. So here the key would be copied, + up layer need to delete that key after migration. This method could allow + libvirt-cim borrow a non-root ssh private key, instead of using root's private + key, avoid security risk. */ +static int ssh_key_cp(const char *src, const char *dest) +{ + char *cmd = NULL; + int rc; + int ret = 0; + FILE *stream = NULL; + char buf[256]; + + rc = asprintf(&cmd, "cp -f %s %s", src, dest); + if (rc == -1) { + cmd = NULL; + ret = -1; + goto out; + } + + CU_DEBUG("excuting system cmd [%s].", cmd); + stream = popen(cmd, "r"); + if (stream == NULL) { + CU_DEBUG("Failed to open pipe to run command"); + ret = -2; + goto out; + } + usleep(10000); + + buf[255] = 0; + while (fgets(buf, sizeof(buf), stream) != NULL) { + CU_DEBUG("Exception got: %s.", buf); + ret = -3; + goto out; + } + + out: + if (stream != NULL) { + pclose(stream); + } + free(cmd); + return ret; +} + static CMPIStatus get_msd_values(const CMPIObjectPath *ref, const char *destination, const CMPIArgs *argsin, @@ -217,6 +278,14 @@ static CMPIStatus get_msd_values(const CMPIObjectPath *ref, CMPIInstance *msd; uint16_t uri_type; char *uri = NULL; + const char *dest_params = NULL; + const char *ssh_hack_src = NULL; + const char *ssh_hack_dest = NULL; + int ret; + + cu_get_str_arg(argsin, "DestinationHostParams", &dest_params); + cu_get_str_arg(argsin, "SSH_Key_Src", &ssh_hack_src); + cu_get_str_arg(argsin, "SSH_Key_Dest", &ssh_hack_dest); s = get_msd(ref, argsin, &msd); if (s.rc != CMPI_RC_OK) @@ -230,7 +299,7 @@ static CMPIStatus get_msd_values(const CMPIObjectPath *ref, if (s.rc != CMPI_RC_OK) goto out; - uri = dest_uri(CLASSNAME(ref), destination, uri_type); + uri = dest_uri(CLASSNAME(ref), destination, dest_params, uri_type); if (uri == NULL) { cu_statusf(_BROKER, &s, CMPI_RC_ERR_FAILED, @@ -238,6 +307,19 @@ static CMPIStatus get_msd_values(const CMPIObjectPath *ref, goto out; } + if ((ssh_hack_src) && (ssh_hack_dest)) { + CU_DEBUG("hacking ssh keys src %s, dest %s.", + ssh_hack_src, ssh_hack_dest); + ret = ssh_key_cp(ssh_hack_src, ssh_hack_dest); + if (ret < 0) { + cu_statusf(_BROKER, &s, + CMPI_RC_ERR_FAILED, + "Failed to copy ssh key files"); + goto out; + } + } + + CU_DEBUG("Migrate tring to connect remote host with uri %s.", uri); *conn = virConnectOpen(uri); if (*conn == NULL) { CU_DEBUG("Failed to connect to remote host (%s)", uri); @@ -1537,7 +1619,7 @@ static CMPIStatus migrate_vs_host(CMPIMethodMI *self, const char *dhost = NULL; CMPIObjectPath *system; const char *name = NULL; - + cu_get_str_arg(argsin, "DestinationHost", &dhost); cu_get_ref_arg(argsin, "ComputerSystem", &system); @@ -1608,6 +1690,9 @@ static struct method_handler vsimth = { .handler = vs_migratable_host, .args = {{"ComputerSystem", CMPI_ref, false}, {"DestinationHost", CMPI_string, false}, + {"DestinationHostParams", CMPI_string, true}, + {"SSH_Key_Src", CMPI_string, true}, + {"SSH_Key_Dest", CMPI_string, true}, {"MigrationSettingData", CMPI_instance, true}, {"NewSystemSettingData", CMPI_instance, true}, {"NewResourceSettingData", CMPI_instanceA, true}, @@ -1632,6 +1717,9 @@ static struct method_handler mvsth = { .handler = migrate_vs_host, .args = {{"ComputerSystem", CMPI_ref, false}, {"DestinationHost", CMPI_string, false}, + {"DestinationHostParams", CMPI_string, true}, + {"SSH_Key_Src", CMPI_string, true}, + {"SSH_Key_Dest", CMPI_string, true}, {"MigrationSettingData", CMPI_instance, true}, {"NewSystemSettingData", CMPI_instance, true}, {"NewResourceSettingData", CMPI_instanceA, true}, -- 1.7.1

1 0

[PATCH] fix id parsing with white space
by Wenchao Xia 15 Sep '12

15 Sep '12

When device id string contains white space, parse is not correct. This patch fix it Signed-off-by: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> --- libxkutil/device_parsing.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libxkutil/device_parsing.c b/libxkutil/device_parsing.c index 5393290..ceb4552 100644 --- a/libxkutil/device_parsing.c +++ b/libxkutil/device_parsing.c @@ -1033,7 +1033,7 @@ int parse_fq_devid(const char *devid, char **host, char **device) { int ret; - ret = sscanf(devid, "%a[^/]/%as", host, device); + ret = sscanf(devid, "%a[^/]/%a[^\n]", host, device); if (ret != 2) { free(*host); free(*device); -- 1.7.1

4 3

[PATCH] provide a hack to borrow non-root ssh keys in migration
by Wenchao Xia 15 Sep '12

15 Sep '12

This patch allow libvirt-cim to use non-root's ssh key, avoid using root's key to avoid exposing root's ssh login. Because libvirt-cim runs in root mode so it is hard to satisfy some server security rules especially about root's ssh key exposing. This is a walk around to improve it. Signed-off-by: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> --- src/Virt_VSMigrationService.c | 96 +++++++++++++++++++++++++++++++++++++++-- 1 files changed, 92 insertions(+), 4 deletions(-) diff --git a/src/Virt_VSMigrationService.c b/src/Virt_VSMigrationService.c index 76e3d25..55442ee 100644 --- a/src/Virt_VSMigrationService.c +++ b/src/Virt_VSMigrationService.c @@ -150,6 +150,7 @@ static CMPIStatus get_migration_uri(CMPIInstance *msd, static char *dest_uri(const char *cn, const char *dest, + const char *dest_params, uint16_t transport) { const char *prefix; @@ -157,6 +158,7 @@ static char *dest_uri(const char *cn, const char *param = ""; char *uri = NULL; int rc; + int param_labeled = 0; if (STARTS_WITH(cn, "Xen")) prefix = "xen"; @@ -197,16 +199,75 @@ static char *dest_uri(const char *cn, goto out; } - if (!STREQC(param, "")) + if (!STREQC(param, "")) { rc = asprintf(&uri, "%s/%s", uri, param); + param_labeled = 1; + } - if (rc == -1) + if (rc == -1) { uri = NULL; + goto out; + } + if (dest_params) { + if (param_labeled == 0) { + rc = asprintf(&uri, "%s?%s", uri, dest_params); + } else { + rc = asprintf(&uri, "%s%s", uri, dest_params); + } + if (rc == -1) { + uri = NULL; + goto out; + } + } out: return uri; } +/* libvirt need private key specified must be placed in a directory owned by + root, because libvirt-cim now runs as root. So here the key would be copied, + up layer need to delete that key after migration. This method could allow + libvirt-cim borrow a non-root ssh private key, instead of using root's private + key, avoid security risk. */ +static int ssh_key_cp(const char *src, const char *dest) +{ + char *cmd = NULL; + int rc; + int ret = 0; + FILE *stream = NULL; + char buf[256]; + + rc = asprintf(&cmd, "cp -f %s %s", src, dest); + if (rc == -1) { + cmd = NULL; + ret = -1; + goto out; + } + + CU_DEBUG("excuting system cmd [%s].", cmd); + stream = popen(cmd, "r"); + if (stream == NULL) { + CU_DEBUG("Failed to open pipe to run command"); + ret = -2; + goto out; + } + usleep(10000); + + buf[255] = 0; + while (fgets(buf, sizeof(buf), stream) != NULL) { + CU_DEBUG("Exception got: %s.", buf); + ret = -3; + goto out; + } + + out: + if (stream != NULL) { + pclose(stream); + } + free(cmd); + return ret; +} + static CMPIStatus get_msd_values(const CMPIObjectPath *ref, const char *destination, const CMPIArgs *argsin, @@ -217,6 +278,14 @@ static CMPIStatus get_msd_values(const CMPIObjectPath *ref, CMPIInstance *msd; uint16_t uri_type; char *uri = NULL; + const char *dest_params = NULL; + const char *ssh_hack_src = NULL; + const char *ssh_hack_dest = NULL; + int ret; + + cu_get_str_arg(argsin, "DestinationHostParams", &dest_params); + cu_get_str_arg(argsin, "SSH_Key_Src", &ssh_hack_src); + cu_get_str_arg(argsin, "SSH_Key_Dest", &ssh_hack_dest); s = get_msd(ref, argsin, &msd); if (s.rc != CMPI_RC_OK) @@ -230,7 +299,7 @@ static CMPIStatus get_msd_values(const CMPIObjectPath *ref, if (s.rc != CMPI_RC_OK) goto out; - uri = dest_uri(CLASSNAME(ref), destination, uri_type); + uri = dest_uri(CLASSNAME(ref), destination, dest_params, uri_type); if (uri == NULL) { cu_statusf(_BROKER, &s, CMPI_RC_ERR_FAILED, @@ -238,6 +307,19 @@ static CMPIStatus get_msd_values(const CMPIObjectPath *ref, goto out; } + if ((ssh_hack_src) && (ssh_hack_dest)) { + CU_DEBUG("hacking ssh keys src %s, dest %s.", + ssh_hack_src, ssh_hack_dest); + ret = ssh_key_cp(ssh_hack_src, ssh_hack_dest); + if (ret < 0) { + cu_statusf(_BROKER, &s, + CMPI_RC_ERR_FAILED, + "Failed to copy ssh key files"); + goto out; + } + } + + CU_DEBUG("Migrate tring to connect remote host with uri %s.", uri); *conn = virConnectOpen(uri); if (*conn == NULL) { CU_DEBUG("Failed to connect to remote host (%s)", uri); @@ -1537,7 +1619,7 @@ static CMPIStatus migrate_vs_host(CMPIMethodMI *self, const char *dhost = NULL; CMPIObjectPath *system; const char *name = NULL; - + cu_get_str_arg(argsin, "DestinationHost", &dhost); cu_get_ref_arg(argsin, "ComputerSystem", &system); @@ -1608,6 +1690,9 @@ static struct method_handler vsimth = { .handler = vs_migratable_host, .args = {{"ComputerSystem", CMPI_ref, false}, {"DestinationHost", CMPI_string, false}, + {"DestinationHostParams", CMPI_string, true}, + {"SSH_Key_Src", CMPI_string, true}, + {"SSH_Key_Dest", CMPI_string, true}, {"MigrationSettingData", CMPI_instance, true}, {"NewSystemSettingData", CMPI_instance, true}, {"NewResourceSettingData", CMPI_instanceA, true}, @@ -1632,6 +1717,9 @@ static struct method_handler mvsth = { .handler = migrate_vs_host, .args = {{"ComputerSystem", CMPI_ref, false}, {"DestinationHost", CMPI_string, false}, + {"DestinationHostParams", CMPI_string, true}, + {"SSH_Key_Src", CMPI_string, true}, + {"SSH_Key_Dest", CMPI_string, true}, {"MigrationSettingData", CMPI_instance, true}, {"NewSystemSettingData", CMPI_instance, true}, {"NewResourceSettingData", CMPI_instanceA, true}, -- 1.7.1

4 3

Tyrel Datwyler is out of the office.
by Tyrel Datwyler 24 Aug '12

24 Aug '12

I will be out of the office starting 08/24/2012 and will not return until 08/28/2012. During this time I will not have access to email. In the case of any urgent issues please contact my back up David Heller.

1 0

libvirt-cim dependency question and test result
by Yanbing Du 23 Aug '12

23 Aug '12

Hi, Recently i'm doing libvirt-cim testing, and there's a question about cim-server dependency. When i yum install libvirt-cim, the dependency of cim-server will install sblim-sfcb, but what we want use is tog-pegasus, so i install tog-pegasus manually after installed libvirt-cim. then test it by wbemcli: #wbemcli ein http://root:redhat@localhost/root/virt:KVM_VirtualSystemManagementService * * wbemcli: Cim: (3) CIM_ERR_INVALID_NAMESPACE: root/virt * and there's no provider module about libvirt-cim #cimprovider -l OperatingSystemModule ComputerSystemModule ProcessModule SLPProviderModule So i reinstall libvirt-cim and it works well. There are 2 bugs about the dependency problem, and all fixed. https://bugzilla.redhat.com/show_bug.cgi?id=694749 https://bugzilla.redhat.com/show_bug.cgi?id=799037 I wonder if this behavior is excepted? BTW, i run the cimtest suit and 30 tests failed. Please check the attachment for detail info. Related packages version: # rpm -q libvirt libvirt-0.10.0-0rc0.el6.x86_64 # rpm -q libvirt-cim libvirt-cim-0.6.1-3.el6.x86_64 # rpm -q qemu-kvm qemu-kvm-0.12.1.2-2.303.el6.x86_64 ================================================= Test Run Summary (Aug 14 2012): KVM on Red Hat Enterprise Linux Server release 6.3 (Santiago) with Pegasus ================================================= Distro: Red Hat Enterprise Linux Server release 6.3 (Santiago) Kernel: 2.6.32-289.el6.x86_64 libvirt: 0.10.0 Hypervisor: QEMU 0.12.1 CIMOM: Pegasus 2.11.0 Libvirt-cim revision: 1192 Libvirt-cim changeset: 0c468a8 Cimtest revision: Cimtest changeset: 93f0e6e Total test execution: Unknown ================================================= FAIL : 30 XFAIL : 2 SKIP : 14 PASS : 146 ----------------- Total : 192 ================================================= Thanks! Best Regards! Yanbing Du

3 6

[PATCH] remove script for bridge network
by Wenchao Xia 27 Jul '12

27 Jul '12

libvirt0.9.10 will report error if bridge network was defined with script. This is the fix for it, otherwise VM start would fail. Signed-off-by: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com> --- libxkutil/xmlgen.c | 9 +-------- 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/libxkutil/xmlgen.c b/libxkutil/xmlgen.c index 2dcd0d2..31619d8 100644 --- a/libxkutil/xmlgen.c +++ b/libxkutil/xmlgen.c @@ -269,18 +269,11 @@ static const char *set_net_source(xmlNodePtr nic, return NULL; } - +/* libvirt 0.9.10 report error if script is set with brdige */ static const char *bridge_net_to_xml(xmlNodePtr nic, struct net_device *dev) { - const char *script = "vif-bridge"; - xmlNodePtr tmp; const char *msg = NULL; - tmp = xmlNewChild(nic, NULL, BAD_CAST "script", NULL); - if (tmp == NULL) - return XML_ERROR; - xmlNewProp(tmp, BAD_CAST "path", BAD_CAST script); - msg = set_net_source(nic, dev, "bridge"); return msg; -- 1.7.1

2 3