August 2011 - CIM - libvirt List Archives

[PATCH] Retrun object paths for newly created filter associations
by Chip Vincent 04 Aug '11

04 Aug '11

# HG changeset patch # User Chip Vincent <cvincent(a)us.ibm.com> # Date 1312471352 14400 # Node ID 43d8048faffd40edd88ec339b7e615ff48a70b6a # Parent 5dc300d4dfd7b9741a6086e4e5b8da632bcdcd2d Retrun object paths for newly created filter associations. Fix to return the resulting new association object path at the end CreateInstance for Nested and AppliedFilterList. This is simply passing back the object path that was passed to the provider if there are no failures during the creation process. Signed-off-by: Chip Vincent <cvincent(a)us.ibm.com> diff --git a/src/Virt_AppliedFilterList.c b/src/Virt_AppliedFilterList.c --- a/src/Virt_AppliedFilterList.c +++ b/src/Virt_AppliedFilterList.c @@ -508,6 +508,7 @@ goto out; } + CMReturnObjectPath(results, reference); CU_DEBUG("CreateInstance complete"); out: diff --git a/src/Virt_NestedFilterList.c b/src/Virt_NestedFilterList.c --- a/src/Virt_NestedFilterList.c +++ b/src/Virt_NestedFilterList.c @@ -386,6 +386,7 @@ goto out; } + CMReturnObjectPath(results, reference); CU_DEBUG("CreateInstance completed"); out:

1 0

[PATCH] New entry "poolid" was not getting DUPed
by Sharad Mishra 03 Aug '11

03 Aug '11

# HG changeset patch # User Sharad Mishra <snmishra(a)us.ibm.com> # Date 1311797923 25200 # Node ID 5dc300d4dfd7b9741a6086e4e5b8da632bcdcd2d # Parent 0f42cab9c45c53cc13407b16418399ed8ed4a026 New entry "poolid" was not getting DUPed. A recent patch added support for network poolid, but missed to add DUP for it. This patch fixes the issue. Signed-off-by: Sharad Mishra <snmishra(a)us.ibm.com> diff -r 0f42cab9c45c -r 5dc300d4dfd7 libxkutil/device_parsing.c --- a/libxkutil/device_parsing.c Mon Jul 25 13:14:22 2011 -0700 +++ b/libxkutil/device_parsing.c Wed Jul 27 13:18:43 2011 -0700 @@ -775,6 +775,7 @@ DUP_FIELD(dev, _dev, dev.net.type); DUP_FIELD(dev, _dev, dev.net.source); DUP_FIELD(dev, _dev, dev.net.model); + DUP_FIELD(dev, _dev, dev.net.poolid); DUP_FIELD(dev, _dev, dev.net.device); DUP_FIELD(dev, _dev, dev.net.net_mode); DUP_FIELD(dev, _dev, dev.net.filter_ref);

3 2

[PATCH] [TEST] Reduce the length of bridge name
by Sharad Mishra 03 Aug '11

03 Aug '11

# HG changeset patch # User Sharad Mishra <snmishra(a)us.ibm.com> # Date 1311878184 25200 # Node ID 8c23ed99a218f1d1eea5c662b2fa3c211fe6d531 # Parent 3bc1a0fc5683d705c022014364cacf6d5860ba28 [TEST] Reduce the length of bridge name. Lately I have seen this (VirtualSystemManagementService - 06_addresource.py) test fails with following error - # virsh -c qemu:///system net-create /home/net.xml error: Failed to create network from /home/net.xml error: cannot create dummy tap device 'testbridge55-nic' to set mac address on bridge 'testbridge55': Invalid argument Reducing the size of bridge name fixed this issue. I looked on the net but could not find more info on when this behaviour changed in libvirt. Signed-off-by: Sharad Mishra <snmishra(a)us.ibm.com> diff -r 3bc1a0fc5683 -r 8c23ed99a218 suites/libvirt-cim/lib/XenKvmLib/const.py --- a/suites/libvirt-cim/lib/XenKvmLib/const.py Tue Jul 12 16:02:27 2011 -0300 +++ b/suites/libvirt-cim/lib/XenKvmLib/const.py Thu Jul 28 11:36:24 2011 -0700 @@ -58,7 +58,7 @@ # vxml.NetXML -default_bridge_name = 'testbridge' +default_bridge_name = 'testbr' default_network_name = 'cimtest-networkpool' default_net_type = 'network'

2 1

[PATCH] [TEST] Update RASDIndication test to use "vnc" instead of "graphics"
by Sharad Mishra 03 Aug '11

03 Aug '11

# HG changeset patch # User Sharad Mishra <snmishra(a)us.ibm.com> # Date 1311864875 25200 # Node ID 3c23103a2ca19d6cf66d84a7d87f4dd93e2d609f # Parent 3bc1a0fc5683d705c022014364cacf6d5860ba28 [TEST] Update RASDIndication test to use "vnc" instead of "graphics" Graphics RASDs now include support for serial/consoel devices, which includes support for unqiue InstanceIDs. This patch updates the test to look for <vm_name>/vnc where is used to just look for graphics Signed-off-by: Sharad Mishra <snmishra(a)us.ibm.com> diff -r 3bc1a0fc5683 -r 3c23103a2ca1 suites/libvirt-cim/cimtest/RASDIndications/02_guest_add_mod_rem_rasd_ind.py --- a/suites/libvirt-cim/cimtest/RASDIndications/02_guest_add_mod_rem_rasd_ind.py Tue Jul 12 16:02:27 2011 -0300 +++ b/suites/libvirt-cim/cimtest/RASDIndications/02_guest_add_mod_rem_rasd_ind.py Thu Jul 28 07:54:35 2011 -0700 @@ -108,7 +108,7 @@ elif ind_name == 'delete': cn = 'GraphicsResourceAllocationSettingData' - inst_id = '%s/%s' % (test_dom, "graphics") + inst_id = '%s/%s' % (test_dom, "vnc") classname = get_typed_class(virt, cn) nrasd = get_rasd_rec(virt, cn, s_sysname, inst_id)

3 2