March 2008 - CIM - libvirt List Archives

[PATCH] Make migration return proper value for "Job Started"
by Dan Smith 12 Mar '08

12 Mar '08

# HG changeset patch # User Dan Smith <danms(a)us.ibm.com> # Date 1205331569 25200 # Node ID 82b18a386bda9c09e6f4f41a0b3acbeeba7f0ea9 # Parent b739fc9b13320e07a39f3932396c8411c2d4ad75 Make migration return proper value for "Job Started" Signed-off-by: Dan Smith <danms(a)us.ibm.com> diff -r b739fc9b1332 -r 82b18a386bda src/Virt_VSMigrationService.c --- a/src/Virt_VSMigrationService.c Tue Mar 11 13:28:04 2008 -0700 +++ b/src/Virt_VSMigrationService.c Wed Mar 12 07:19:29 2008 -0700 @@ -927,7 +927,7 @@ static CMPIStatus migrate_do(const CMPIO thread = _BROKER->xft->newThread((void*)migration_thread, job, 0); - retcode = 0; + retcode = 4096; /* Job Started */ out: CMReturnData(results, (CMPIValue *)&retcode, CMPI_uint32);

2 1

[PATCH 0 of 2] Use libvirt's storage management
by Dan Smith 12 Mar '08

12 Mar '08

Subject says it all. Some reasonable testing of this to make sure it still: (a) works as it did before on <=0.4.0, and (b) works with the storage stuff if you have 0.4.1

3 5

[PATCH 0 of 3] (#2) [RFC] Add external migration checks
by Dan Smith 12 Mar '08

12 Mar '08

Changes to reflect change to base VSMigrationService MSD change

4 9

[PATCH] Fix indication_tester's filter deletion issue
by Jay Gagnon 12 Mar '08

12 Mar '08

# HG changeset patch # User Jay Gagnon <grendel(a)linux.vnet.ibm.com> # Date 1205167743 14400 # Node ID 4b34c7474e59f939200cdfeaa7d3414cfc6f7c13 # Parent d93bb8c00423a88f1c9475a8e6076b1945e1dd01 Fix indication_tester's filter deletion issue A while ago we discovered that giving the same name to various tests in indication_tester doesn't work, even when the first test's filter, handler, and subscription should have been deleted once it was done running. It turns out that indication_tester wasn't deleting the filter, due to some bad xml. This fixes the xml and eliminates the need to use the -n switch unless you want multiple simultaneous tests. Signed-off-by: Jay Gagnon <grendel(a)linux.vnet.ibm.com> diff -r d93bb8c00423 -r 4b34c7474e59 tools/indication_tester.py --- a/tools/indication_tester.py Mon Mar 03 06:48:26 2008 -0800 +++ b/tools/indication_tester.py Mon Mar 10 12:49:03 2008 -0400 @@ -181,7 +181,7 @@ def delete_inst_xml(name, type, sysname) <NAMESPACE NAME="PG_InterOp"/> </LOCALNAMESPACEPATH> <IPARAMVALUE NAME="InstanceName"> - <INSTANCENAME CLASSNAME="CIM_Indication%sCIMXML"> + <INSTANCENAME CLASSNAME="CIM_Indication%s"> <KEYBINDING NAME="SystemCreationClassName"> <KEYVALUE>CIM_ComputerSystem</KEYVALUE> </KEYBINDING> @@ -189,7 +189,7 @@ def delete_inst_xml(name, type, sysname) <KEYVALUE>%s</KEYVALUE> </KEYBINDING> <KEYBINDING NAME="CreationClassName"> - <KEYVALUE>CIM_Indication%sCIMXML</KEYVALUE> + <KEYVALUE>CIM_Indication%s</KEYVALUE> </KEYBINDING> <KEYBINDING NAME="Name"> <KEYVALUE>%s%s</KEYVALUE>

3 4

[PATCH 0 of 2] Add MSD support to CheckVSIsMigratable()
by Dan Smith 12 Mar '08

12 Mar '08

This adds MSD support to the check functions, as well as adding a check to make sure the domain in question actually exists on the source system.

3 7

Migration check patches
by Stefan Berger 12 Mar '08

12 Mar '08

Hello Dan, thanks for providing the external migration check patches. They were very helpful and work well. Thanks Stefan

2 1

[PATCH] Fix cu_statusf() call in RASD
by Kaitlin Rupert 12 Mar '08

12 Mar '08

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1205258941 25200 # Node ID 4f17d756b6c3551d1ae0a3aee1939a5ad6963c67 # Parent 1429af47e9413d5f0bcf51e5a58988177bc32bbf Fix cu_statusf() call in RASD. It's not easy to tell from the diff, but get_rasd_by_ref() takes a const CMPIBroker *broker argument. So when we fail, we need to use the broker, not the _BROKER that is local to the provider. Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r 1429af47e941 -r 4f17d756b6c3 src/Virt_RASD.c --- a/src/Virt_RASD.c Tue Mar 11 10:18:05 2008 -0700 +++ b/src/Virt_RASD.c Tue Mar 11 11:09:01 2008 -0700 @@ -433,7 +433,7 @@ CMPIStatus get_rasd_by_ref(const CMPIBro uint16_t type; if (cu_get_str_path(reference, "InstanceID", &name) != CMPI_RC_OK) { - cu_statusf(_BROKER, &s, + cu_statusf(broker, &s, CMPI_RC_ERR_FAILED, "Missing InstanceID"); goto out;

2 1

[PATCH 0 of 3] (#2) Add MSD support to CheckVSIsMigratable()
by Dan Smith 11 Mar '08

11 Mar '08

Changes per Kaitlin's *demand* that the MSD value functions be consolidated

2 5

[PATCH] [CU] Add cu_get_array_prop()
by Dan Smith 10 Mar '08

10 Mar '08

# HG changeset patch # User Dan Smith <danms(a)us.ibm.com> # Date 1205173351 25200 # Node ID e7d4d1f30118bbc0e484fd4f4fd80747b63435d5 # Parent d93bb8c00423a88f1c9475a8e6076b1945e1dd01 [CU] Add cu_get_array_prop() Signed-off-by: Dan Smith <danms(a)us.ibm.com> diff -r d93bb8c00423 -r e7d4d1f30118 args_util.c --- a/args_util.c Mon Mar 03 06:48:26 2008 -0800 +++ b/args_util.c Mon Mar 10 11:22:31 2008 -0700 @@ -192,6 +192,27 @@ CMPIrc cu_get_u16_arg(const CMPIArgs *ar pv = CMGetProperty(i, p, s); \ if ((s)->rc != CMPI_RC_OK || CMIsNullValue(pv)) \ return CMPI_RC_ERR_NO_SUCH_PROPERTY; + +CMPIrc cu_get_array_prop(const CMPIInstance *inst, + const char *prop, + CMPIArray **array) +{ + CMPIData value; + CMPIStatus s; + + REQUIRE_PROPERTY_DEFINED(inst, prop, value, &s); + + value = CMGetProperty(inst, prop, &s); + if ((s.rc != CMPI_RC_OK) || CMIsNullValue(value)) + return s.rc; + + if (!CMIsArray(value) || CMIsNullObject(value.value.array)) + return CMPI_RC_ERR_TYPE_MISMATCH; + + *array = value.value.array; + + return CMPI_RC_OK; +} CMPIrc cu_get_str_prop(const CMPIInstance *inst, const char *prop, diff -r d93bb8c00423 -r e7d4d1f30118 libcmpiutil.h --- a/libcmpiutil.h Mon Mar 03 06:48:26 2008 -0800 +++ b/libcmpiutil.h Mon Mar 10 11:22:31 2008 -0700 @@ -211,6 +211,23 @@ bool cu_return_instance_name(const CMPIR */ unsigned int cu_return_instance_names(const CMPIResult *results, const struct inst_list *list); + +/** + * Get an array property of an instance + * + * @param inst The instance + * @param prop The property name + * @param target A pointer to a CMPIarray that will be set + * if successful + * @returns + * - CMPI_RC_OK on success, + * - CMPI_RC_ERR_NO_SUCH_PROPERTY if prop is not present, + * - CMPI_RC_ERR_TYPE_MISMATCH if prop is not an array, + * - CMPI_RC_ERROR otherwise + */ +CMPIrc cu_get_array_prop(const CMPIInstance *inst, + const char *prop, + CMPIArray **array); /** * Get a string property of an instance

2 1

[PATCH] Add iteration functionality for CIM_RES_TYPE_ALL
by Heidi Eckhart 10 Mar '08

10 Mar '08

# HG changeset patch # User Heidi Eckhart <heidieck(a)linux.vnet.ibm.com> # Date 1205156447 -3600 # Node ID 1325969aff7f736a9b17b4cd259f9608890d11bf # Parent f82efd4364f1f27c1ec7ceaedafc281379007b38 Add iteration functionality for CIM_RES_TYPE_ALL Signed-off-by: Heidi Eckhart <heidieck(a)linux.vnet.ibm.com> diff -r f82efd4364f1 -r 1325969aff7f src/Virt_Device.c --- a/src/Virt_Device.c Fri Mar 07 15:24:38 2008 -0800 +++ b/src/Virt_Device.c Mon Mar 10 14:40:47 2008 +0100 @@ -322,28 +322,15 @@ static CMPIStatus _enum_devices(const CM struct inst_list *list) { CMPIStatus s; + int i; if (type == CIM_RES_TYPE_ALL) { - s = _get_devices(broker, - reference, - dom, - CIM_RES_TYPE_PROC, - list); - s = _get_devices(broker, - reference, - dom, - CIM_RES_TYPE_NET, - list); - s = _get_devices(broker, - reference, - dom, - CIM_RES_TYPE_MEM, - list); - s = _get_devices(broker, - reference, - dom, - CIM_RES_TYPE_DISK, - list); + for (i=0; i<CIM_RES_TYPE_COUNT; i++) + s = _get_devices(broker, + reference, + dom, + cim_res_types[i], + list); } else s = _get_devices(broker, diff -r f82efd4364f1 -r 1325969aff7f src/Virt_RASD.c --- a/src/Virt_RASD.c Fri Mar 07 15:24:38 2008 -0800 +++ b/src/Virt_RASD.c Mon Mar 10 14:40:47 2008 +0100 @@ -562,32 +562,16 @@ static CMPIStatus _enum_rasds(const CMPI struct inst_list *list) { CMPIStatus s; + int i; if (type == CIM_RES_TYPE_ALL) { - s = _get_rasds(broker, - reference, - dom, - CIM_RES_TYPE_PROC, - properties, - list); - s = _get_rasds(broker, - reference, - dom, - CIM_RES_TYPE_MEM, - properties, - list); - s = _get_rasds(broker, - reference, - dom, - CIM_RES_TYPE_NET, - properties, - list); - s = _get_rasds(broker, - reference, - dom, - CIM_RES_TYPE_DISK, - properties, - list); + for (i=0; i<CIM_RES_TYPE_COUNT; i++) + s = _get_rasds(broker, + reference, + dom, + cim_res_types[i], + properties, + list); } else s = _get_rasds(broker, diff -r f82efd4364f1 -r 1325969aff7f src/svpc_types.h --- a/src/svpc_types.h Fri Mar 07 15:24:38 2008 -0800 +++ b/src/svpc_types.h Mon Mar 10 14:40:47 2008 +0100 @@ -30,6 +30,14 @@ #define CIM_RES_TYPE_EMU 1 #define CIM_RES_TYPE_GRAPHICS 24 #define CIM_RES_TYPE_UNKNOWN 1000 + +#define CIM_RES_TYPE_COUNT 4 +const static int cim_res_types[CIM_RES_TYPE_COUNT] = + {CIM_RES_TYPE_NET, + CIM_RES_TYPE_DISK, + CIM_RES_TYPE_MEM, + CIM_RES_TYPE_PROC, + }; #define CIM_VSSD_RECOVERY_NONE 2 #define CIM_VSSD_RECOVERY_RESTART 3

2 1

[PATCH] move VIRT_DEV_foo types to CIM_RES_TYPE_foo
by Heidi Eckhart 10 Mar '08

10 Mar '08

# HG changeset patch # User Heidi Eckhart <heidieck(a)linux.vnet.ibm.com> # Date 1205154179 -3600 # Node ID 581efd4f29eb6a9aa321cf54dbcf6f35f59055f9 # Parent 1aaf26015bb83a1b2433073c2ec5886cf828d9e6 move VIRT_DEV_foo types to CIM_RES_TYPE_foo Signed-off-by: Heidi Eckhart <heidieck(a)linux.vnet.ibm.com> diff -r 1aaf26015bb8 -r 581efd4f29eb libxkutil/device_parsing.c --- a/libxkutil/device_parsing.c Mon Mar 10 13:09:14 2008 +0100 +++ b/libxkutil/device_parsing.c Mon Mar 10 14:02:59 2008 +0100 @@ -81,13 +81,13 @@ void cleanup_virt_device(struct virt_dev if (dev == NULL) return; /* free()-like semantics */ - if (dev->type == VIRT_DEV_DISK) + if (dev->type == CIM_RES_TYPE_DISK) cleanup_disk_device(&dev->dev.disk); - else if (dev->type == VIRT_DEV_NET) + else if (dev->type == CIM_RES_TYPE_NET) cleanup_net_device(&dev->dev.net) - else if (dev->type == VIRT_DEV_EMU) + else if (dev->type == CIM_RES_TYPE_EMU) cleanup_emu_device(&dev->dev.emu); - else if (dev->type == VIRT_DEV_GRAPHICS) + else if (dev->type == CIM_RES_TYPE_GRAPHICS) cleanup_graphics_device(&dev->dev.graphics); free(dev->id); @@ -181,7 +181,7 @@ static int parse_disk_device(xmlNode *dn if ((ddev->source == NULL) || (ddev->virtual_dev == NULL)) goto err; - vdev->type = VIRT_DEV_DISK; + vdev->type = CIM_RES_TYPE_DISK; vdev->id = strdup(ddev->virtual_dev); *vdevs = vdev; @@ -248,7 +248,7 @@ static int parse_net_device(xmlNode *ino } } - vdev->type = VIRT_DEV_NET; + vdev->type = CIM_RES_TYPE_NET; vdev->id = strdup(ndev->mac); *vdevs = vdev; @@ -286,7 +286,7 @@ static int parse_vcpu_device(xmlNode *no cdev->number = i; - vdev->type = VIRT_DEV_VCPU; + vdev->type = CIM_RES_TYPE_PROC; if (asprintf(&vdev->id, "%i", i) == -1) vdev->id = NULL; } @@ -315,7 +315,7 @@ static int parse_emu_device(xmlNode *nod if (edev->path != NULL) goto err; - vdev->type = VIRT_DEV_EMU; + vdev->type = CIM_RES_TYPE_EMU; *vdevs = vdev; @@ -376,7 +376,7 @@ static int parse_graphics_device(xmlNode if ((gdev->type == NULL) || (gdev->port == NULL)) goto err; - vdev->type = VIRT_DEV_GRAPHICS; + vdev->type = CIM_RES_TYPE_GRAPHICS; *vdevs = vdev; @@ -411,17 +411,17 @@ static int do_parse(xmlNodeSet *nsv, int int (*do_real_parse)(xmlNode *, struct virt_device **) = NULL; /* point to correct parser function according to type */ - if (type == VIRT_DEV_NET) + if (type == CIM_RES_TYPE_NET) do_real_parse = &parse_net_device; - else if (type == VIRT_DEV_DISK) + else if (type == CIM_RES_TYPE_DISK) do_real_parse = &parse_disk_device; - else if (type == VIRT_DEV_VCPU) + else if (type == CIM_RES_TYPE_PROC) do_real_parse = parse_vcpu_device; - else if (type == VIRT_DEV_EMU) + else if (type == CIM_RES_TYPE_EMU) do_real_parse = parse_emu_device; - else if (type == VIRT_DEV_MEM) + else if (type == CIM_RES_TYPE_MEM) do_real_parse = parse_mem_device; - else if (type == VIRT_DEV_GRAPHICS) + else if (type == CIM_RES_TYPE_GRAPHICS) do_real_parse = parse_graphics_device; else goto out; @@ -479,17 +479,17 @@ static int parse_devices(const char *xml xmlXPathObject *xpathObj; xmlChar *xpathstr; - if (type == VIRT_DEV_NET) + if (type == CIM_RES_TYPE_NET) xpathstr = NET_XPATH; - else if (type == VIRT_DEV_DISK) + else if (type == CIM_RES_TYPE_DISK) xpathstr = DISK_XPATH; - else if (type == VIRT_DEV_VCPU) + else if (type == CIM_RES_TYPE_PROC) xpathstr = VCPU_XPATH; - else if (type == VIRT_DEV_EMU) + else if (type == CIM_RES_TYPE_EMU) xpathstr = EMU_XPATH; - else if (type == VIRT_DEV_MEM) + else if (type == CIM_RES_TYPE_MEM) xpathstr = MEM_XPATH; - else if (type == VIRT_DEV_GRAPHICS) + else if (type == CIM_RES_TYPE_GRAPHICS) xpathstr = GRAPHICS_XPATH; else goto err1; @@ -535,24 +535,24 @@ struct virt_device *virt_device_dup(stru dev->type = _dev->type; dev->id = strdup(_dev->id); - if (dev->type == VIRT_DEV_NET) { + if (dev->type == CIM_RES_TYPE_NET) { DUP_FIELD(dev, _dev, dev.net.mac); DUP_FIELD(dev, _dev, dev.net.type); DUP_FIELD(dev, _dev, dev.net.source); - } else if (dev->type == VIRT_DEV_DISK) { + } else if (dev->type == CIM_RES_TYPE_DISK) { DUP_FIELD(dev, _dev, dev.disk.type); DUP_FIELD(dev, _dev, dev.disk.device); DUP_FIELD(dev, _dev, dev.disk.driver); DUP_FIELD(dev, _dev, dev.disk.source); DUP_FIELD(dev, _dev, dev.disk.virtual_dev); - } else if (dev->type == VIRT_DEV_MEM) { + } else if (dev->type == CIM_RES_TYPE_MEM) { dev->dev.mem.size = _dev->dev.mem.size; dev->dev.mem.maxsize = _dev->dev.mem.maxsize; - } else if (dev->type == VIRT_DEV_VCPU) { + } else if (dev->type == CIM_RES_TYPE_PROC) { dev->dev.vcpu.number = _dev->dev.vcpu.number; - } else if (dev->type == VIRT_DEV_EMU) { + } else if (dev->type == CIM_RES_TYPE_EMU) { DUP_FIELD(dev, _dev, dev.emu.path); - } else if (dev->type == VIRT_DEV_GRAPHICS) { + } else if (dev->type == CIM_RES_TYPE_GRAPHICS) { DUP_FIELD(dev, _dev, dev.graphics.type); DUP_FIELD(dev, _dev, dev.graphics.port); } @@ -566,7 +566,7 @@ static int _get_mem_device(const char *x struct virt_device *mdev = NULL; int ret; - ret = parse_devices(xml, &mdevs, VIRT_DEV_MEM); + ret = parse_devices(xml, &mdevs, CIM_RES_TYPE_MEM); if (ret <= 0) return ret; @@ -592,7 +592,7 @@ static int _get_mem_device(const char *x mdev->dev.mem.maxsize = mdev->dev.mem.size; } - mdev->type = VIRT_DEV_MEM; + mdev->type = CIM_RES_TYPE_MEM; mdev->id = strdup("mem"); *list = mdev; @@ -610,7 +610,7 @@ int get_devices(virDomainPtr dom, struct if (xml == NULL) return 0; - if (type == VIRT_DEV_MEM) + if (type == CIM_RES_TYPE_MEM) ret = _get_mem_device(xml, list); else ret = parse_devices(xml, list, type); @@ -775,19 +775,19 @@ int get_dominfo_from_xml(const char *xml if (ret == 0) goto err; - parse_devices(xml, &(*dominfo)->dev_emu, VIRT_DEV_EMU); - parse_devices(xml, &(*dominfo)->dev_graphics, VIRT_DEV_GRAPHICS); + parse_devices(xml, &(*dominfo)->dev_emu, CIM_RES_TYPE_EMU); + parse_devices(xml, &(*dominfo)->dev_graphics, CIM_RES_TYPE_GRAPHICS); (*dominfo)->dev_mem_ct = _get_mem_device(xml, &(*dominfo)->dev_mem); (*dominfo)->dev_net_ct = parse_devices(xml, &(*dominfo)->dev_net, - VIRT_DEV_NET); + CIM_RES_TYPE_NET); (*dominfo)->dev_disk_ct = parse_devices(xml, &(*dominfo)->dev_disk, - VIRT_DEV_DISK); + CIM_RES_TYPE_DISK); (*dominfo)->dev_vcpu_ct = parse_devices(xml, &(*dominfo)->dev_vcpu, - VIRT_DEV_VCPU); + CIM_RES_TYPE_PROC); return ret; @@ -933,10 +933,10 @@ static int change_vcpus(virDomainPtr dom int attach_device(virDomainPtr dom, struct virt_device *dev) { - if ((dev->type == VIRT_DEV_NET) || - (dev->type == VIRT_DEV_DISK)) + if ((dev->type == CIM_RES_TYPE_NET) || + (dev->type == CIM_RES_TYPE_DISK)) return _change_device(dom, dev, true); - else if (dev->type == VIRT_DEV_VCPU) + else if (dev->type == CIM_RES_TYPE_PROC) return change_vcpus(dom, 1); CU_DEBUG("Unhandled device type %i", dev->type); @@ -946,10 +946,10 @@ int attach_device(virDomainPtr dom, stru int detach_device(virDomainPtr dom, struct virt_device *dev) { - if ((dev->type == VIRT_DEV_NET) || - (dev->type == VIRT_DEV_DISK)) + if ((dev->type == CIM_RES_TYPE_NET) || + (dev->type == CIM_RES_TYPE_DISK)) return _change_device(dom, dev, false); - else if (dev->type == VIRT_DEV_VCPU) + else if (dev->type == CIM_RES_TYPE_PROC) return change_vcpus(dom, -1); CU_DEBUG("Unhandled device type %i", dev->type); @@ -959,7 +959,7 @@ int detach_device(virDomainPtr dom, stru int change_device(virDomainPtr dom, struct virt_device *dev) { - if (dev->type == VIRT_DEV_MEM) + if (dev->type == CIM_RES_TYPE_MEM) return change_memory(dom, dev); CU_DEBUG("Unhandled device type %i", dev->type); diff -r 1aaf26015bb8 -r 581efd4f29eb libxkutil/device_parsing.h --- a/libxkutil/device_parsing.h Mon Mar 10 13:09:14 2008 +0100 +++ b/libxkutil/device_parsing.h Mon Mar 10 14:02:59 2008 +0100 @@ -63,15 +63,7 @@ struct graphics_device { }; struct virt_device { - enum { - VIRT_DEV_NET = CIM_RES_TYPE_NET, - VIRT_DEV_DISK = CIM_RES_TYPE_DISK, - VIRT_DEV_MEM = CIM_RES_TYPE_MEM, - VIRT_DEV_VCPU = CIM_RES_TYPE_PROC, - VIRT_DEV_UNKNOWN = CIM_RES_TYPE_UNKNOWN, - VIRT_DEV_EMU, - VIRT_DEV_GRAPHICS, - } type; + uint16_t type; union { struct disk_device disk; struct net_device net; diff -r 1aaf26015bb8 -r 581efd4f29eb libxkutil/xmlgen.c --- a/libxkutil/xmlgen.c Mon Mar 10 13:09:14 2008 +0100 +++ b/libxkutil/xmlgen.c Mon Mar 10 14:02:59 2008 +0100 @@ -322,10 +322,10 @@ static bool concat_devxml(char **xml, int i; for (i = 0; i < count; i++) { - /* Deleted devices are marked as VIRT_DEV_UNKNOWN + /* Deleted devices are marked as CIM_RES_TYPE_UNKNOWN * and should be skipped */ - if (list[i].type != VIRT_DEV_UNKNOWN) + if (list[i].type != CIM_RES_TYPE_UNKNOWN) func(&_xml, &list[i]); } @@ -342,22 +342,22 @@ char *device_to_xml(struct virt_device * bool (*func)(char **, struct virt_device *); switch (type) { - case VIRT_DEV_DISK: + case CIM_RES_TYPE_DISK: func = disk_to_xml; break; - case VIRT_DEV_VCPU: + case CIM_RES_TYPE_PROC: func = vcpu_to_xml; break; - case VIRT_DEV_NET: + case CIM_RES_TYPE_NET: func = net_to_xml; break; - case VIRT_DEV_MEM: + case CIM_RES_TYPE_MEM: func = mem_to_xml; break; - case VIRT_DEV_EMU: + case CIM_RES_TYPE_EMU: func = emu_to_xml; break; - case VIRT_DEV_GRAPHICS: + case CIM_RES_TYPE_GRAPHICS: func = graphics_to_xml; break; default: diff -r 1aaf26015bb8 -r 581efd4f29eb src/svpc_types.h --- a/src/svpc_types.h Mon Mar 10 13:09:14 2008 +0100 +++ b/src/svpc_types.h Mon Mar 10 14:02:59 2008 +0100 @@ -27,6 +27,8 @@ #define CIM_RES_TYPE_MEM 4 #define CIM_RES_TYPE_NET 10 #define CIM_RES_TYPE_DISK 17 +#define CIM_RES_TYPE_EMU 1 +#define CIM_RES_TYPE_GRAPHICS 24 #define CIM_RES_TYPE_UNKNOWN 1000 #define CIM_VSSD_RECOVERY_NONE 2

2 1

[PATCH] Fix a bug in MSD schema
by Kaitlin Rupert 10 Mar '08

10 Mar '08

# HG changeset patch # User Kaitlin Rupert <karupert(a)us.ibm.com> # Date 1204932278 28800 # Node ID e7c2e8fca9d4dac6477e1c3aafc36bd68e7fca1f # Parent 79a937040287f70b36e35e2a0c397894d6473ac5 Fix a bug in MSD schema. The last patach for the VSMigrationSettingData introduced a bug. Pegasus failed to clean up my repository properly when the previous patchset was tested. Signed-off-by: Kaitlin Rupert <karupert(a)us.ibm.com> diff -r 79a937040287 -r e7c2e8fca9d4 schema/VSMigrationSettingData.mof --- a/schema/VSMigrationSettingData.mof Fri Mar 07 14:57:35 2008 -0800 +++ b/schema/VSMigrationSettingData.mof Fri Mar 07 15:24:38 2008 -0800 @@ -8,16 +8,14 @@ class CIM_VirtualSystemMigrationSettingD [Provider("cmpi::Virt_VSMigrationSettingData")] class Xen_VirtualSystemMigrationSettingData : CIM_VirtualSystemMigrationSettingData { - [ Description( - ValueMap {"0","1","2","3","4","5","6"}, - Values { "Unknown", "Other", "SSH", "TLS", "TLS Strict", "TCP", "UNIX" }] + [ ValueMap {"0","1","2","3","4","5","6"}, + Values { "Unknown", "Other", "SSH", "TLS", "TLS Strict", "TCP", "UNIX" }] uint16 TransportType; }; [Provider("cmpi::Virt_VSMigrationSettingData")] class KVM_VirtualSystemMigrationSettingData : CIM_VirtualSystemMigrationSettingData { - [ Description( - ValueMap {"0","1","2","3","4","5","6"}, - Values { "Unknown", "Other", "SSH", "TLS", "TLS Strict", "TCP", "UNIX" }] + [ ValueMap {"0","1","2","3","4","5","6"}, + Values { "Unknown", "Other", "SSH", "TLS", "TLS Strict", "TCP", "UNIX" }] uint16 TransportType; };

2 1

[PATCH 0 of 3] #3 - Renamed device function for constistency with other providers
by Heidi Eckhart 10 Mar '08

10 Mar '08

Renamed the device_type_by_classname() to res_type_by_device_classname() for consistency with other interfaces. Diff to patch set 1: - moved adoption of new resource types CIM_RES_TYPE_foo into separate patch set Diff to patch set 2: - Device patch was rejected because of patch set "#4 - Add configurable enum_devices() to Device provider and Adopt interface changes to SD & EAFP"

1 3

[PATCH 0 of 5] #3 - Add configurable enum_rasds interface to RASD and Adopt changes to assoc providers
by Heidi Eckhart 10 Mar '08

10 Mar '08

This patch set implements a configurable enum_rasds() interface to the RASD provider. This slight interface change is adopted to the affected associations. Diff to patch set 1: - moved adoption of new resource types CIM_RES_TYPE_foo into separate patch set - fixed style issues Diff to patch set 2: - RASD: fix stlye issues - RAFP: free tmp_list

1 5

[PATCH 0 of 5] #2 - Add configurable enum_rasds interface to RASD and Adopt changes to assoc providers
by Heidi Eckhart 10 Mar '08

10 Mar '08

This patch set implements a configurable enum_rasds() interface to the RASD provider. This slight interface change is adopted to the affected associations. Diff to patch set 1: - moved adoption of new resource types CIM_RES_TYPE_foo into separate patch set - fixed style issues

3 11

[PATCH 0 of 3] #4 - Add configurable enum_devices() to Device provider and Adopt interface changes to SD & EAFP
by Heidi Eckhart 10 Mar '08

10 Mar '08

This patch set implements the configurable enum_devices() interface to the Device provider. This slight interface change is adopted to the associations SystemDevice and ElementAllocatedFromPool. Both associations profit from the easy access to the device instances. Diff to patch set 1: - fixed style issues Diff to patch set 2: - moved adoption of new resource types CIM_RES_TYPE_foo into separate patch set Diff to patch set 3: - fixed style issue - removed unneccsary check with the potential to leak memory

1 3

[PATCH 0 of 3] #3 - Add configurable enum_devices() to Device provider and Adopt interface changes to SD & EAFP
by Heidi Eckhart 10 Mar '08

10 Mar '08

This patch set implements the configurable enum_devices() interface to the Device provider. This slight interface change is adopted to the associations SystemDevice and ElementAllocatedFromPool. Both associations profit from the easy access to the device instances. Diff to patch set 1: - fixed style issues Diff to patch set 2: - moved adoption of new resource types CIM_RES_TYPE_foo into separate patch set

3 10

[PATCH 0 of 7] Update resource types to CIM_RES_TYPE_foo and Adopt changes to affected providers
by Heidi Eckhart 10 Mar '08

10 Mar '08

Created separate patch set for new resource types CIM_RES_TYPE_foo and affected providers.

3 10

[PATCH 0 of 3] Migration Job Indications
by Jay Gagnon 08 Mar '08

08 Mar '08

Just a few changes, detailed per patch. I believe all changes are actually in the third patch.

2 4

[PATCH 0 of 4] #2 Add transport support to VSMigrationService.
by Kaitlin Rupert 08 Mar '08

08 Mar '08

libvirt also allows extra parameters for some of these transport types, but this just providers the basic support. Updates from set 1 to set 2: -See patch Extend the VirtualSystemMigrationSettingData to include an attribute for transport method) -See patch Add URI support to VSMigrationService

1 4

[PATCH 0 of 3] MigrationJob Indications
by Jay Gagnon 07 Mar '08

07 Mar '08

This set breaks CSMI into three indications that track the status of the migration job through its entire lifecycle. There might be a few rough spots in the main patch here, as a seemingly innocuous typo turned into two days of sfcb debugging. As a result, I'm a bit sick of looking at this thing, so if you see something that's not finished product quality, please point it out. I think the overall approach is fairly sound, since it's a pretty straightforward problem.

2 6

[PATCH 0 of 4] Add transport support to VSMigrationService.
by Kaitlin Rupert 07 Mar '08

07 Mar '08

libvirt also allows extra parameters for some of these transport types, but this just providers the basic support.

3 10

[PATCH 0 of 3] #2 - Renamed device function for constistency with other providers
by Heidi Eckhart 07 Mar '08

07 Mar '08

Renamed the device_type_by_classname() to res_type_by_device_classname() for consistency with other interfaces. Diff to patch set 1: - moved adoption of new resource types CIM_RES_TYPE_foo into separate patch set

2 4

[PATCH 0 of 6] #3 - Adopt get_() common look and feel to DevicePool and Adopted interface changes to assocs
by Heidi Eckhart 07 Mar '08

07 Mar '08

Adopted the get_() function look and feel to the DevicePool provider. Updated the association providers that uses these functions. Diff to patch set 1: - patch #1 (svpc_types) - add Resource Pool types to svpc_types.h and map existing types to base resource types - patch #2 (DevicePool) - implement configurable enum_pools() function; adopt resource types - patch #6 (EAFP) - adopt resource types; validate client given device ref - patch #7 (AC) - adopt DevicePool interface changes; updated NOT_FOUND error message to be consistent with others Diff to patch set 2: - unified resource types to CIM_RES_TYPE_foo and adopted these changes to the providers - fixed some style issues Diff to patch set 3: - moved adoption of new resource types CIM_RES_TYPE_foo into separate patch set

2 7

[PATCH 0 of 5] Add configurable enum_rasds interface to RASD and Adopt changes to assoc providers
by Heidi Eckhart 06 Mar '08

06 Mar '08

This patch set implements a configurable enum_rasds() interface to the RASD provider. This slight interface change is adopted to the affected associations.

2 6