[PATCH] [TEST] For Xen enabled systems, a storage volume template is generated for
# HG changeset patch # User Kaitlin Rupert <karupert@us.ibm.com> # Date 1260576721 28800 # Node ID 2a52495fd1c2c47440b65f723366ccc3826f1548 # Parent 5978eee0beb98fb1d2d8780376fc8edd825589d7 [TEST] For Xen enabled systems, a storage volume template is generated for ... Both para virt guests and full virt guests. Signed-off-by: Kaitlin Rupert <karupert@us.ibm.com> diff -r 5978eee0beb9 -r 2a52495fd1c2 suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/10_create_storagevolume.py --- a/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/10_create_storagevolume.py Fri Dec 11 16:12:01 2009 -0800 +++ b/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/10_create_storagevolume.py Fri Dec 11 16:12:01 2009 -0800 @@ -122,8 +122,15 @@ if item['Address'] == exp_vol_path and item['PoolID'] == dp_inst_id: dv_rasds.append(item) - if len(dv_rasds) != 4: - logger.error("Got '%s' StorageVolRASD's expected 4", len(dv_rasds)) + exp_template_rasd = 4 + + if virt == "Xen" or virt == "XenFV": + #There's one of each RASD type for both paravirt Xen and full virt Xen + exp_template_rasd = exp_template_rasd * 2 + + if len(dv_rasds) != exp_template_rasd: + logger.error("Got '%s' StorageVolRASD's expected %s", len(dv_rasds), + exp_template_rasd) return FAIL return PASS
On 12/11/2009 11:16 PM, Kaitlin Rupert wrote:
# HG changeset patch # User Kaitlin Rupert<karupert@us.ibm.com> # Date 1260576721 28800 # Node ID 2a52495fd1c2c47440b65f723366ccc3826f1548 # Parent 5978eee0beb98fb1d2d8780376fc8edd825589d7 [TEST] For Xen enabled systems, a storage volume template is generated for ...
Both para virt guests and full virt guests.
Signed-off-by: Kaitlin Rupert<karupert@us.ibm.com>
diff -r 5978eee0beb9 -r 2a52495fd1c2 suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/10_create_storagevolume.py --- a/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/10_create_storagevolume.py Fri Dec 11 16:12:01 2009 -0800 +++ b/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/10_create_storagevolume.py Fri Dec 11 16:12:01 2009 -0800 @@ -122,8 +122,15 @@ if item['Address'] == exp_vol_path and item['PoolID'] == dp_inst_id: dv_rasds.append(item)
- if len(dv_rasds) != 4: - logger.error("Got '%s' StorageVolRASD's expected 4", len(dv_rasds)) + exp_template_rasd = 4 + + if virt == "Xen" or virt == "XenFV": + #There's one of each RASD type for both paravirt Xen and full virt Xen + exp_template_rasd = exp_template_rasd * 2
Since you can have a system with only paravirt Xen installed, this test will fail (it expects 8 template_rasd's when it should only expect 4).
+ + if len(dv_rasds) != exp_template_rasd: + logger.error("Got '%s' StorageVolRASD's expected %s", len(dv_rasds), + exp_template_rasd) return FAIL
return PASS
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
-- Richard Maciel, MSc IBM Linux Technology Center rmaciel@linux.vnet.ibm.com
Richard Maciel wrote:
On 12/11/2009 11:16 PM, Kaitlin Rupert wrote:
# HG changeset patch # User Kaitlin Rupert<karupert@us.ibm.com> # Date 1260576721 28800 # Node ID 2a52495fd1c2c47440b65f723366ccc3826f1548 # Parent 5978eee0beb98fb1d2d8780376fc8edd825589d7 [TEST] For Xen enabled systems, a storage volume template is generated for ...
Both para virt guests and full virt guests.
Signed-off-by: Kaitlin Rupert<karupert@us.ibm.com>
diff -r 5978eee0beb9 -r 2a52495fd1c2 suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/10_create_storagevolume.py
--- a/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/10_create_storagevolume.py Fri Dec 11 16:12:01 2009 -0800 +++ b/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/10_create_storagevolume.py Fri Dec 11 16:12:01 2009 -0800 @@ -122,8 +122,15 @@ if item['Address'] == exp_vol_path and item['PoolID'] == dp_inst_id: dv_rasds.append(item)
- if len(dv_rasds) != 4: - logger.error("Got '%s' StorageVolRASD's expected 4", len(dv_rasds)) + exp_template_rasd = 4 + + if virt == "Xen" or virt == "XenFV": + #There's one of each RASD type for both paravirt Xen and full virt Xen + exp_template_rasd = exp_template_rasd * 2
Since you can have a system with only paravirt Xen installed, this test will fail (it expects 8 template_rasd's when it should only expect 4).
SDC generates both PV and FV templates; this happens regardless of whether the system supports FV. Is this test failing for you? On your PV-only Xen system, do you not see the FV templates? -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
Kaitlin Rupert wrote:
Richard Maciel wrote:
On 12/11/2009 11:16 PM, Kaitlin Rupert wrote:
# HG changeset patch # User Kaitlin Rupert<karupert@us.ibm.com> # Date 1260576721 28800 # Node ID 2a52495fd1c2c47440b65f723366ccc3826f1548 # Parent 5978eee0beb98fb1d2d8780376fc8edd825589d7 [TEST] For Xen enabled systems, a storage volume template is generated for ...
Both para virt guests and full virt guests.
Signed-off-by: Kaitlin Rupert<karupert@us.ibm.com>
diff -r 5978eee0beb9 -r 2a52495fd1c2 suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/10_create_storagevolume.py
--- a/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/10_create_storagevolume.py Fri Dec 11 16:12:01 2009 -0800 +++ b/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/10_create_storagevolume.py Fri Dec 11 16:12:01 2009 -0800 @@ -122,8 +122,15 @@ if item['Address'] == exp_vol_path and item['PoolID'] == dp_inst_id: dv_rasds.append(item)
- if len(dv_rasds) != 4: - logger.error("Got '%s' StorageVolRASD's expected 4", len(dv_rasds)) + exp_template_rasd = 4 + + if virt == "Xen" or virt == "XenFV": + #There's one of each RASD type for both paravirt Xen and full virt Xen + exp_template_rasd = exp_template_rasd * 2
Since you can have a system with only paravirt Xen installed, this test will fail (it expects 8 template_rasd's when it should only expect 4).
SDC generates both PV and FV templates; this happens regardless of whether the system supports FV. Is this test failing for you? On your PV-only Xen system, do you not see the FV templates?
Ack - my mistake here. This test is for storage volumes. Not for assigning a disk to a guest. So in this context, PV and FV don't apply. This patch doesn't address the issue. I'll send an updated version. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
+ + if virt == "Xen" or virt == "XenFV": + #There's one of each RASD type for both paravirt Xen and full virt Xen + exp_template_rasd = exp_template_rasd * 2
Since you can have a system with only paravirt Xen installed, this test will fail (it expects 8 template_rasd's when it should only expect 4).
SDC generates both PV and FV templates; this happens regardless of whether the system supports FV. Is this test failing for you? On your PV-only Xen system, do you not see the FV templates?
Ack - my mistake here. This test is for storage volumes. Not for assigning a disk to a guest. So in this context, PV and FV don't apply. This patch doesn't address the issue. I'll send an updated version.
Sorry for all the confusion here. I'm including a detailed note on the rework of the patch. Let me know if this test fails for you, or if you don't see both PV and FV templates on your Xen host. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
participants (2)
-
Kaitlin Rupert -
Richard Maciel