Veerendra wrote: Can you send your patch using hg's email feature? That makes it easier to review. Need to add DCO to the patch itself. 'http://root:passwd@localhost:5988/root/virt:KVM_KVMRedirectionSAP. \ CreationClassName="KVM_KVMRedirectionSAP",Name="1:1",SystemCreationClassName= \ These lines are longer than 80 characters. These aren't used in this test. This should also run on Xen, XenFV, and LXC. console >port for guest" }, Some of these lines are longer than 80 characters. These return messages only work with Pegasus. This test fails with sfcb. This should be cim_define(), not define(). + ret = vsxml.start(options.ip) + if not ret: + logger.error("Failed to Create the dom: %s", test_dom) + return FAIL Don't use global variables. (CIM_USER, CIM_PASS), CIM_NS) This line is longer than 80 characters. Remove the global here too. + classname = get_typed_class(options.virt, 'KVMRedirectionSAP') + name_val = [ + 'CreationClassName', classname, get_typed_class(options.virt, 'ComputerSystem'), This line is longer than 80 characters. You don't need to test the invalid key names - this tests the CIMOM itself and not the providers. The CIMOM's return their own error messages and return codes for invalid key names - we have no way of controlling these values or this behavior. This test is a little difficult to read. The logic in try_invalid_gi() can be simplified if the test is restructured a bit. I'd reorganize it with the following: In main: 1) Define guest 2) Use a dictionary for the key values: key_vals = { 'SystemName': test_dom, 'CreationClassName': classname, 'SystemCreationClassName': sscn, 'Name': name } 3) Create a tc_scen dictionary - have the key of the dictionary be the same as the invalid value you'll set for key value (also have it be the same as the values used for the exp_values dictionary): test_val : field tc_scen = { 'invalid_ccname' : 'CreationClassName', 'invalid_sccname' : 'SystemCreationClassName', 'invalid_nameport' : 'Name', 'invalid_sysval' : 'SystemName', } 4) Loop through the items in tc_scen - call try_invalid_gi(test_val, field) each time through. 5) If try_invalid_gi() encounters an error, break from the for loop 6) Undefine the guest and return status In try_invalid_gi(): 1) Have this function take the values from tc_scen. Also have it take key vals. 2) Copy key_vals to keys using .copy() 3) Set the value of keys appropriately: keys[field] = test_val 4) Call try_getinstance(conn, cn, keys, test_val, expr_values[test_val], bug_no="") -- Kaitlin Rupert IBM Linux Technology Center kaitlin(a)linux.vnet.ibm.com