Re: [Libvirt-cim] [PATCH] Add revision information to the VSMS
Dan Smith wrote:
# HG changeset patch
# User Dan Smith <danms(a)us.ibm.com>
# Date 1207934505 25200
# Node ID 52e2f501b44994af849df3a8e354bbe6097cd9d6
# Parent 17cf33b5cf9ac533d51f73037a6f08499dc0a67b
Add revision information to the VSMS
This is done at build time, if possible. If not, the changeset/revision
at the last automake run will be used. This should make it work for the
tarball/release case as well as the RPM build.
The way this works, if you build, then apply a patch or pull a new changeset,
the exposed revision/version information will be stale unless you do a clean.
Since this is really just for the purposes of test-tracking, I think this
is a reasonable restriction that can be minded by the people doing testing.
The changeset hash and revision number are exposed in aptly-named properties
of the VSMS for each platform. If anyone has a better place for these to
show up, or a better format, please bring it up.
You'll also need to modify the mof file to add the new attributes, right?
I think this a neat approach. I'm not sure whether VSMS is the correct
place.. I initially thought this would be good to add to the profile,
but I don't know if we want to advertise this info there.
The SoftwareIdentity class has attributes for this kind of information,
but it definitely doesn't fit in the scope of the VSP and SVP.
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com