Re: [Libvirt-cim] [PATCH 2 of 2] Clean up CSI/CSMI integration

JG> + /* Generally report errors and hope to continue, since we have no one JG> + to actually return status to. */ JG> if (ind == NULL) { JG> CU_DEBUG("Failed to create ind"); JG> - return false; JG> + ret = false; JG> } I know you didn't change this, but can we report a little more information in the debug? Type of indication, affected domain (if it's easy to get), etc., would be nice, I think. JG> ind_op = CMGetObjectPath(ind, &s); JG> if (s.rc != CMPI_RC_OK) { JG> CU_DEBUG("Failed to get ind_op"); JG> - return false; JG> + ret = false; JG> } Here, printing s.msg would also be good, I think. Since indications are kinda off in their own world, it seems like printing the CIMOM's reason for not creating objects would help debugging down the road. Also, don't we need a trigger_indication() in VSMS in the modify path? Otherwise looks pretty good, I'd say. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms(a)us.ibm.com