Re: [Libvirt-cim] [PATCH 3 of 6] Add Disk support to SettingsDefineCapabilities. Still lacks a bit of polish (i.e. lack of warning when minimum or default is higher than maximum), but is functional

JG> # HG changeset patch JG> # User Jay Gagnon <grendel(a)linux.vnet.ibm.com&gt; JG> # Date 1194557358 18000 JG> # Node ID 94308147bed1693443d0741de6a30c5b0f77b0f1 JG> # Parent 543a0790d8615551153950de8f2f2fe3de107cf3 JG> Add Disk support to SettingsDefineCapabilities. Still lacks a bit of polish (i.e. lack of warning when minimum or default is higher than maximum), but is functional. I think this looks okay, but: JG> +#define SDC_DISK_MIN 2000 JG> +#define SDC_DISK_DEF 5000 Why not make the increment amount also parameterized as such? Seems like a valid thing to want to change. Unlikely, but valid :) -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms(a)us.ibm.com