Re: [Libvirt-cim] [PATCH 1 of 2] Make the migration check functions aware of MSD
+static CMPIStatus get_msd_check_values(const CMPIObjectPath *ref,
-
-static CMPIStatus get_msd_values(const CMPIObjectPath *ref,
- const CMPIArgs *argsin,
- struct migration_job *job)
+static CMPIStatus get_msd_job_values(const CMPIObjectPath *ref,
+ const CMPIArgs *argsin,
+ struct migration_job *job)
{
I was thinking maybe you could condense these functions some. Instead
of having a transport field in the job struct, you could have a uri field.
So, you could have a function that is called get_msd_values() that has
everything from get_msd_check_values() except the virConnectPtr /
connect_by_classname() part. get_msd_check_values() would just call
get_msd_values() plus the connect_by_classname() bit.
Then the check functions could call get_msd_check_values() and the
migrate functions could call get_msd_values().
Probably not worth the reordering and work though.
Otherwise, I have no issues here. This set tested fine on my system.
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com