Re: [Libvirt-cim] [PATCH] [TEST] Adding 01_enum_KVMredSAP.py of KVMRedirectionSAP
Kaitlin Rupert wrote:
Deepti B. Kalakeri wrote:
> # HG changeset patch
> # User Deepti B. Kalakeri <deeptik(a)linux.vnet.ibm.com>
> # Date 1232718867 28800
> # Node ID 7279b969bfff758c7b24fc2223826fe7ffafb3f2
> # Parent a2ecb7430c50fcf6df6019625ee1a8b8ae24dfd9
> [TEST] Adding 01_enum_KVMredSAP.py of KVMRedirectionSAP.
>
> Signed-off-by: Deepti B. Kalakeri <deeptik(a)linux.vnet.ibm.com>
On my system with LXC, I got the following error:
KVMRedirectionSAP - 01_enum_KVMredSAP.py: FAIL
ERROR - Exception details: 'ElementName' Value Mismatch, Expected
5967:0, Got 5967:-1
ERROR - Exception: Failed to verify information for running
dom:test_kvmredsap_dom
Container's guests don't really have the proper support for graphics.
For now, I would just verify this for a defined guest.
Yes this test fails for LXC
as of now.
I had sent a separate mail regarding this behavior to the mailing list.
> +import sys
> +import random
This should be:
from random import randrange
Changed.
> +
> +def enum_redsap(server, virt, classname):
> + redsap_insts = { }
> + status = FAIL
> +
> + try:
> + redsap_list = EnumInstances(server, classname)
> + for redsap in redsap_list:
> + guest = redsap.SystemName
> + if guest == test_dom:
You don't use guest anywhere else but here, so just do:
if redsap.SystemName == test_dom
done.
Submitted a new patch with all these changes.
--
Thanks and Regards,
Deepti B. Kalakeri
IBM Linux Technology Center
deeptik(a)linux.vnet.ibm.com