Re: [Libvirt-cim] [PATCH 0/2] Add rawio/sgio tag property support
On 03/02/2014 08:04 PM, Xu Wang wrote:
They are needed by virtio-scsi so add them into libvirt-cim support
Xu Wang (2):
Add rawio property support
Add sgio property support
libxkutil/device_parsing.c | 8 ++++++++
libxkutil/device_parsing.h | 2 ++
libxkutil/xmlgen.c | 4 ++++
schema/ResourceAllocationSettingData.mof | 6 ++++++
src/Virt_RASD.c | 12 ++++++++++++
src/Virt_VirtualSystemManagementService.c | 10 ++++++++++
6 files changed, 42 insertions(+), 0 deletions(-)
These look OK, but the existing cimtest had some new failures; however,
I believe that those failures had to do with me running the latest git
head and there is a new device to deal with (sigh), see:
http://www.redhat.com/archives/libvir-list/2014-February/msg01058.html
Although I'm OK with the changes - I would like to see a test to verify
that this works.
Whether that's a cimtest or even adjusting the checkin message to add
new files and/or scripts to validate.
I have to assume this is desired to be backported into RHEL6.next at
some point. In order to do that - I really need a test.
John