Re: [Libvirt-cim] [PATCH 1 of 2] [TEST] Modified the indication_tester.py to support MigrationIndications

Deepti B. Kalakeri wrote: > # HG changeset patch > # User Deepti B. Kalakeri <deeptik(a)linux.vnet.ibm.com&gt; > # Date 1246972788 25200 > # Node ID 9903b1d91bd966f453392ddbd0378feb50a4f771 > # Parent 479f287a17fd08e4e22ac37459393f6f8327315a > [TEST] Modified the indication_tester.py to support > MigrationIndications. > > Modified indication_tester.py to include > - sub_ind() --> Subscribe for the indications to be watched. > - handle_request() --> Filters the required indications. > - poll_for_ind() --> Wait for the required indications to be triggered. > > Tested with KVM and current sources on F10. > Signed-off-by: Deepti B. Kalakeri <deeptik(a)linux.vnet.ibm.com&gt; > > diff -r 479f287a17fd -r 9903b1d91bd9 > suites/libvirt-cim/lib/XenKvmLib/indication_tester.py I'm torn on whether to include these changes in this file. Really, the indication_tester.py was a standalone tool that wasn't originally included in the cimtest tree. It was pulled in later so that the automated test cases could leverage its functionality. Anytime a change is made to other copy, the changes need to be pushed to the other so that the two remain in sync. These changes won't ever be used by the indication_tester.py itself, so I'm inclined to suggest moving them into their own module. Generally, I'm against having lots of different modules - I am in favor of consolidating where appropriate. However, I think this makes sense given that indication_tester is a special case.