Re: [Libvirt-cim] [PATCH 3 of 3] Add support for representing a cdrom device using the DiskDrive class
This set of changes breaks the behavior of several providers. Those
issues need to be addressed and included in this patchset before it can
be applied.
Broken behavior:
ElementAllocatedFromPool:
-Can no longer associate a disk to the pool it was allocated from.
-Can no longer associate a pool to the disks that have been allocated
from it
SettingsDefineCapabilities: Can no longer generate template RASDs for
disk and cdrom devices
DiskResourceAllocationSettingData: enum doesn't return instances for
DiskDrives
ResourceAllocationFromPool: Unable to associate DiskRASDs to pools or
pools to DiskRASDs
+static CMPIInstance *drive_instance(const CMPIBroker *broker,
+ struct disk_device *dev,
+ const virDomainPtr dom,
+ const char *ns)
+{
+ CMPIInstance *inst;
+ virConnectPtr conn;
+
+ conn = virDomainGetConnect(dom);
Need to check to see if conn is NULL.
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com