Re: [Libvirt-cim] [PATCH 2 of 2] Add calls into VSMigrationService to utilize new MigrationIndication provider
Heidi Eckhart wrote:
Jay Gagnon wrote:
> # HG changeset patch
> # User Jay Gagnon <grendel(a)linux.vnet.ibm.com>
> # Date 1202224718 18000
> # Node ID c24b2e6d1bce44af234d379cfc8b7ee116621109
> # Parent fdce6fa993b5a9dce654b3e0cf527599f86b9f67
> Add calls into VSMigrationService to utilize new MigrationIndication
> provider.
>
> Changes from #1 to #2:
> Break out indication code from migration_job_set_state.
> Changed cu_dup_instance call to match new signature.
>
> Signed-off-by: Jay Gagnon <grendel(a)linux.vnet.ibm.com>
>
> diff -r fdce6fa993b5 -r c24b2e6d1bce src/Virt_VSMigrationService.c
> --- a/src/Virt_VSMigrationService.c Tue Feb 05 10:18:37 2008 -0500
> +++ b/src/Virt_VSMigrationService.c Tue Feb 05 10:18:38 2008 -0500
> @@ -34,6 +34,7 @@
> #include "misc_util.h"
> #include <libcmpiutil/std_instance.h>
> #include <libcmpiutil/std_invokemethod.h>
> +#include <std_indication.h>
>
It's maybe my ignorance now, but should this also be "#include
<libcmpiutil/std_indication.h>" as in the lines before ?
No, I'd imagine you're right there. I'm not sure how I didn't
notice
the prefix when I put that line in; it all compiles and links so I never
went back to look at that line again. Dan, is this the kind of thing
you can fix when you put the patch in? If this is the only remaining
issue it seems a little silly to resend the set again, but I of course
can if that's preferred.
--
-Jay