Guo Lian Yun wrote:
libvirt-cim-bounces(a)redhat.com wrote on 2008-04-17 05:37:38:
> > +# Guolian Yun <yunguol(a)cn.ibm.com>
>
> Being as most of the test cases will need to be changed from time to
> time, we should leave the author's list as is.
>
> > test_mem = 128
> > test_vcpus = 4
> > -test_disk = "xvdb"
> > test_dpath = "foo"
> > disk_file = '/tmp/diskpool.conf'
>
> This test should use the diskpool support in the provider. This means a
> diskpool needs to be created if one doesn't exist already. Otherwise,
> this test fails.
>
> For RHEL 5.2 - we'll need to ignore the diskpool stuff and use a file.
> Since you need to write a function that creates the diskpool, you could
> have the function check the version of libvirt and then either create a
> diskpool or create diskpool file accordingly (thanks to Dan for the help
> with this).
>
I've just add a function that creates the diskpool now, on the next plan,
the general diskpool config function will be moved to a library, I
will update all related test. Also, I will create a diskpool file in lib
using for RHEL 5.2, then ElementAllocatedFromPool will changed
accordingly.
Thanks!
I don't see the diskpool function in the patches you sent - is this in a
separate patch?
Here's the patches I see:
.3# update network_by_bridge for KVM & XenFV support
.3# add ElementAllocatedFromPool.01 for KVM & XenFV support
.4# add ElementAllocatedFromPool.02 for KVM & XenFV support
Am I missing one? Also, when you send an update, can you add a note to
the log that indicates what changed between the two patches?
Thanks!
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com