> >
> > I agree with these comments. Daisy - can you resend the patch with
> > these updates?
>
> I think it's better to align them as follows:
> m = class_masd(megabytes=mem_mb,
> mallocunits=malloc_units,
> name=dom_name)
> Also, the other functions such as network and processor call have to
> be updated.
> I resend a new patch to fix them.
>
> Thanks!
I usually follow this style
m = class_masd(megabytes=mem_mb,
mallocunits=malloc_units,
name=dom_name)
(i.e. aligning the function parameters, like in C). But, to be honest,
there isn't a written convention on that and I didn't find any existing
case on the code, so we can follow the style.
See Dan's comment - the spacing is slightly off in this alignment.
Daisy has the alignment fixed in the second revision of her patch.
There isn't a coding style document for cimtest yet. However, I can
work on putting on together since it is a good thing to have.
--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin(a)linux.vnet.ibm.com