Re: [Libvirt-cim] [PATCH] Set additional attribute values in Virt_ComputerSystem.c

This is a style thing, I guess, but wouldn't it be easier to combine this function with the one that sets the descriptions? You could loop through both string arrays at the same time and construct the two CMPIArrays together. The two functions are almost identical, so I think doing them together would add six lines to the above function instead of the 30 it takes for the separate function.

...and then again here. KR> + } KR> + KR> /* More attributes here, of course */ KR> + KR> + free(uuid); KR> return 1; KR> } Can we get either an "err:" target or a return variable and an "out:" target please? :)